From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA743189F56; Tue, 3 Dec 2024 20:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733258152; cv=none; b=Px9FzYo0qZVrQ5VXOpAeV83rIHhOU56kD0jLRPUNwdKx4x1cGgbv1isaTpfQzCuY7VZmXYm1kTYv7gRhFegW3q354gjUggSl9z+DbaWn8GVIsJ9jW30G8Na3EVBNg5VOmWZ0BLzcgToy7xo8i+0mR9TVl/p/TLPwIrudw5yhdB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733258152; c=relaxed/simple; bh=3XFuyDVd24VNId3mtojt/s2zg943OWmadIp5MN1XvSc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HpEZuGAdcx9plywsu4L4P5GbZFzBr92GkDM16EvgrbBsn/ArADnZv0hvtrrATBpyHrd12P69smZclC60sW5pdxYBXYKXbfqMc3gtIp+RKO/UVncjgl4laK42r4dNKmRuZqlwXaxsxQ8BlGBa5LPlvcR9t0kUgzRO+PHPCzceJUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=QKQo2a1n; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="QKQo2a1n" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XNUfzojEoIvPMsw7o5EQsm4flrwBcXxoTxbRJXaPFAY=; b=QKQo2a1nk6P25Xj4/v/PVvI61b U+IcTWv8NQcLQJVs1rn516ArAyXOtvfrrpRMhBX06ALJ+gn3ZqVb2MSbDZx6+dQ+n6qJmx035Gw3z lxBgDGZCD6jlXf9eLy8pG269wUo4f0tM9PAc5Ba8z7ZxFs/0t/5rTalBR4BRw3V9e9Y4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tIZcV-00F8BB-T5; Tue, 03 Dec 2024 21:35:43 +0100 Date: Tue, 3 Dec 2024 21:35:43 +0100 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , Andrew Lunn , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Phil Elwell Subject: Re: [PATCH net-next v1 06/21] net: usb: lan78xx: Improve error handling in EEPROM and OTP operations Message-ID: References: <20241203072154.2440034-1-o.rempel@pengutronix.de> <20241203072154.2440034-7-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203072154.2440034-7-o.rempel@pengutronix.de> On Tue, Dec 03, 2024 at 08:21:39AM +0100, Oleksij Rempel wrote: > Refine error handling in EEPROM and OTP read/write functions by: > - Return error values immediately upon detection. > - Avoid overwriting correct error codes with `-EIO`. > - Preserve initial error codes as they were appropriate for specific > failures. > - Use `-ETIMEDOUT` for timeout conditions instead of `-EIO`. > > Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn Andrew