From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
jamipkettunen@somainline.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] arm64: dts: qcom: sdm845-tama: Add display nodes
Date: Sat, 1 Oct 2022 22:02:44 +0200 [thread overview]
Message-ID: <ce228356-67ee-01cc-3ea7-cea16a548d52@somainline.org> (raw)
In-Reply-To: <20221001145457.yvy5swfqmzothhy7@SoMainline.org>
On 1.10.2022 16:54, Marijn Suijten wrote:
> On 2022-09-30 21:10:42, Konrad Dybcio wrote:
>> Add required nodes to support display on XZ2/XZ2c. XZ3 has a
>> different power rail setup and needs to be handled separately.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>> ---
>> .../qcom/sdm845-sony-xperia-tama-akari.dts | 4 +
>> .../qcom/sdm845-sony-xperia-tama-akatsuki.dts | 44 ++++++++-
>> .../qcom/sdm845-sony-xperia-tama-apollo.dts | 6 ++
>> .../dts/qcom/sdm845-sony-xperia-tama.dtsi | 96 +++++++++++++++++++
>> 4 files changed, 149 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
>> index 34f84f1f1eb4..d97b7f1e7140 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
>> @@ -11,3 +11,7 @@ / {
>> model = "Sony Xperia XZ2";
>> compatible = "sony,akari-row", "qcom,sdm845";
>> };
>> +
>> +&panel {
>> + compatible = "sony,td4353-jdi-tama";
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
>> index 2f5e12deaada..2a16305ac5da 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
>> @@ -10,9 +10,51 @@
>> / {
>> model = "Sony Xperia XZ3";
>> compatible = "sony,akatsuki-row", "qcom,sdm845";
>> +
>> + /* Fixed DCDC for the OLED panel */
>> + ts_vddio_supply: ts-vddio-regulator {
>> + compatible = "regulator-fixed";
>> + regulator-name = "ts_vddio";
>> +
>> + regulator-min-microvolt = <1840000>;
>> + regulator-max-microvolt = <1840000>;
>> +
>> + gpio = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + regulator-boot-on;
>> + };
>> +};
>> +
>> +&ibb {
>> + status = "disabled";
>> +};
>> +
>> +&lab {
>> + status = "disabled";
>> +};
>> +
>> +&panel {
>> + /* Akatsuki uses an OLED panel. */
>> + /delete-property/ backlight;
>> + /delete-property/ vsp-supply;
>> + /delete-property/ vsn-supply;
>> + /delete-property/ treset-gpios;
>
> This looks to have been a last-minute rename to
>
> touch-reset-gpios
Yep!
Konrad
>
>> +};
>> +
>> +&pmi8998_wled {
>> + status = "disabled";
>> +};
>> +
>> +&tlmm {
>> + ts_vddio_en: ts-vddio-en {
>> + pins = "gpio133";
>> + function = "gpio";
>> + drive-strength = <2>;
>> + bias-disable;
>> + output-high;
>> + };
>> };
>>
>> -/* For the future: WLED + LAB/IBB/OLEDB are not used on Akatsuki */
>> &vreg_l14a_1p8 {
>> regulator-min-microvolt = <1840000>;
>> regulator-max-microvolt = <1840000>;
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts
>> index c9e62c72f60e..cd056f78070f 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts
>> @@ -11,3 +11,9 @@ / {
>> model = "Sony Xperia XZ2 Compact";
>> compatible = "sony,apollo-row", "qcom,sdm845";
>> };
>> +
>> +&panel {
>> + compatible = "sony,td4353-jdi-tama";
>> + height-mm = <112>;
>> + width-mm = <56>;
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> index 51ee42e3c995..ac8eb59ed010 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> @@ -326,6 +326,46 @@ vreg_s3c_0p6: smps3 {
>> };
>> };
>>
>> +&dsi0 {
>> + vdda-supply = <&vreg_l26a_1p2>;
>> + status = "okay";
>> +
>> + panel: panel@0 {
>> + /* The compatible is assigned in device DTs. */
>> + reg = <0>;
>> +
>> + backlight = <&pmi8998_wled>;
>> + vddio-supply = <&vreg_l14a_1p8>;
>> + vsp-supply = <&lab>;
>> + vsn-supply = <&ibb>;
>> + panel-reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
>> + touch-reset-gpios = <&tlmm 99 GPIO_ACTIVE_HIGH>;
>
> Here.
>
> - Marijn
next prev parent reply other threads:[~2022-10-01 20:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220930191049.123256-1-konrad.dybcio@somainline.org>
2022-09-30 19:10 ` Konrad Dybcio
2022-09-30 20:10 ` Krzysztof Kozlowski
2022-09-30 20:10 ` Konrad Dybcio
2022-09-30 20:14 ` Krzysztof Kozlowski
2022-09-30 20:16 ` Konrad Dybcio
2022-10-01 14:54 ` Marijn Suijten
2022-10-01 20:02 ` Konrad Dybcio [this message]
2022-09-30 19:10 ` [PATCH 2/8] arm64: dts: qcom: sdm845-tama: Add Synaptics Touchscreen Konrad Dybcio
2022-09-30 20:12 ` Krzysztof Kozlowski
2022-09-30 19:10 ` [PATCH 3/8] arm64: dts: qcom: sdm845-tama: Add regulator-system-load to l14a/l28a Konrad Dybcio
2022-09-30 19:10 ` [PATCH 4/8] arm64: dts: qcom: sdm845-tama: Enable remoteprocs Konrad Dybcio
2022-09-30 19:10 ` [PATCH 5/8] arm64: dts: qcom: sdm845-tama: Enable GPU Konrad Dybcio
2022-09-30 19:10 ` [PATCH 6/8] arm64: dts: qcom: sdm845-tama: Enable GPI_DMA0/1 Konrad Dybcio
2022-09-30 19:10 ` [PATCH 7/8] arm64: dts: qcom: sdm845: Don't use 0x in unit address Konrad Dybcio
2022-09-30 19:10 ` [PATCH 8/8] arm64: dts: qcom: sdm845-akatsuki: Configure maXTouch touchscreen Konrad Dybcio
2022-10-01 8:53 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce228356-67ee-01cc-3ea7-cea16a548d52@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®