From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080A9C64EC7 for ; Wed, 8 Feb 2023 07:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbjBHHWZ (ORCPT ); Wed, 8 Feb 2023 02:22:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbjBHHWX (ORCPT ); Wed, 8 Feb 2023 02:22:23 -0500 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E6EE8A70 for ; Tue, 7 Feb 2023 23:22:22 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B31EE3200904; Wed, 8 Feb 2023 02:22:17 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 08 Feb 2023 02:22:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1675840937; x=1675927337; bh=nGo5PwpZwS KOtQGCgUwGUupaP5O/PMh+8I0vq8PnmXg=; b=iy0yM7X0CGOwst4PTZOPXmP1kh 6z2iVfdSYhWs8J73KqdJ70VHIX5A83OT92hBuDZlkfgxL4zDPBIboofIKfewThlb snpk726BNU7MMDxujtzLa4PgBb+utSwrhZXsDQheLKCuoLlMsc3I7L3s9nHyM4iO fF7FPLaLtKZZePLk/R15aIl57DNIX2QNsPOkIugIzwHR09lYuAZdR0hMM/oIKj/+ odCCbr6kdOLkDf23UPDD3XcbBIwyj8fSbIIuxd1eDShSTeHVIodVoRn7Jlm8PfrP AvYN/rC39/mU9ROtyAHOn/eqFw6vG2YWmwgOzh5p33a4lZ08834rsboNJaig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675840937; x=1675927337; bh=nGo5PwpZwSKOtQGCgUwGUupaP5O/ PMh+8I0vq8PnmXg=; b=fsFsjzKN1oOTkg2k3crEgXP3I7riBWfpIAJxZFuVyL1A k5vENfNLKNQgYo93eLQB2d3fixYMiESKcDoX8YfJsTT2/oogQ4B863IxXJhsW+8D pOFFg8l1Dkc7YMz7w9hcQzaL+jD1THv0X4c/ALe00/ccTX2o49HPJb+lYEmfF4FY 1M2YUoHju1Z8zUS8m+3QxqHq2fPVr+rYxt7YMwBhrQ2sGhDS7vspSFv5jllHwrsy s2ENFRFyEvs4TisRoV67qAULD4AxmnpCMvdponE5A3QhgO4Xf31M9EZ7Ze+Gyt62 g+J1+Ecg98eV9TAhaXuRk3z1eoMoTq34+aqEnh/4Yw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0170DB60086; Wed, 8 Feb 2023 02:22:16 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e Mime-Version: 1.0 Message-Id: In-Reply-To: <20230208070559.19589-1-jiasheng@iscas.ac.cn> References: <20230208070559.19589-1-jiasheng@iscas.ac.cn> Date: Wed, 08 Feb 2023 08:21:58 +0100 From: "Arnd Bergmann" To: "Jiasheng Jiang" , "Oded Gabbay" , "Greg Kroah-Hartman" , ttayar@habana.ai, dliberman@habana.ai, obitton@habana.ai, osharabi@habana.ai, dhirschfeld@habana.ai Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] habanalabs: Fix freeing uninitialized pointers Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 8, 2023, at 08:05, Jiasheng Jiang wrote: > As the memory allocated by kcalloc has not been set to zero, it may > contain uninitialized pointers. > Therefore, free the non-NULL pointers may cause undefined behaviour. > > Fixes: 5574cb2194b1 ("habanalabs: Assign each CQ with its own work queue") > Signed-off-by: Jiasheng Jiang Did you run into a bug here or find that by inspection? kcalloc() is definitely meant to return zeroed memory, so I don't see a bug here: static inline __alloc_size(1, 2) void *kcalloc(size_t n, size_t size, gfp_t flags) { return kmalloc_array(n, size, flags | __GFP_ZERO); } Arnd