From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CDA33E928E for ; Thu, 23 Apr 2026 11:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776944203; cv=none; b=Zq5alOW8xIosrKJkj3OE2PSXoKBzDrdhvtcwkH3JQygOPVOCz4X49Nz/zmMW1bKpOkOskutNj+Cnb2DOyPhYvfDLUL/qlrwHA8TwYdlVvUH9Ej4KZjwWhutZ13UypfiQYwUYYqUh1n1xiPR+n4qC+VL8+pfmt5+JnLN6lr/fh/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776944203; c=relaxed/simple; bh=ycCYcFDws687lzPHf4a7ZDQa8w8dkehTffSeJoBHKeY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jhKVXwCsy+jOeDI0MHlpYlXUWKUuZ+RIuIfEw4UmfYqQXoFgLQgS2cRDZBoq93lX3SVKIpCt3zvt+b+bTHZLWv2/2tfHruxYNp3NbV/29NBO/nXffwDnAvl09T+0w3AlcX/XC0k0cVo1vEFWn3XZHYqtjcsJY2cLzEgDyduXRxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZgZfOxAj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Eo5nJ0HJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZgZfOxAj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Eo5nJ0HJ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u4xp3769013 for ; Thu, 23 Apr 2026 11:36:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C4IVUQBFdsEG3fN5g34uqrFUD35jsuqyNZ/138Z4VVw=; b=ZgZfOxAjPxVx5KBz M4gXrD1z8OdjWaxuRMaot0/RjOdVU1RYD/dM1HTr//hRHN+xF3/na5P2y6mrg90e YwgldGzrmoeJgyfeEEzINXBV/Z20joUkbIBPMq66Y2vw30egfAKkzKnBTumdOjdy vd8ecnk/zxAHGM4aL9YtFLmwLQlY0KcEvqiw4rLF38LnKidn1MdjsJAu7pXTo+mG KPQ/c1VPaiGvpw7IlBi0ejPtjBKDVOqawKr28ODDmB2pJwXA+sn0DJUF3kDm0R15 nwEob8lA+70+zFhOFMqpo9Z2JmrBx/FsE9wYYOGIg2mD1y/0HESSSRc7U3tELC/u zNkHPw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1hq3m65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 11:36:39 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8eec753a7bdso82482285a.3 for ; Thu, 23 Apr 2026 04:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776944199; x=1777548999; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C4IVUQBFdsEG3fN5g34uqrFUD35jsuqyNZ/138Z4VVw=; b=Eo5nJ0HJBKnHrOR/uinb0nAGPzCLDRy8cyNOZIMJ4p3Dsi0dzy/sYNTHcV1Jqv8SxV 3tapUhWzAfz5XkI2F/G8A4XWjeA7hE6J4lb6qdlsFUWX1MCd8evMQXp2mHX48tDoBWbJ 60bpVud79Sy4m+2odkpSl3xnwaR6Fgm5y1iF6+cg7I42MOei9eT5VN1FUtU/o1I2Fe67 /+OXS6z90Mp7ZzDFQ03kncYs2oau4j5OI9FWf66/WsOHRtx8+jskLNUxTfLqiqy1BFGG Bk0VzVm3GHyvbmfCMECyHG3UTRZWiBOUM0YvCHLtCFT5hEcLk+iu64gehT6WsYgrb5vN 73pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776944199; x=1777548999; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C4IVUQBFdsEG3fN5g34uqrFUD35jsuqyNZ/138Z4VVw=; b=DXZT9NYvQjKnzZJ8DjneJr1pUk5yome1JUNOEOJR6y2YKtmCQSpuJc07cZ6gHpVW28 L6KgWnNFPnNZBB/gh8vb2gQnTNYN02ZGHANqv5CWp9o0rQa64cjCYxCOrEPO7wjjGe6F 5sKq2A/MAPfHJSvqjUguXLZyVQAIVQ+8Zb1tezyZinZLZKrHX3gffNVyCSqsSc3jjxp8 XmSMnF81vTfJ7+bSPS+IWLjK+VP5vtQy2Frf+mKPl8/Id+CVqitM3H+ezXgoQkRF7f70 qN8LlVrSxja+8BMyZfP9s3avhofDFIdZHYWTDCwBOZrsQlKtTt69E8yBARn66LYHbgSI 0evg== X-Forwarded-Encrypted: i=1; AFNElJ+1UpH5XVpiQsjC0FRtO7pRvbKGoZK/G9Yx40KgX4X7NOXs2W8Gd94ZtMOF5FKR7dTapF2GB6oGSaEtev8=@vger.kernel.org X-Gm-Message-State: AOJu0YzbmJMvI0i7AghV2GnQhfLbVCj5ln5Zt45sFk+0bWXizyTwcK72 4hQ1WI7gy67yyIBo8XL152vgNjqvw8PPm48NmzR0cesEGNJHtVKRfCzuqYtUul3HBfbTElJwhZD /+eRupsiMBlAhcN3LWq5geP7I5HQCu/YJhvm1r/m2B3yqWHw+3aKD69AmXTOBB6rVR2E= X-Gm-Gg: AeBDiev7EByFg5jQ9jeuvmyYLoxujGBCLujnFgAUZ5i3N9scbCoOAqX5Xztn0LSEhmS rJyaBjpKc3OwywgHgqf+/igNCylP9zMpsd/7fGOH7tjSx1Z259SPPNmimyNQ1fAS/p9E56dVzDM idg/8igsMfHLp8I/WFoYzWQXeeElfMFlQfA4THi1QTOQ17Ill4w0BYW0p441bLgozdd74vFAxdK AANhpl0bXrTRJr33EYuOkPcHPatgqc3tecs9G4ne3Jy3uBZKk731pDBKnnKB5RjNd1HX3BTnPho M/ac7VD0Hy8FlzEp+BjcVNbUK5FFNGjrIwrm//K1Pwp0ntT8tRPmOQznjRTwqQ41hojHSb72F3s KTsvtxMbkIORx/v9ncGzRGki3wEUG7cxZtRAK34maiikjIScggVSfQ6BRkCCf5DCl+xZohcby99 tv67Ij5diPiuwZEw== X-Received: by 2002:ac8:5d53:0:b0:50f:b9a6:82ae with SMTP id d75a77b69052e-50fb9a68ec7mr100777351cf.2.1776944198953; Thu, 23 Apr 2026 04:36:38 -0700 (PDT) X-Received: by 2002:ac8:5d53:0:b0:50f:b9a6:82ae with SMTP id d75a77b69052e-50fb9a68ec7mr100776841cf.2.1776944198503; Thu, 23 Apr 2026 04:36:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba455533bdfsm648444466b.57.2026.04.23.04.36.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 04:36:37 -0700 (PDT) Message-ID: Date: Thu, 23 Apr 2026 13:36:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4 To: contact@alex-min.fr, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Guru Das Srinagesh , Linus Walleij , Rob Clark , Joerg Roedel , Will Deacon , Robin Murphy , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev References: <20260421-mainline-send-v1-sending-v1-0-bcb0857724de@alex-min.fr> <20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExNSBTYWx0ZWRfX41zcUInjSASt nRfnQc0Qcw35R6lX/Im6sN2FrxhJQVjdQguagkYRAVDF5YopHxuhTsTGRKsWbpBaBSbzc86DvXR O1WNyFgwv/3eyoGi25CJNqEryYDO1scCTrezDR80QkchNRlv0jVtSBfLRNVUklzCTP2vd5JaTad wv70iWvrAXgsJRy0DXK/KKqwoXTuLDy8J+XMEXj/nTe7sf+9/ICn03QTWiSOXZquL+a9vX/1LQc bgJ+DJXvDJ5cLYwXlJMDPAJ4d0BuGvlHi0UGK0BPS0z7MWce+7nFFWbS/jN1+5BTgAwk2209Gp9 2nQGmw4gopcOSPhx33nzeWV4MalyZUbaRZhfnmlVihafObaFhjuzQqvb4QggCQGKx/fx6oyX21j yibdDKQ8ZrzZbFQR3NXMtPkJeM5n7Ei074QwMiG5JWkFwMsFHjiwiMs9aMfJ3BG2c5ALHhBHLyD UpDKhUEDObBzi3F94AQ== X-Proofpoint-ORIG-GUID: wxPcCq450T-r6QuTQAKO-_grKxKea2vr X-Proofpoint-GUID: wxPcCq450T-r6QuTQAKO-_grKxKea2vr X-Authority-Analysis: v=2.4 cv=TJt1jVla c=1 sm=1 tr=0 ts=69ea0447 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=7luhnmdphBsOXQ2kz_0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230115 On 4/21/26 11:45 AM, Alexandre MINETTE via B4 Relay wrote: > From: Alexandre MINETTE > > Add a device tree for the Samsung Galaxy S4, codenamed jflte. > > This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support > covers UART, USB peripheral mode with USB networking, the front LED and > the physical buttons. > > Signed-off-by: Alexandre MINETTE > --- [...] > + i2c-muic { > + compatible = "i2c-gpio"; > + sda-gpios = <&tlmm_pinmux 22 GPIO_ACTIVE_HIGH>; > + scl-gpios = <&tlmm_pinmux 23 GPIO_ACTIVE_HIGH>; Is this not GSBI2? [...] > + i2c-led { > + compatible = "i2c-gpio"; > + sda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + scl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; Likewise, GSBI3 [...] > +&riva { > + pinctrl-names = "default"; > + pinctrl-0 = <&riva_wlan_pin_a>, <&riva_bt_pin_a>, <&riva_fm_pin_a>; pinctrl-n pinctrl-names in this order please, file-wide [...] > +&usb1 { > + dr_mode = "otg"; > + extcon = <&muic>, <&usb_id>; > + status = "okay"; Nit: please keep a \n before status looks fairly good otherwise Konrad