From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64304C43387 for ; Mon, 17 Dec 2018 12:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AC6E21473 for ; Mon, 17 Dec 2018 12:29:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="vBTwpv3f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732835AbeLQM3U (ORCPT ); Mon, 17 Dec 2018 07:29:20 -0500 Received: from mail-eopbgr820082.outbound.protection.outlook.com ([40.107.82.82]:21929 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727186AbeLQM3T (ORCPT ); Mon, 17 Dec 2018 07:29:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rpck3gKqPoN6JjETF0KSLxpIqd7B9exAXtx6UxUvi0s=; b=vBTwpv3f+GVbmn6KwQmwRI9eElSgOGaTtZX8ocVbMcbaxlKo6DosQ0JqV5zKuIs6CxBR6BcvKEO8u/RA55u8sIaZwo7JxIzUNpRYKAOFO2LyOXi4TC5rnawAHBg1zROn3JAjGe1Zah3Zn5KQIvRNMwaMHvhpVFHEuBWOCbU1ItQ= Received: from BN6PR02CA0103.namprd02.prod.outlook.com (2603:10b6:405:60::44) by DM6PR02MB4458.namprd02.prod.outlook.com (2603:10b6:5:29::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.19; Mon, 17 Dec 2018 12:29:00 +0000 Received: from SN1NAM02FT022.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::209) by BN6PR02CA0103.outlook.office365.com (2603:10b6:405:60::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1425.18 via Frontend Transport; Mon, 17 Dec 2018 12:29:00 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT022.mail.protection.outlook.com (10.152.72.148) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.1446.11 via Frontend Transport; Mon, 17 Dec 2018 12:28:55 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1gYs11-0006P3-6N; Mon, 17 Dec 2018 04:28:55 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1gYs0w-0007X3-3j; Mon, 17 Dec 2018 04:28:50 -0800 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id wBHCSkZo009050; Mon, 17 Dec 2018 04:28:46 -0800 Received: from [172.30.17.111] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1gYs0s-0007Wc-3T; Mon, 17 Dec 2018 04:28:46 -0800 Subject: Re: [PATCH 2/3] ASoC: xlnx: Add i2s driver To: Mark Brown , Michal Simek CC: Maruthi Srinivas Bayyavarapu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Mark Rutland , Vishal Sagar , , , , References: <1544207558-72508-1-git-send-email-maruthi.srinivas.bayyavarapu@xilinx.com> <1544207558-72508-3-git-send-email-maruthi.srinivas.bayyavarapu@xilinx.com> <20181213153127.GN10669@sirena.org.uk> <19c273d9-c52d-48be-a1e1-88e2b1f14cce@xilinx.com> <20181217122441.GC13868@sirena.org.uk> From: Michal Simek Message-ID: Date: Mon, 17 Dec 2018 13:28:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181217122441.GC13868@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(376002)(346002)(396003)(39860400002)(2980300002)(199004)(189003)(31686004)(8676002)(23746002)(305945005)(8936002)(47776003)(31696002)(9786002)(64126003)(230700001)(65806001)(50466002)(76176011)(65956001)(77096007)(36386004)(93886005)(110136005)(356004)(54906003)(2906002)(316002)(106002)(58126008)(6246003)(336012)(106466001)(426003)(186003)(7416002)(126002)(4326008)(39060400002)(36756003)(11346002)(6666004)(446003)(26005)(81156014)(81166006)(44832011)(478600001)(229853002)(476003)(63266004)(2616005)(65826007)(486006)(5660300001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR02MB4458;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-83.xilinx.com;A:1;MX:1; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT022;1:62f3uPKWqJfZEyAdAJ8SlYJW5E6jRGomxuovDpj1CnKUF8Tr8sT+yF4vq24QYaEat2AOX+G+GAGZmaCqpIxok7BLNbLbH9KZoV75Yf2dNyo9pg/2OcxWhL247wtF+ItO X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c80b080b-6693-49d9-b7e4-08d6641b3897 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:DM6PR02MB4458; X-Microsoft-Exchange-Diagnostics: 1;DM6PR02MB4458;3:67B/+tLvjUao6bCIc2mJ4wMrsBAxExdJ4OB9++dQF7LfZ6raH1siUtcALBo3tB8t1UwpWz8vVNF/154GeeN5qNoetzYewXhnvyJm5JoSY6ALfAYJEDv48dx2PlsFC3jSligZpovrrhIiYor+6DyzRt3k7xK5UVaodkXeXj99dHgrEUyTEqxey0GUA4jYLDXnJXvK2q0hxEov2CUYWhTUGfZUwRz6fgO+DPa8EbTivvB0rXhCwev7QJ9f3hJEPjvv9RrFNFZ4LgOLJwdLcFMhF9sK5X/9yTeEnCUFs3LQK870bTqclZWr8QVIAb7OvZjluKQA5+bR+1nZh/w6Yl48TqJUPpTSgX/OIPhvp9CHN5k=;25:X8ORtACzGZCavYgukXvcIg+67YK/KWAraRuZYRLNsVKjT6W3MHeZyOgZBLs+L387n8uLNhzbath8yssdIfeV66hLUv9Aya+oF5MJ669qk+GecrbqHc1TqKbm4facmNtl7sDq2uz5YrFqWUs4tr9cJpQb3QtuaMjGaBEoM98IcMeKXzXCCdsxhVl0EKuy2wMDANHjyADDz/vG6KEEP9xpdkczqSoALUx3MYuQGzBoplbLTRdBVrJpARG12Y4iwGzI9bQTQDBkdYO2pVP2VgYsxs8g353e8kp2UVFTJ9xzpH6dpydzsjuUgqE5KItZ7CZzRcUJU4wvP32sOip2qS6M5pw7e7VJkZxZ9eiLSZybkk8= X-MS-TrafficTypeDiagnostic: DM6PR02MB4458: X-Microsoft-Exchange-Diagnostics: 1;DM6PR02MB4458;31:wdysgw0Hajom/TjLHZ9mvIKSMi5v2nvABG654jtxTNARaOOLPcbO5AFaCUesvlGAD0KtWcCW6589WrBYxGFw/4x3rcf0qcjb7GkPYKc+2hkMicSrURv12kY+MXKS4Ku3r6kuxaJGK4TvH6usEtAAvN1lRAspg4fCqN/0neOXmU3EJLaNwZTpfv8T6QL6S57oRQuJ8SwXSB3oAFvZ5NQsBB/XVJmdM9CHziEERJn63OQ=;20:7QTFhx8HZv/vTSfsEX+UjEjEXeAoqcjuaYEen8wPcW4UXGnzNtChT3MFn1CL/EZucEz/BKvYltBOF7u+Bhv5+SEX8r35fY9zGIBh3pqf3NtqKFudthJUmxcGoin8fWhcFLC1i6QyGLSlOxGjPbFkjirztD9ZId+UAPnvXWU62cMg5ppK61hBQEZ61XzT1U0pjQm4gcbRN/VxSpZ4wBrmA02Xl7afAUCzWLQYGmx+XNSLJ0214hNlrrZIPRp5bhJUYrTBbBKpOBTnKs2jcUmGlTBJL9GyPfoVp3qxoCDLMPdzVGK2+903p2y6OLEFk4CFJjNWAZmg86QTh3HPjzhPkbwtpWNeBTg6TnO4VVx1+NM/vZwObSVhrOBTJIzAYdxO01PeQmGpJRnkuquvqGxHDKKwzkjNRPXLH+xfQXmamqhmC0xlAjCE4gga2QKl0fkRJkmVysP2622E6WWtesLRHHowGxaHDik4+FhlZjzFzINvh9c3hJR9brmSaJ7zn/iA X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231475)(944501520)(52105112)(10201501046)(93006095)(93004095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:DM6PR02MB4458;BCL:0;PCL:0;RULEID:;SRVR:DM6PR02MB4458; X-Microsoft-Exchange-Diagnostics: 1;DM6PR02MB4458;4:wM4T1LTWe8Hw8wh4F521Vle4s5+816CTy46zgd2SZg14nvBBVPyezTKzZFNu/HPXD35xSrQ1wxUJRESTCFtokZeG7z72e41IxQUmylr/sfI+e9CQlqXSklj9ulAfXu4OsvCtLKSTfYt4A5c5+Dzb+Ww6FW+2wvcj6sKM18t9VbMHlvpKyZkf9yrl2ZWlZ+DngGAmzlTcRppiUinCpLgjFabStCtsI5e/I7XdIIiX3CikJ3Kc/5UhrpmCzPx9xr7pcrjcgH4aEF+F/8GEHi9cTQ== X-Forefront-PRVS: 08897B549D X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM6PR02MB4458;23:MLvoG2M3kOtavnEL94917FCezhbxhDCza98XL?= =?Windows-1252?Q?hMnFtu+dtjYR2Ifn2Rqkdnca73282sXvkXBAZUxfHJVu7HPHtnzvjD+l?= =?Windows-1252?Q?lXxXbrsgwGSJUsIq3cEoaXzsPUnQ6z6vjQCWA2PwM5zuETNxNl2qt742?= =?Windows-1252?Q?3DqHEbrbeRa9eT1qXp4cNaDULZ+/11rzoq5IV+jqlCU3V5LjCgNI3qqz?= =?Windows-1252?Q?S9IRAtjlPwreLvQr7cxxz5TbXnSFjzXCT8e953ipBFWydvqmX9tA/pJQ?= =?Windows-1252?Q?ekmvF4EG8kjNv2xH91nQDzNazr9nEoAwb8ivb3LFJnkXuFDKT1nBV53J?= =?Windows-1252?Q?c0+S5Q2eeVQ7KVwpFlPjy8mXR1eJAPQMi2QsLvu65EW/yMdvUAkB2/H1?= =?Windows-1252?Q?ytWmt0uRJc3h60BSZQ0F+6p1QGma/7I/lNAXcF4V4Sp+Vsf+RpqvUWqp?= =?Windows-1252?Q?z8dTqIb5MLpiNoDoeOhL/oRXzxvb2E1ifX27H10a7ZHBnhQmnZFvOqTn?= =?Windows-1252?Q?yyzH85gfHN4GATc4k+ZE3KDmvfeHtrTqhTWceIafvZDxskcgxEPADPzu?= =?Windows-1252?Q?X78w0qoxGEDlv0c2pypa31DLtZaoo0nbFh0B7cQDqPrS4qgxZNfBD+M/?= =?Windows-1252?Q?gvHGHtqUVwxCPBu1XIMgD/Z4LC4HwVdvNHEJ+1vgQ1UTtbu+FIfeT3rr?= =?Windows-1252?Q?iI+iM2lzNU3hQ3sXQj74ETn/8CAywzzhUlgbllTd613GGsHVwW/IgBSK?= =?Windows-1252?Q?t9y2AmUGeWWDDtkkhhpwZON3XsPDffwkKhOt9ePiPVSeRbo/Ggqd7N1r?= =?Windows-1252?Q?dls58VTJfDyAz7QphjzDq6aMkjbrgR1g45dYDYYoxfYtBQW+k6H5wixi?= =?Windows-1252?Q?l1R7gl5MsI+0N1j6iwA28WueN8eNzGeAEGIG3zMzVcxA0u9kcmYCBREq?= =?Windows-1252?Q?9N/ZPMMJBWOU51SbDVCJAWbr7SRiLw1XDKtx/V7HjtDtzJ1ijCqTWNtG?= =?Windows-1252?Q?SyNBMv8fKmxif/+/Z3FX0Ml3zQ+H4ZsQhZFfqpWRXU5q+BolH65G9Vt+?= =?Windows-1252?Q?uo1V78PCtcO2ohO7hxpnTRH5ncyaH79cmkDU8941auYzgKL4zPYyWozg?= =?Windows-1252?Q?YAx1ArNdXHDnm4HoJuDcXcUSoxZHbpfxqJcGDN4UIMXJFr/G4VQ9J1sW?= =?Windows-1252?Q?ArYP+pyil3CRBw/e1VUDzHRRpvn+dXT0qUd/3++WBV7D2wE1OQqkBcL4?= =?Windows-1252?Q?GdNVG56O1jq7JZFRguArEcRB0NIMGrwlmAbicVI1ynjnPoL8uzP0dX3g?= =?Windows-1252?Q?vF+snX/KdmOsf7nhB3AtqE7Pt/3vtQBoVmmGrbDevPnXJdaxEbPesqXh?= =?Windows-1252?Q?4/XdpNT+m+kNDswO6/Ouu+wC/H4CXJjrg=3D=3D?= X-Microsoft-Antispam-Message-Info: ZEHIp6t0ECW6WWQpK4/YtvcZ6zS3Tr4EZRZh5vuBshKayEQ2af2YY5RqocBS8DSdYjcoSl/WUXeyhw7njXYzDrdpkUVur9FTgk8zao6QBkKTgl8le10DKEKecx2VGrLcvkuIM6wU8VLcwGm4GUHgM4UYTYuo3GGSaZMgU/2o15+QVBOfX58ztsnC7c2hENVZEN19t16P7ceW+F7P/1WvGnSnysDlhtHZS0CwS6tJpjGw2Py2AaPHe+2GHsylCGGwLKcS77yjH0IDlrd6Mj+BBcdviGMYvu+YGykTYac2dcbFbls/sCZKwUNlvaZjB0QK X-Microsoft-Exchange-Diagnostics: 1;DM6PR02MB4458;6:gLla6uc0V/yFQI4KEJhE0rhi+ls+L8nGAVZs1aXkDJU1Ja1smqkd57NVnoPaTGiX3mQry3hdCh55TxNuzsAwrUQsK3UW95rjpnuFWLze2U2LNn5bsTaAhcodMb/Yr4ghGiwrPxJX3JthkYMixIBiWaDYIjvKvQ5CR8mWbpJ/bKlCTlJB0gxHboFFWHtGNuaHkppsMv8esSnWZl02szHMRWYtT6bJvVgW3sXm0d/CFN3Qp3wME+g+B6d5fR6nrFGu7oQXFGbxQoL12Csf1R0htho3lEyBBd0SdhpuS1rMggwrDetAlXypS6dWxDUx3sg3sTyFn717TpZrOW7b+Ir6kxk+IHKjz5fuUz6mSdq4baIt+K3l0IEE1XcEs0rZzb3PiigU2jI/j1gIaFVtO/lGDNWXRr8p9dmFHIlrT98T7jmkg2jVWRM7o4fcR20hT60s0pYbdCw0vJmLMIoDoEL1vQ==;5:/77O69uHPfJ0FHaqRvt3Hkiw7e3Je6kyzBvPvmiZdkksCINH0nOoNihexC6iQcsQEL9UBoC5waA7wE8R79Eeq/06DJsu6t+yvs4Hgl9Pq+MRYVuAz6EeLWBSKcGyDMZTV0O6eDyBcJKuehZ6bnE1DIki9lA4WVbAyIdIqdCDlo0=;7:CJtqDcfBxGTUxMs5Z6OOdqW+E1lTJUef+Tf9tAQXqJkZXB9W/RhXlTeJeSFhc4ubkBnFRQfALk+KFsLM0C1E90e6aqOpb4/CnLpM03cT7eyerm4L3F9GSlIHXsA2I+j7H33mQDVRN/AZlU3CjsSN9g== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2018 12:28:55.9146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c80b080b-6693-49d9-b7e4-08d6641b3897 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4458 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17. 12. 18 13:24, Mark Brown wrote: > On Fri, Dec 14, 2018 at 07:50:43AM +0100, Michal Simek wrote: >> On 13. 12. 18 16:31, Mark Brown wrote: >>> On Sat, Dec 08, 2018 at 12:02:37AM +0530, Maruthi Srinivas Bayyavarapu wrote: > >>>> @@ -0,0 +1,185 @@ >>>> +// SPDX-License-Identifier: GPL-2.0 >>>> +/* >>>> + * Xilinx ASoC I2S audio support >>>> + * > >>> This looks otherwise good so I've applied it but please send a followup >>> patch converting the entire comment block to C++ style so this looks >>> more consistent. > >> Is it the rule for your subsystems? Or did it come from any generic >> agreement how this should be handled in .c files? > > It's mainly me, it's certainly not a consistent policy. > ok. Maruthi: Please send that patch which Mark is asking about. Thanks, Michal