From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 496FBC4332F for ; Thu, 17 Feb 2022 17:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243826AbiBQRgg (ORCPT ); Thu, 17 Feb 2022 12:36:36 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242741AbiBQRgf (ORCPT ); Thu, 17 Feb 2022 12:36:35 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 606B32B3AC3 for ; Thu, 17 Feb 2022 09:36:20 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id h11so2796157ilq.9 for ; Thu, 17 Feb 2022 09:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IDkmkuICMD0GBUFdglrzboVl2xOTROzNihfxF3HUYOI=; b=LUz6HJnAr3QvZg7fZl1dRg6z+fbryWq7p15eSxwfbqvBhNyopS2Dsm7YKI5Y5r5NaN NFaoV8M/WfR96MNLj49SeNp9/Qbyoh9iTM29qW/C8/RgDbEs+gJEw/kjkUOSJIkAxzlz qL5YLStcIK/6wHU46yAbTfFw6bEE0Ffm44UhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IDkmkuICMD0GBUFdglrzboVl2xOTROzNihfxF3HUYOI=; b=R801IgVOBkf7L9cnKXWJU5q3VJ+IHLBqdqJbOw5npKZLXAoUSyWtXJQYY8YgxDnIq2 fckb8J2GxbKXIpC+KH3QDkjS5Ot7upkEx+6dKXx0BZ/aEFuqB+g66+OmywOPIIOIupeN 1wMDFTKu25KtshGIy2FN65Tpu223jKkcsERfk5G16QabX55i8wfm8L6AFEKMiO0PprGN VyYtTzlQCYz54g9tp+XRv0fK/7mISJk8ATNi0KxM4maLwCzNtYjioHtcP9D2fMl52UWj TqdmGguHp1x6YwgHf+kjmMWnLea1XmOKoOrpnsBn02aYXqsRH7Ic2gFQLcycS10fHGiX RnoQ== X-Gm-Message-State: AOAM530PrtEDM3CFOz7rMHWMytbSo3d4NAOt4wCQL4RJ4zNF6IFKIwrS 601Eg1Q9R83BvCvBIp+Oy7Zs5A== X-Google-Smtp-Source: ABdhPJykB0DMj9uLVBhuDfqDOeURZhtb+jbGA7GfSaBsNbhqhdUIkXyg6L0cpXMjTz4lGIh5w5nc4g== X-Received: by 2002:a92:dc44:0:b0:2bf:adaa:7a2a with SMTP id x4-20020a92dc44000000b002bfadaa7a2amr2707205ilq.172.1645119379738; Thu, 17 Feb 2022 09:36:19 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id u26sm2200082ior.52.2022.02.17.09.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Feb 2022 09:36:19 -0800 (PST) Subject: Re: [PATCH 1/2] KVM: s390: selftests: Refactor memop test To: Janis Schoetterl-Glausch , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Thomas Huth , David Hildenbrand , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220211182215.2730017-11-scgl@linux.ibm.com> <20220217145336.1794778-1-scgl@linux.ibm.com> <20220217145336.1794778-2-scgl@linux.ibm.com> From: Shuah Khan Message-ID: Date: Thu, 17 Feb 2022 10:36:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220217145336.1794778-2-scgl@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/17/22 7:53 AM, Janis Schoetterl-Glausch wrote: > Introduce macro for performing MEM_OP ioctls in a concise way. How does this help? What is the value in re-writing existing code and turning it into a macro? > Split test cases into multiple host/guest pairs making them independent. This is a good change. > Make various minor improvements. > All in all this lays the groundwork for future extensions. Also good if these changes make it easier to add test. Would be helpful to know the details of the groundwork. thanks, -- Shuah