From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
dan.j.williams@intel.com, dave.hansen@linux.intel.com,
david@redhat.com, jane.chu@oracle.com, osalvador@suse.de,
tglx@linutronix.de
Subject: Re: [PATCH v2 2/2] x86/mm: Remove unnecessary include in set_memory.h
Date: Fri, 28 Feb 2025 11:56:17 +0100 [thread overview]
Message-ID: <ce29384e-b3fe-4196-a986-bb57a5d693d6@arm.com> (raw)
In-Reply-To: <Z8BirVtqibWY6zaT@gmail.com>
On 27/02/2025 14:03, Ingo Molnar wrote:
> * Ingo Molnar <mingo@kernel.org> wrote:
>
>> So I tried to pick up this patch belatedly, but there's more places
>> that mistakenly learned to rely on the stray <linux/mm.h> inclusion,
>> for example on x86 defconfig-ish kernels:
>>
>>
>> In file included from drivers/gpu/drm/i915/gt/intel_ggtt.c:6:
>> ./arch/x86/include/asm/set_memory.h:40:57: error: unknown type name ‘pgprot_t’
>> 40 | int __set_memory_prot(unsigned long addr, int numpages, pgprot_t prot);
>> | ^~~~~~~~
This patch relies on patch 1 in this series, which removes
__set_memory_prot(). I seem to be able to build x86_64_defconfig without
issue with both patches applies on the latest mainline.
> BTW., I did a few touchups to the changelog (see below) - mind picking
> that up once you submit -v2?
Very happy with the touchups, thanks for having a look! Given my comment
above, I don't believe there is a need to post a v3 - feel free to amend
the commit message when applying the patches.
- Kevin
next prev parent reply other threads:[~2025-02-28 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 8:09 [PATCH v2 0/2] Remove problematic include in <asm/set_memory.h> Kevin Brodsky
2024-12-12 8:09 ` [PATCH v2 1/2] x86/mm: Remove unused __set_memory_prot() Kevin Brodsky
2025-02-28 17:03 ` [tip: x86/headers] " tip-bot2 for Kevin Brodsky
2024-12-12 8:09 ` [PATCH v2 2/2] x86/mm: Remove unnecessary include in set_memory.h Kevin Brodsky
2025-02-27 13:02 ` Ingo Molnar
2025-02-27 13:03 ` Ingo Molnar
2025-02-28 10:56 ` Kevin Brodsky [this message]
2025-02-28 17:14 ` Ingo Molnar
2025-02-28 17:43 ` Kevin Brodsky
2025-02-28 17:03 ` [tip: x86/headers] x86/mm: Reduce header dependencies in <asm/set_memory.h> tip-bot2 for Kevin Brodsky
2024-12-20 10:28 ` [PATCH v2 0/2] Remove problematic include " David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce29384e-b3fe-4196-a986-bb57a5d693d6@arm.com \
--to=kevin.brodsky@arm.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=jane.chu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=osalvador@suse.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®