From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdHFIAf (ORCPT ); Sun, 6 Aug 2017 04:00:35 -0400 Received: from mout.web.de ([212.227.17.11]:55836 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbdHFIAd (ORCPT ); Sun, 6 Aug 2017 04:00:33 -0400 To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ATM-lanai: Delete an error message for a failed memory allocation in lanai_init_one() Message-ID: Date: Sun, 6 Aug 2017 10:00:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2gxtyIyZZeq5gP6Kft1yiZkquWPPHYDwKpHjqkvXSher95GZUtU LsnmvzOl4SCweSbJ+8hi4v89f2SYBqffAsggU3fNI6esVTeoDreckOY4pjrK5fsh5UUmO1E +B15QNGFDbSsEyiSGoV3tNrJoTjSgy6w84Jycm2q7DwOUrCMJpbyRInOMQ6w4t3B7Y4BA4W DLtuTpKPrlGMxcYNDeCog== X-UI-Out-Filterresults: notjunk:1;V01:K0:RdLQtL1Qzo4=:ftH1LvZtE5X/R2N7SXIAkc gtMuep0cbHttIC4mAMYP3Ta/g4MjxDk+LCwa9XqaYGWtstlVh/PWyezdxH9I6e2llU2lcoeGh SG77ZlybAdGl0JLIPGl/4TDBIxDkWrf5PRxtAnsAdD4JfadSfCzr6v5RxnkCY3Y9KwgmH0n37 S8NL9s6dneMDZXfBsCuGWSgt509OPwRldKq5P4Lxcqn0QlM19Fd1ZE4ZBq1dDJxtBSjWVanqe SpfKUBiG2Y+JQqDHeamw5Q+S4eB8Z5zGQLIlNiNnGbhWdU9CXQCCboIz3DY+YFJ7Xqy3B+Nmz hzB0+h0pMxAJbYiqOU79x2u3+xvi7jaZG5QwcVUIjfTJUJXxLEoeI2wzMGT5fZLbnosoROnCV zKTmFQjK55ugydji4bSnNxfXLpyu9Ui7pfdbSVhwfed06yd//8LxMw1XvIhDpmDpdppjobSXh 0ygjTx7dliC3qCFgChQz8qeUJLH+2ACoeOIgWum6eSeTlkR8fiV3Kt4C85IZ+cvp6rD8Eh7Dd FVSNSHcFiAmaUrkGZGaLPFssZfc0u4kRLOFEdAjEfERb+hSt4juU2L/dZRn212OcmmMkwmvqp qfHHdBZv16TdLv69vpFGS/XyCBC6/byuOkwiQuzZUqGFS0LrCgrwFPWc61T8kgKAJ1BPkk4Wb l+BOSnbG51jeU0nD7VIqNbVfnSdTDBFHaLqybW4PJxwvvqIVjuKKSXiVLfmbQP3qENPVioFSd NEQc0LhYVwsom6N+qBD7xRajMMlX5aU8t+xDlkViXL7zFL+mNvNRCqj9TUKYFMzzgWZAV/zWd ypiHDncEzw7B9Sn8EXxAihgZVGG0GHmy2e6nO/4Eh067CkJF/g= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 6 Aug 2017 09:42:52 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/atm/lanai.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c index 2351dad78ff5..f4cb6c5870bf 100644 --- a/drivers/atm/lanai.c +++ b/drivers/atm/lanai.c @@ -2562,11 +2562,8 @@ static int lanai_init_one(struct pci_dev *pci, int result; lanai = kmalloc(sizeof(*lanai), GFP_KERNEL); - if (lanai == NULL) { - printk(KERN_ERR DEV_LABEL - ": couldn't allocate dev_data structure!\n"); + if (!lanai) return -ENOMEM; - } atmdev = atm_dev_register(DEV_LABEL, &pci->dev, &ops, -1, NULL); if (atmdev == NULL) { -- 2.13.4