From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB69C4332F for ; Thu, 14 Dec 2023 13:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573182AbjLNNAw convert rfc822-to-8bit (ORCPT ); Thu, 14 Dec 2023 08:00:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573145AbjLNNAu (ORCPT ); Thu, 14 Dec 2023 08:00:50 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A31E116; Thu, 14 Dec 2023 05:00:56 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3BED0T3K0846654, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3BED0T3K0846654 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 21:00:29 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 14 Dec 2023 21:00:29 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 14 Dec 2023 21:00:29 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Thu, 14 Dec 2023 21:00:29 +0800 From: JustinLai0215 To: Jakub Kicinski CC: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "andrew@lunn.ch" , Ping-Ke Shih , Larry Chiu Subject: RE: [PATCH net-next v14 06/13] rtase: Implement .ndo_start_xmit function Thread-Topic: [PATCH net-next v14 06/13] rtase: Implement .ndo_start_xmit function Thread-Index: AQHaKbubsEorOK9BY0aC7C+4Ofl+iLClijsAgAM7r5A= Date: Thu, 14 Dec 2023 13:00:29 +0000 Message-ID: References: <20231208094733.1671296-1-justinlai0215@realtek.com> <20231208094733.1671296-7-justinlai0215@realtek.com> <20231212113212.1cfb9e19@kernel.org> In-Reply-To: <20231212113212.1cfb9e19@kernel.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXMBS03.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Fri, 8 Dec 2023 17:47:26 +0800 Justin Lai wrote: > > +static int tx_handler(struct rtase_ring *ring, int budget) > > I don't see how this is called, the way you split the submission makes it a bit > hard to review, oh well. Anyway - if you pass the NAPI budget here - that's not > right, it may be 0, and you'd loop forever. > For Tx - you should try to reap some fixed number of packets, say 128, the > budget is for Rx, not for Tx. Even if the budget is 0, this function will not loop forever, it will just run all tx_left. Or what changes would you like us to make? > > > + const struct rtase_private *tp = ring->ivec->tp; > > + struct net_device *dev = tp->dev; > > + int workdone = 0; > > + u32 dirty_tx; > > + u32 tx_left; > > + > > + dirty_tx = ring->dirty_idx; > > + tx_left = READ_ONCE(ring->cur_idx) - dirty_tx; > > + > > + while (tx_left > 0) { > > + u32 entry = dirty_tx % NUM_DESC; > > + struct tx_desc *desc = ring->desc + > > + sizeof(struct tx_desc) * entry; > > + u32 len = ring->mis.len[entry]; > > + u32 status; > > + > > + status = le32_to_cpu(desc->opts1); > > + > > + if (status & DESC_OWN) > > + break; > > + > > + rtase_unmap_tx_skb(tp->pdev, len, desc); > > + ring->mis.len[entry] = 0; > > + if (ring->skbuff[entry]) { > > + dev_consume_skb_any(ring->skbuff[entry]); > > napi_consume_skb, assuming you call this from NAPI Ok, I will modify it. > > > + ring->skbuff[entry] = NULL; > > + } > > + > > + dev->stats.tx_bytes += len; > > + dev->stats.tx_packets++; > > + dirty_tx++; > > + tx_left--; > > + workdone++; > > + > > + if (workdone == budget) > > + break; > > + } > > + > > + if (ring->dirty_idx != dirty_tx) { > > + WRITE_ONCE(ring->dirty_idx, dirty_tx); > > + > > + if (__netif_subqueue_stopped(dev, ring->index) && > > + rtase_tx_avail(ring)) > > + netif_start_subqueue(dev, ring->index); > > Please use the start / stop macros from include/net/netdev_queues.h I'm > pretty sure the current code is racy. > Ok, I will use the macros from include/net/netdev_queues.h.