From: Thomas Richard <thomas.richard@bootlin.com>
To: Peter Rosin <peda@axentia.se>,
Jonas Jelonek <jelonek.jonas@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] gpio: add gpio-line-mux driver
Date: Tue, 28 Oct 2025 11:22:28 +0100 [thread overview]
Message-ID: <ce3f0f1a-9cb3-4721-9774-0b73f461a6e9@bootlin.com> (raw)
In-Reply-To: <db36ee25-8a1e-f95c-4ac9-867379a1a5e3@axentia.se>
Hi Peter,
On 10/28/25 11:09 AM, Peter Rosin wrote:
> Hi!
>
> 2025-10-28 at 10:45, Thomas Richard wrote:
>> On 10/27/25 12:17 AM, Jonas Jelonek wrote:
>>> + ret = mux_control_select(glm->mux, glm->gpio_mux_states[offset]);
>>> + if (ret < 0)
>>> + return ret;
>>> +
>>> + ret = gpiod_get_raw_value_cansleep(glm->shared_gpio);
>>
>> Why ignoring ACTIVE_LOW status ?
>> And cansleep depends on your shared_gpio line, maybe it is not the case.
>>
>>> + mux_control_deselect(glm->mux);
>
> *snip*
>
>>> + glm->gc.can_sleep = true;
>>
>> depends on your shared_gpio line.
>
> Does it? In this case, the gpio will always need to be able to
> sleep, since mux_control_select() may sleep. Or, what am I
> missing?
Oh yes you're right, I forgot the mux part.
Best Regards,
Thomas
next prev parent reply other threads:[~2025-10-28 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 23:17 [PATCH v2 0/2] add gpio-line-mux Jonas Jelonek
2025-10-26 23:17 ` [PATCH v2 1/2] dt-bindings: gpio: add gpio-line-mux controller Jonas Jelonek
2025-10-27 11:39 ` Rob Herring (Arm)
2025-10-27 11:47 ` Jonas Jelonek
2025-10-27 13:32 ` Rob Herring
2025-10-26 23:17 ` [PATCH v2 2/2] gpio: add gpio-line-mux driver Jonas Jelonek
2025-10-27 7:51 ` Peter Rosin
2025-10-27 8:26 ` Jonas Jelonek
2025-10-28 9:45 ` Thomas Richard
2025-10-28 10:09 ` Peter Rosin
2025-10-28 10:22 ` Thomas Richard [this message]
2025-11-04 14:57 ` Jonas Jelonek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce3f0f1a-9cb3-4721-9774-0b73f461a6e9@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jelonek.jonas@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®