From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792582352; b=yegysVN/RmCSs12PmtUifCyqEhwFCEsF7l+WzDlDCfahn4Rg+/v0gCUDeakAdwtUshxX cRFFQc9OdpWFrXj917hj+ZUcpJhLip3vXtABMSLJmFjJv7GRUx8MubxdHAExWLStNqv1m fTiv7rR8OSgtcjuheLreqD5xVJ4gS7NURGfP2nCDKvtxQq0QQm67nl+dWIH0We3wbyMBZ ZeSF1xLkqlUCvR4Hf0Cf50U5z6V7fzU1ORH1iiAakG7nWqfDf/18vTcBupECcL9DV2Ocr ap5CGOeFvM9D/6Ov2P7Tr5owbFBLUUwAeUdwIdyZgJaH217tkTmKfY5jf6EnyJ3mzRQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792582352; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=4bn9+rLi7mMU4unxZrBwSU21TRh2XBO4KfFG2d5PF1A=; b=YIp48ph0d5MX3zyfiGy2iEpj0E2k82YYNmu6jYdYkz/o9oDT6IfqwaaCzaiP90dh1E5B ayBBedElxzO+lY8TQjUoV6psgQCrcXdhbN1K1VvN3JrYOTzTsbc5uVgPhKudmwUsmRk/7 79CvulnWo4Q+rA73pJwCv6EL1z0AR7hVxz42D9Acsag9QYb4miVznYeiJ8DPkpvz82Ovq 7qx1VOxkXRipJKahG7iMGHajnpTQBpubPnMhNkFT3WGwE3Xvg0sQjiKMJJkoNSsX5TaMQ 1KnZ9hALTohbe8JYoLnPjJweV05awMYM6oBmR6u8MJCiRb+waXw3tnuh4e4XCEpBc1w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=l8RcDq9l; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=BX8vv8eG; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B211D606A320 for ; Wed, 21 Oct 2026 11:32:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B211D606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=l8RcDq9l; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=BX8vv8eG Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69LB8ml5983571 for ; Wed, 21 Oct 2026 11:32:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4bn9+rLi7mMU4unxZrBwSU21TRh2XBO4KfFG2d5PF1A=; b=l8RcDq9l3hlmBKdH rHQYwc1NxJzwU37rKeIVvtCVpG8tsm7/8m+fWL+7YJUxZ6Vz3+cd8wWCQAS9o3c5 UdJdmH9FKwP5kfwIwPl+6MWhFnTlVJPaPtLBL7lNfsIAWyL75d8BjyW6+oSjkyUJ ts9zKlfWRcQohLZIuyF4Kv2BswJmjxVnnHcFvKZONBDwYAAPXPzEQlklVjDT1vn6 Pb+hBCG0A9MkIXgbz/Mn7vUDpELVFnNAi4axkd37MCHC/jFgEMY8ILSzysAg/KqK Fd+dyBGog6MJCbZC6DMF7dy2OC4ssqVHtW3J9pskxoTBWqBA/VRpeZn2rAqlwH9F yNqkLA== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hedajknrq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 21 Oct 2026 11:32:20 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7c0e2566d30so12330137.3 for ; Wed, 21 Oct 2026 04:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792582340; x=1793187140; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4bn9+rLi7mMU4unxZrBwSU21TRh2XBO4KfFG2d5PF1A=; b=BX8vv8eG8yWLU8t59zgLyYucAfauxQu/MVcVqHl2vpjylDXahr3wVfRZ06iW+ZRxJ3 6CWxW+zygFXhtz6Mo0HWMDW+qYuhan67+2XfnOIsCx/eUxFo18/ZCv+mTDIQ0lL78nCf ++Gp8KseVbLeJnMZiTP7oxohYQkVXc5YCsp2OoqoAQSarSBiwktZdIoH/MH5YUGiitZX 8/W+EWcAT/xerh2c5R29x+CvH/LUYiyJ5lNIPfZuo3L3Ekkobw48/y5UYm4d+tcnW06k vUqZiN9eCLUnPXAJyNP7twozyjkXKQr4Bm8pDd9pRWFxA4FXR7vOku5T6bbHptlJ3J/k Y1yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792582340; x=1793187140; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4bn9+rLi7mMU4unxZrBwSU21TRh2XBO4KfFG2d5PF1A=; b=1OrFanoNVA4mJ14lng7m0ZqIABuqmIoa1dqTpNyJDbot99I23AbeiunEcNzc5kTCN/ y2F5yEJAPaF0RkPvEeRbPWq+zvrwiDM/vEwxPo6mwL+m1bhcSwOdSYgGrniugKP61TZQ zE5JNWY14TbXQ7l0XIMDCei4MeVvz01/fT8UiPyZxDgGt6zwyUtLD4eB5Ee90CHxcgcG upoyFSSSQFX9Z1IqUZkfTmTcD3CkygasiTMSKPmA+uQDoMMFJp2HgLRllYn6pjMId+DD ERPstAmSH/xLkjhUYEftMPAELYw1OERP4JrVK5QnPW2XMFRMJopJ+gyQmtrgOEVsVJ9y 189Q== X-Forwarded-Encrypted: i=1; AKwUvBwVRmy6/ditwoq3L1c1j4NobO087Zzx134LhFORtHbAeRRGg3NE+fYLcGfu3EtyhhxDJwqzw5cAwd66MqI=@vger.kernel.org X-Gm-Message-State: AFq9FYKNn/XOqwxJ8NJsN7XKKgHI8o+UKdE5YAhIOQBeDHXkN6IFOt/L 3zv4m7JosATVDQZZydYYjWWdoLwnexzJlqSQ0Z36hTIJ/wXgEIe8hVDnZFFxHHXsrw7zWTmiXcn C9lMA8F82yjOiwUpqh3uD5c3gHDDXOc/g7EfllNb1CZfPaZC8fc4sQ+aOmmUpCE7nOcI= X-Gm-Gg: AYBFou2SVrR4ZGuUr94DdGrD/4oGoLjrpRh3Fwj5zku+ISNUkSiqGy0G/kWlA1PU7e7 2KvIdQ6q7paRA465hgbHLDS5WgnGBDsevLzpJKqeM0K6i3wkVp3Itc69HnlXO0KD1JNUi0EsiEy l3l9m1EaeHdH9hfUHGKFlzk8IT9beSFAUscIiK4xUhifnDWRlxPEqziPn2DmK5UL1h1b0121+8j XLvcmXfRpP7bpKZ69rcA8mzYq1T9mIb9D8g038S6VE/xqnGNbZ0AZbpplqzuoTdSJF8SWHCtNQr 94LB1Q9Gt8G/icANlnEc85Gnu+6r8RF/mpqqSVlSb43pewFrySpRD/j/0hGPKyOzn8wttWyj9+y BDEU+x5A6AXHyDHog0bLFkA== X-Received: by 2002:a05:6102:1626:b0:7cb:fef7:3763 with SMTP id ada2fe7eead31-7cc92623e94mr467079137.3.1792582339604; Wed, 21 Oct 2026 04:32:19 -0700 (PDT) X-Received: by 2002:a05:6102:1626:b0:7cb:fef7:3763 with SMTP id ada2fe7eead31-7cc92623e94mr467038137.3.1792582339070; Wed, 21 Oct 2026 04:32:19 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c4678fafd25sm67887866b.47.2026.10.21.04.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2026 04:32:18 -0700 (PDT) Message-ID: Date: Wed, 21 Oct 2026 13:32:13 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] Migrate PAS clients to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset() To: Mukesh Ojha , Sumit Garg , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier Cc: Abel Vesa , Sean Paul , Akhil P Oommen , Abhinav Kumar , Jessica Zhang , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org References: <20260925155737.4161358-1-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260925155737.4161358-1-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIxMDA0NSBTYWx0ZWRfX600Y0c5eyNeE Om2OQ+LuV54EklFQ7i64Tb8VyMojfOh1bCGD7bYvjxQZRMCUs6OAvYV67F8yBE7JaHx/n8NhBzP hpfEriMOJYg/lXFudHZCpKoDcjaV7WCWx9xjnsxOqHRPxb4psjr15fq59mM23Ag/ZwAhpwXrevn 3c8tAfCUfXwJBaLWPxRQRwWcmfyHQaFVje1ej03XLSVPIkITM/wJE7OwT0tf01xeKTLBpjb6spY rPPgCPpL+iNsyPPILM+QdT8yGwo+vH9xsQulj/YJYikUOmRtupUefP2eUdpKaj3ojJzOq8uKIdP LqGJBxeJ0/F9zp7L/mfOpsaL2W8Qi6bT04T3Ksq9acxSlmCBR/NHDEcjKB4hDjQb0/VIQZMzwCK 1rqsf5m33dcGQ34d0AqvF/JkSenf9vahraCIdWvQtrYQZzEDiI6XIF1FVhqnAYdaStYpOaLxJXQ IGAKXzSCdaGdjD9YWbA== X-Proofpoint-GUID: Sn9sYbgZoFqXysaX-xdVAa8WG3Jc4jb4 X-Proofpoint-ORIG-GUID: Sn9sYbgZoFqXysaX-xdVAa8WG3Jc4jb4 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIxMDA0NSBTYWx0ZWRfX7t+d9iyHZghu bghjMQCjvEFcucXrV8crgkpOLXxdggYavhYADaKIqaf6VBtctG5Fyf0ylQC9y2Jd8W+vuHBZfAl sggSCSQfOrcOcFbjN8GUGM2TBeFJ+Ds= X-Authority-Analysis: v=2.4 cv=HrTjiETS c=1 sm=1 tr=0 ts=6ad8a2c4 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=25W5T12MUkcB5wj6RmwA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-21_03,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610210045 On 9/25/26 5:57 PM, Mukesh Ojha wrote: > In preparation to remove qcom_mdt_load() and qcom_pas_auth_and_reset() > public function, migrate every user to the new PAS context-aware API > qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset(). > > This series migrates every remaining caller of the deprecated APIs > (qcom_wcnss, adreno zap shader, iris, venus, IPA, ath12k) and then > removes qcom_mdt_load() and qcom_pas_auth_and_reset() entirely. > > This series is based on top of although no dependency as such. > firmware: qcom: pas: Make MDT buffer retention explicit LLM has the following comments: 1. Metadata buffer (ctx->ptr) is leaked, and overwritten on reload, because qcom_pas_metadata_release() is never called (patches 1-6) 2. devm_qcom_pas_context_alloc() is called from repeatable runtime paths, so contexts accumulate until unbind (patches 2, 3, 4, 6) 3. use_tzmem is never set, so the shmbridge prepare step never runs on SCM and the commit messages are inaccurate; TEE gets a real mem_phys/mem_size change 4. Not bisectable: patch 4 relies on the NULL mem_region handling that only arrives in patch 7 5. Patches 3 and 4 don't apply to this tree; iris iris_detect_firmware() still needs mem_virt after the load; the base of the series is not stated 6. Patch 7: NULL mem_region now means "map internally", which weakens the -EINVAL sanity check 7. Patch 6: redundant second ioremap_wc() on top of ath12k's persistent memremap() 8. Patch 6: ctx is set under one scm_auth_enabled check and used under another, which is fragile 9. Patch 2: the context now carries the full region size instead of the MDT size, which matters if use_tzmem gets enabled 10. Patch 3: stale qcom_mdt_load() comments remain in iris_firmware.c 11. Patch 8: no issues found Konrad