mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Li,Rongqing" <lirongqing@baidu.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: baolu.lu@linux.intel.com
Subject: Re: 答复: [PATCH] iommu/intel: Prevent variable pollution in cache_tag_flush_range()
Date: Sat, 20 Jun 2026 10:59:18 +0800	[thread overview]
Message-ID: <ce40dd72-a56c-4827-aaee-02a5d21e9766@linux.intel.com> (raw)
In-Reply-To: <2ffd9844662a46d6acb975d14d14947b@baidu.com>

On 6/17/2026 3:51 PM, Li,Rongqing wrote:
>> From: Li RongQing<lirongqing@baidu.com>
>>
>> The loop in cache_tag_flush_range() modifies local 'addr' and 'mask'
>> variables that persist across iterations. When CACHE_TAG_NESTING_DEVTLB
>> overrides them for a full flush and falls through, subsequent tags incorrectly
>> receive the modified values instead of the original range.
>>
>> Fix by creating per-iteration local copies initialized from the original parameters,
>> ensuring each tag processes the intended flush range.
>>
>> Signed-off-by: Li RongQing<lirongqing@baidu.com>
> Ping

Thanks for the patch. It's now in my queue for the next merge window. I
will let you know when I include it in my pull request for Joerg.

Thanks,
baolu

      reply	other threads:[~2026-06-20  2:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05  0:39 lirongqing
2026-06-17  7:51 ` 答复: " Li,Rongqing
2026-06-20  2:59   ` Baolu Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce40dd72-a56c-4827-aaee-02a5d21e9766@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox