From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f99.google.com (mail-yx1-f99.google.com [74.125.224.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0CEB403B1E for ; Tue, 21 Jul 2026 20:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665709; cv=none; b=X73ekoDlv2al6fUjwayrTdO0LorI0gUsbaQTv9ZWexFmIOn5Q8FTHYrJovnJVcaEyj7WJNi+zMwLlI0Y4FhydOy64l0+paPxYYt7v5ejQushar1FKw29dQA4rew1MOx1oL8iUhYnrD424FcmAu1u1NwLHXo833bRDwbPvervhrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665709; c=relaxed/simple; bh=/M4vpmm1AUqUyc1zunkzG7rzRTTn+tgImDuc3QT14w8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H6Iw9k9ciGo9MU4Ogu6gtiH8FwnE5PiIq3uoKcVmAHevHGDBE+NHwZLzBHe31IF2sXU1lzaDMqIJRqUjqmlKoBuhwAsPok8h5ZtkJwNgq0ScMOMV1MfCc+KZLas6tGLWtSEFkUE1gD7kXZPE3ba/5Ct62wCERVefAU/KC3mPKDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=gEk9Rlge; arc=none smtp.client-ip=74.125.224.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="gEk9Rlge" Received: by mail-yx1-f99.google.com with SMTP id 956f58d0204a3-6680ae2031fso7273431d50.3 for ; Tue, 21 Jul 2026 13:28:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784665706; x=1785270506; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=fTR3Osz1w4q8vT9QmaSiYsaOMtZKVCVI47aty9EAQ44=; b=ExEDQWjw31Mmm26UODCKgb0Hd61KYuMrUwPPd5PCNt9mbSDa1Hz5Hd2LMIBkzea+7K iME4Yi52CiGf6/LC3xO420f5jgL7bLbJrWn/bmQoLww9LSI6uA7o5rvKPpxqVQU/mHVB rlV+0spjtUOt5agUPYICtHMrvcf0JUrERXpwfMi+kvuVLjRRs196jNpJz/0liEgeo8wg ceSyb7BfYjykmaTt/tdZQXpBB5k5XuyE5KVnmuwzmebdaeJxRDZ/452saHA3CEp5WeQ3 W/QHLyOv9PTdAD2EJWMMnLi5w/5qJ4BY9fq1L60vpycmAoCmkgmLqzeAA1yiqIwj/rSz 8CXQ== X-Forwarded-Encrypted: i=1; AHgh+Roz7M67DITtzsh0qCyBUjY2j6OqiYnu/atXrK2I6H76dXZpVEbHygyHdAslUI1grE6jkNBoAaD8g+P6Dkw=@vger.kernel.org X-Gm-Message-State: AOJu0YycGGsT7Nw1eIG62Xwt/UK1YoYO/EOkA/5yXoTiBulkKgbsolkt V0/fQfmiPOV+ZKn83yjSoloWyyPhsFEGTpyAsWKK4UVdUYemxMcmOF6VxFFbwz2KR5Yx2zUtVMM QdjW+YTAdaCs2Lk5h1HDBlmQBbTa5cAdXe7eXwO/YtkmOM1DhS0bB+7uFWz4K5Q4KqOuVUuiIGd heShJRhf/Rz3+TSkxUS4SmMjCwpV03T30fQdJkyknlXJH42yMzZGv9X+fJjHF8Cnn9KPvvsu0KO 6idzUbb0Q0RfFB+WVmFJbXU X-Gm-Gg: AR+sD12l/rY7IJIi4axIqFs9EIlCbz3Fe7bzQPV5vrAs6NCBk/mwm8ExdKuwZ1Qtx3L i/KqRv48RdnKBgNVKOjzTLkWxAAEBt70EmySNedCrXhAcmlLUAt9mV8pOmWaK7LOXkTAzaJqkz6 k9RA9p8L46uo7t5WRRCJ+3vwA9OMGcyHDltsCr9MPt4jjPL7uVyC43bYInOUqEugE6fPTJeOAP3 JtdqCt2Owk9/CuljtCsXPL5E5hm0+bd9/Jc0iMkB2STay+yIcP7L1zIychSLuogTIPnnvIirhKP jLOfWczxbwwZM2AOXKSUJNZWhF67Xk3Plcv2qy2qcBGYiyMVds3BSRg5zU4HM+NWm2CoipCFXFN EFXL9FcjPg4sOB36DuAGbs9/Gd2gGYoEqAGtfHsM7FCVIqfU7cDjmEX1fESZzIIUsokO9CO/UMj IItkxnGi4Ax35nSWNDpv9FBx4ncf8kRFS22Eivpl/6 X-Received: by 2002:a05:690e:4381:b0:668:9148:17ea with SMTP id 956f58d0204a3-668914819ccmr51215d50.59.1784665706514; Tue, 21 Jul 2026 13:28:26 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-29.dlp.protect.broadcom.com. [144.49.247.29]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-668905275e8sm19240d50.2.2026.07.21.13.28.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jul 2026 13:28:26 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb6dd278512so2457423a12.3 for ; Tue, 21 Jul 2026 13:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784665705; x=1785270505; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fTR3Osz1w4q8vT9QmaSiYsaOMtZKVCVI47aty9EAQ44=; b=gEk9Rlge+y0R8Oqa87akZPqCa2kvHhKoHsh7kX+JjAVAFjEenQLWGe1+oRPz839AeP mLHmMZbmhFunpeJirL0PZcqQk50REnQrFuCgFUWpuagccLFu4eCVZZDMKLzN4hf4pNR9 zYbyXcpRemk7GhjxSXXy3l1zjCe+VUI9wiP7I= X-Forwarded-Encrypted: i=1; AHgh+RqxoBv1HKp91saJBJLgXm0mwSxyjzjpVt/PnQPRSD9EfO3RCk7jIh6jeDVPsfBXsDPMl3jYHTblud25jQk=@vger.kernel.org X-Received: by 2002:a05:6a21:6f06:b0:3bf:6c08:2b27 with SMTP id adf61e73a8af0-3c3ada195f6mr22321529637.47.1784665705420; Tue, 21 Jul 2026 13:28:25 -0700 (PDT) X-Received: by 2002:a05:6a21:6f06:b0:3bf:6c08:2b27 with SMTP id adf61e73a8af0-3c3ada195f6mr22321502637.47.1784665704930; Tue, 21 Jul 2026 13:28:24 -0700 (PDT) Received: from [10.211.247.235] ([192.19.50.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e1bc886sm1551194eec.26.2026.07.21.13.28.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 13:28:24 -0700 (PDT) Message-ID: Date: Tue, 21 Jul 2026 13:33:07 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/vmwgfx: uninstall the IRQ before freeing the command buffer manager on unload To: Fan Wu <12321260@zju.edu.cn> Cc: Zack Rusin , bcm-kernel-feedback-list@broadcom.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260714094511.2960308-1-fanwu01@zju.edu.cn> <2df4713f-bf61-40de-a43f-5079e3b5d5fa@broadcom.com> <1F85D73C-FE3E-4838-9A54-0014AAE3913B@zju.edu.cn> From: Maaz Mombasawala Content-Language: en-US In-Reply-To: <1F85D73C-FE3E-4838-9A54-0014AAE3913B@zju.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 7/16/26 7:24 PM, Fan Wu wrote: > Hi Maaz, > > Thanks for the review. I'll drop this reordering — keeping the IRQ alive > for command-buffer processing during teardown is the right call. > > One question before I investigate further: is there an existing teardown > invariant that guarantees an already-woken, but not yet run, CMDBUF or > FENCE threaded handler (vmw_thread_fn) cannot remain pending once cman or > fman teardown begins? If there is, I may well be chasing a non-issue, and > I'd rather not propose an alternative that fights an invariant I'm missing. > > I'll re-check whether such a handler can outlive the current destroy > sequence before suggesting anything further. > > Best, > Fan Wu > You can drop this, the current teardown sequence processes things in the correct order workqueue -> thread_fn -> irq. -- Maaz Mombasawala