From: Markus Elfring <Markus.Elfring@web.de>
To: Jia-Ju Bai <baijiaju1990@gmail.com>, linux-btrfs@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH 1/4] fs: btrfs: fix a data race in btrfs_block_group_done()
Date: Sat, 9 May 2020 10:00:13 +0200 [thread overview]
Message-ID: <ce41cc75-ee89-61fe-ef7d-6d527ea56e5a@web.de> (raw)
> To fix this race, the spinlock cache->lock is used to protect the
> access to cache->cached in btrfs_block_group_done().
How do you think about to replace this wording by a variant like the following?
Thus use the spin lock “cache->lock” to protect the access to
the data structure member “cached” in the implementation of
the function “btrfs_block_group_done”.
Would you like to add the tag “Fixes” to the change description?
Regards,
Markus
next reply other threads:[~2020-05-09 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 8:00 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-09 8:32 Markus Elfring
2020-05-09 5:20 Jia-Ju Bai
2020-05-09 10:53 ` Nikolay Borisov
2020-05-09 11:20 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce41cc75-ee89-61fe-ef7d-6d527ea56e5a@web.de \
--to=markus.elfring@web.de \
--cc=baijiaju1990@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®