From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1201637418D for ; Wed, 28 Jan 2026 20:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769632291; cv=none; b=dMkLNhlgljYAuDmMDwIaZcqiM29o1wYheX4b3XA6gGRJj2g2G7r7OJ475hIRPpTDRen+jbv+4xkZoOwqDsZ2ek0BhocxFEKphT9mlhqnCYlihhLl0rCEkTs5R5c3Pfil8c2ZrQuSmaZnvjUSSLkxclFpWtMDAllcISKCwVIrCHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769632291; c=relaxed/simple; bh=2qvxf/62yttfNIZNAODh63qlXVSL99Ksrx5/ufwbejY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=spWucQeEZPdp7UK+KxSI6ZoQOBGAbRpIHGgcb9Gr0IgpplNp611/Jp+D3hgWRqtLoCArVjQsProuiI/E0Tngj2EQ2FJAwJCkr5uDVf2+7fpbQNJoxeEdaN1cpgCKuvxTsstz3T+alKPu9rcxbLvcL54eo2wUDb3Y5DaE7YevUUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XUXXe7xE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fwcBGGuw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XUXXe7xE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fwcBGGuw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769632288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=6AqTWTOgRm78zpGWundx5DPK3QN0XJ8tGQTS1p8e64k=; b=XUXXe7xETErab3wRuyukJ0+lVBhbKkaCcNv8QLKZwc4IIIOHcz3YCrmR6f3vNH/wlZJpjk RnC4h+hm/NmAXYcWToR0nweZcgFZTxuS7xUNA6G2dCk/ERzre7e1N9gkt+KnsEx7+IwE5O OR9QHTRzknUlppVd6rQJVsvP5dNvT5I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-pNMD1VvtPYa02Khdqb-nOg-1; Wed, 28 Jan 2026 15:31:26 -0500 X-MC-Unique: pNMD1VvtPYa02Khdqb-nOg-1 X-Mimecast-MFC-AGG-ID: pNMD1VvtPYa02Khdqb-nOg_1769632285 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4806fce5ab1so880485e9.2 for ; Wed, 28 Jan 2026 12:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769632285; x=1770237085; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6AqTWTOgRm78zpGWundx5DPK3QN0XJ8tGQTS1p8e64k=; b=fwcBGGuw7IqQDPevelrNI5mPPr97koUxkOdPBeevIRXEdn2WQmQxRqzM4vbWV5CQ1K GzG9MFQtT4t1UxM8me4DW4lGDGZMEMK2FdX8SYol2akxmRNKL/MKMwIty3VtcOZAXl9Y wWS67ozLZW0GAsRqnPn39uwB0neig513SYS7rQ4feyTLBzJhhqABshCSXW7vNqJZmDFf A4TdMWerNpSOIlJWmzAwR31lzurm2R3U59p0qiXMV54wKq1LH3nxg60LZ94v/n0WM/10 YOFMpQJ7sMCG/fIm2pvP57/YDw7JqNTudoYipg0ZAcyARnfbopdd6agIeA4ATotjkCEM Kigg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769632285; x=1770237085; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6AqTWTOgRm78zpGWundx5DPK3QN0XJ8tGQTS1p8e64k=; b=Q3G62JY7s2xllccsWxsgygJILazJa29XlsQTRlRUMovGfgR3Ygw8JvJlbCkhy24pGy 8d1piGeOEYd13FSmU6H5tfFzfkVu2hHOocZoZ0GhlIRcWl/0qTiOzH5abJmvYWM3RbZ2 E7W2p9CMl/L/52xJaIZLyirJx1jhFAw6+ErKV2leLDWy4JVjelq3/4HV+NDbxJw4RP3Z 84zgrmaZfhMS9il7j4Dfr6OGKM75neI/3mzp+LvAti8ElkJ80ay70XDvpj7l5ItBIrbt koZ0ddC6//av/pijP8QaBu0DTQz7j9IDJZ7XgkHGD6ISHjRFyHnA2drjDb+yrBKF8E7Q CUrg== X-Gm-Message-State: AOJu0Yy17NQml7IU53Z+pzDWLkOUZczp3Eff/LdFYPmbDnG+olt5ltRc fBbgP9GVxT3+YH+aZ3ZIxeVTXJVCQsEJnkB97D5l3wl8ZB8eTjNYHx2WFmh+hus1JZxywuh+euO Pt2BwZhzRyRJiAdhua+dVFTpdBAbKCk68yrHYnPxqBLyFw462J0KwlL3NS95gDz9eqQ== X-Gm-Gg: AZuq6aJVH5YEAcfwI/EX22J7Hy8vyZuG3qg6A+D0MB37kwR8PLJuDkRUqDFX2jeHSrx gquGer7NO1yYSfl7GT/2lqyh+s210i87UG5Ii5zOOUCRXk311epNl66DniZLTBSr9CTzkOTni/6 JfWnYVVjCir/fSxMJe34pr7WKVtwY0Uk2d80/acKda89/VDqmRoHFkWu05T+j//IDgjpHY4GClq wevOOg2ub33VXil4oM/1J01Uq/uYK+vkwA3uCMY4JFZaZlQ5etCrBc79L7dJg8Xl7htd2YX8MVt kbf/oBQkzxEZbJSxJmb0dkbvmhq2gAE/WfQpPCKciSBP/GeowyMPKIlnuXu26nUx1YZuySOB/YB JaQGs2qddQTNW5MkM59PZ4NwLovAo2mWU3g== X-Received: by 2002:a05:600c:6995:b0:477:7af8:c8ad with SMTP id 5b1f17b1804b1-48069c92c03mr93433795e9.31.1769632285338; Wed, 28 Jan 2026 12:31:25 -0800 (PST) X-Received: by 2002:a05:600c:6995:b0:477:7af8:c8ad with SMTP id 5b1f17b1804b1-48069c92c03mr93433305e9.31.1769632284808; Wed, 28 Jan 2026 12:31:24 -0800 (PST) Received: from redhat.com (IGLD-80-230-34-155.inter.net.il. [80.230.34.155]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066beeaf9sm161529595e9.6.2026.01.28.12.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 12:31:24 -0800 (PST) Date: Wed, 28 Jan 2026 15:31:21 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 15/15] vsock/virtio: reorder fields to reduce padding Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reorder struct virtio_vsock fields to place the DMA buffer (event_list) last. This eliminates the padding from aligning the struct size on ARCH_DMA_MINALIGN. Suggested-by: Stefano Garzarella Signed-off-by: Michael S. Tsirkin --- changes from v2: move event_lock and event_run too, to keep event things logically together, as suggested by Stefano Garzarella. Note: this is the only change in v3 and it's cosmetic, so I am not reposting the whole patchset. net/vmw_vsock/virtio_transport.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 999a0839726a..b333a7591b26 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -55,15 +55,6 @@ struct virtio_vsock { int rx_buf_nr; int rx_buf_max_nr; - /* The following fields are protected by event_lock. - * vqs[VSOCK_VQ_EVENT] must be accessed with event_lock held. - */ - struct mutex event_lock; - bool event_run; - __dma_from_device_group_begin(); - struct virtio_vsock_event event_list[8]; - __dma_from_device_group_end(); - u32 guest_cid; bool seqpacket_allow; @@ -77,6 +68,15 @@ struct virtio_vsock { */ struct scatterlist *out_sgs[MAX_SKB_FRAGS + 1]; struct scatterlist out_bufs[MAX_SKB_FRAGS + 1]; + + /* The following fields are protected by event_lock. + * vqs[VSOCK_VQ_EVENT] must be accessed with event_lock held. + */ + struct mutex event_lock; + bool event_run; + __dma_from_device_group_begin(); + struct virtio_vsock_event event_list[8]; + __dma_from_device_group_end(); }; static u32 virtio_transport_get_local_cid(void) -- MST