mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v5 4/4] KVM: async_pf: Let host know whether the guest support delivery async_pf as #PF vmexit
Date: Tue, 27 Jun 2017 15:19:41 +0200	[thread overview]
Message-ID: <ce51ee19-0e9a-ab07-ff22-12d991d9cd7b@redhat.com> (raw)
In-Reply-To: <1498528021-5115-5-git-send-email-wanpeng.li@hotmail.com>



On 27/06/2017 03:47, Wanpeng Li wrote:
> -		wrmsrl(MSR_KVM_ASYNC_PF_EN, pa | KVM_ASYNC_PF_ENABLED);
> +		pa |= KVM_ASYNC_PF_DELIVERY_AS_PF_VMEXIT | KVM_ASYNC_PF_ENABLED;
> +		wrmsr_safe(MSR_KVM_ASYNC_PF_EN, pa & 0xffffffff, pa >> 32);
>  		__this_cpu_write(apf_reason.enabled, 1);

Better:

	pa |= KVM_ASYNC_PF_ENABLED;

	/* Async page fault support for L1 hypervisor is optional.  */
	if (wrmsr_safe(MSR_KVM_ASYNC_PF_EN,
		       pa | KVM_ASYNC_PF_DELIVERY_AS_PF_VMEXIT) < 0)
		wrmsrl(MSR_KVM_ASYNC_PF_EN, pa);

Thanks,

Paolo

  reply	other threads:[~2017-06-27 13:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  1:46 [PATCH v5 0/4] KVM: async_pf: Fix async pf exception injection Wanpeng Li
2017-06-27  1:46 ` [PATCH v5 1/4] KVM: x86: Simple kvm_x86_ops->queue_exception parameter Wanpeng Li
2017-06-27  1:46 ` [PATCH v5 2/4] KVM: async_pf: Add L1 guest async_pf #PF vmexit handler Wanpeng Li
2017-06-27 13:30   ` Paolo Bonzini
2017-06-27 22:40     ` Wanpeng Li
2017-06-27  1:47 ` [PATCH v5 3/4] KVM: async_pf: Force a nested vmexit if the injected #PF is async_pf Wanpeng Li
2017-06-27 13:40   ` Paolo Bonzini
2017-06-27  1:47 ` [PATCH v5 4/4] KVM: async_pf: Let host know whether the guest support delivery async_pf as #PF vmexit Wanpeng Li
2017-06-27 13:19   ` Paolo Bonzini [this message]
2017-06-27 22:49     ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce51ee19-0e9a-ab07-ff22-12d991d9cd7b@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®