From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-212.mta0.migadu.com [91.218.175.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 052AC40B38C for ; Sat, 10 Oct 2026 11:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.212 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791630878; cv=none; b=N4VHLIAK5Kne5N1Phw83hmY/1FFs0FGryX2925wsUYH5UP4XARULlJ7qVcfhAv4batoLzxPev5eMydNbEC0MrJX68NwpF1u5Nnlk+y9XD9Tdg2k1yRXaQBnUtVycyFAHwG3yplxys1obTHnOnqjMnaCVoENYwg28FlP+59owchQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791630878; c=relaxed/simple; bh=yn4p2s9JivjvBTqbIsK6tSDnIq73X7zd5BQ9ePHoMnI=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=UnEouWt1rWWfooy+uWsAT88O3ti6DEZ5B7b2sX4BLdnCUAgfpq0p2csUQpBRrMDjdEfqP2MrgIA+QW77fz9QhQLs8fYAIU+nd+GFcGx9iTVVKG7sH8GmOtSyVi6g5YQ+//EM4oQ3wjaFL2HwxfZkcfWEOrhXjrlUnI7dWTnhIME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XkvEz/FM; arc=none smtp.client-ip=91.218.175.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XkvEz/FM" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=yn4p2s9JivjvBTqbIsK6tSDnIq73X7zd5BQ9ePHoMnI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1791630872; v=1; x=1792235672; b=XkvEz/FM5/D9yAV3zvtso4HqPuiP4eXF/G6dx2bR1zg4buWnzPeJxMTxSU16wl79sSqguJBI kECoJmQdPlbQWbf6NY5nrIUY5vhV8zcvLs9lkudJk6UQbXSqYBkG37GFO/DpRyOlp2VxraD1NXJ lpY/cRu0B34MBwfk6Vt823tU= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 1c509de7a57eaea1; Sat, 10 Oct 2026 11:14:32 +0000 X-Mizu-Trace-ID: 1c509de7a57eaea1 X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sat, 10 Oct 2026 11:14:32 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Luka Gejak" Message-ID: TLS-Required: No Subject: Re: [PATCH v2] wifi: rtw88: 8723b: avoid converting RX SNR twice To: "Hungyu Lin" , pkshih@realtek.com Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, rtl8821cerfe2@gmail.com, straube.linux@gmail.com, "Hungyu Lin" In-Reply-To: <3c89d2ac770c659eacd532134c89b4725be9ab97.1791627615.git.dennylin0707@gmail.com> References: <3c89d2ac770c659eacd532134c89b4725be9ab97.1791627615.git.dennylin0707@gmail.com> October 10, 2026 at 12:47 PM, "Hungyu Lin" wrote: >=20 >=20rtw8723b_query_phy_status_ofdm() divides the SNR report by two when > filling pkt_stat->rx_snr, then shifts it again when updating > dm_info->rx_snr. This halves the SNR used for diagnostics and average > statistics. >=20 >=20Store the raw report in pkt_stat->rx_snr and convert it only when > updating dm_info->rx_snr, as the other chip drivers do. >=20 >=20Fixes: d726c70ce082 ("wifi: rtw88: 8723b: add the RTL8723B chip drive= r") > Signed-off-by: Hungyu Lin Ping-Ke should fixes tag be present here if this commit isn't in mainline yet? > --- > Changes in v2: > - Store the raw SNR report in pkt_stat->rx_snr and keep the shift when > updating dm_info->rx_snr. >=20 >=20 drivers/net/wireless/realtek/rtw88/rtw8723b.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 >=20diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.c b/drivers/= net/wireless/realtek/rtw88/rtw8723b.c > index 8bb9c03d769c..18bd2b108ccb 100644 > --- a/drivers/net/wireless/realtek/rtw88/rtw8723b.c > +++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.c > @@ -1280,7 +1280,7 @@ static void rtw8723b_query_phy_status_ofdm(struct= rtw_dev *rtwdev, void *phy_raw > pkt_stat->rx_power[RF_PATH_A] =3D (val_s8 * 2) - 110; >=20=20 >=20 pkt_stat->rssi =3D rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1); > - pkt_stat->rx_snr[RF_PATH_A] =3D (s8)(phy_status->path_rxsnr[RF_PATH_A= ] / 2); > + pkt_stat->rx_snr[RF_PATH_A] =3D phy_status->path_rxsnr[RF_PATH_A]; >=20=20 >=20 /* signal power reported by HW */ > val_s8 =3D phy_status->cck_sig_qual_ofdm_pwdb_all >> 1; > Either way change looks good to me. Reviewed-by: Luka Gejak Best regards, Luka Gejak