From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BC6C433F5 for ; Mon, 14 Feb 2022 21:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbiBNVug (ORCPT ); Mon, 14 Feb 2022 16:50:36 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231578AbiBNVuc (ORCPT ); Mon, 14 Feb 2022 16:50:32 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48C0D19723B for ; Mon, 14 Feb 2022 13:50:24 -0800 (PST) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 2C4A440053 for ; Mon, 14 Feb 2022 21:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644875423; bh=SK7G4ypmuhoiLsaPwNFfqBVBg1y4potPtaeeipvUqEo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D34q1UVP62+M8ZRDfWnu9n+oB1v+k4pormbadL0Ki/p9sPrGu7uJodPuSMejJJat/ WHYW5oVg3k+gkLhhOvuEg8HksGL20ImNLulGLqp6PwJjubVy2Ooz+vP3oXQ7AHMgUb kBX00OVvO1UuxFrqiSQLrn7vMPs2r7CTHeHDVs4D5332srP1I+31zPwxcxU5ehbZgW UjdNseHOvOSLqv1y7s3uB9IFbdNOU4wpst3s9dYJ4F35aNP5ywDJd7mzG0S3NvkXPP EWsyJUMTlxVjbNQ8c8U/hmBMmpREg3xQLL1bp1fy9VzB5gG8ajjnUKwkcDejKLGmTX alkR5btA5jjwA== Received: by mail-wr1-f69.google.com with SMTP id k3-20020adfb343000000b001e463e6af20so7376908wrd.8 for ; Mon, 14 Feb 2022 13:50:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SK7G4ypmuhoiLsaPwNFfqBVBg1y4potPtaeeipvUqEo=; b=AH91Xy5mBzT1R4UQdca10Vuic4K+lF6EfQOejyDur6khfLxjQj5R0NjUbthgH1amBL 5ZP9v40w+YXW/Br3FHZe2wvSuiIx9Dr/84axgcRMFt6S91UOBsborWxZ5StVkAbw1hg9 q9LRqchLNdMiQdN5EEHyUOpYpEAkF0amnrGab0hKZfk4J87JduQFYvCZq8u705FuMUMO NAp6wXLh1goqG4ArYO9TXnlHu/UrJxIePkUkNSTqRYPStyeNXacbEZ4AW2POl5uZF2J9 EHSH+AhTXXmRHLHni5+whRIZDk5UK+BBOJrCkD5Fy/IKF/U3efiIdEGAxzjWIkvZIah1 LqzQ== X-Gm-Message-State: AOAM530UJdJyYEic9KHC9QvLbd+B+Z8EmRLSmWmr94XWD66qN/7gBwS0 cuVpZGtD3nfQAqyBehLF8/N1z2V2qwOTjF/eR2fXrUGhFoubHmNuKrksSFX1KyyXUYJimjc2fjh BVhx1GUoccfRbX9U7/WFNXGgiXH81e9MM/SfRAEipmA== X-Received: by 2002:a05:6000:1a86:: with SMTP id f6mr736491wry.401.1644875422510; Mon, 14 Feb 2022 13:50:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJygBAmKnUaBhnqEsn25FVjZQMtwe8K8BzcNWLC4Y/B5LAnAJFvu17U+OWfVIobOofQEzcDjLw== X-Received: by 2002:a05:6000:1a86:: with SMTP id f6mr736481wry.401.1644875422326; Mon, 14 Feb 2022 13:50:22 -0800 (PST) Received: from [192.168.0.106] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id z2sm12703881wrn.60.2022.02.14.13.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 13:50:21 -0800 (PST) Message-ID: Date: Mon, 14 Feb 2022 22:50:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] input: ps2-gpio: enforce and document open drain Content-Language: en-US To: Danilo Krummrich , dmitry.torokhov@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org References: <20220211233137.99624-1-danilokrummrich@dk-develop.de> <20220211233137.99624-3-danilokrummrich@dk-develop.de> From: Krzysztof Kozlowski In-Reply-To: <20220211233137.99624-3-danilokrummrich@dk-develop.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/2022 00:31, Danilo Krummrich wrote: > The PS/2 bus defines the data and clock line be open drain, therefore > document this in the dt-binding and enforce the particular flag in the > driver. > > Without enforcing to flag at least the clock gpio as open drain we run > into the following warning: > > WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90 > > gpiochip_enable_irq() warns on a GPIO being configured as output and > using IRQ without being flagged as open drain. > > Signed-off-by: Danilo Krummrich > --- > .../devicetree/bindings/serio/ps2-gpio.yaml | 14 ++++++++++---- > drivers/input/serio/ps2-gpio.c | 9 +++++++-- > 2 files changed, 17 insertions(+), 6 deletions(-) > Bindings as separate patch, please. Best regards, Krzysztof