From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B00FC7EE26 for ; Mon, 8 May 2023 13:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234242AbjEHNeb (ORCPT ); Mon, 8 May 2023 09:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234089AbjEHNe2 (ORCPT ); Mon, 8 May 2023 09:34:28 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 251652BCFC for ; Mon, 8 May 2023 06:34:26 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ac785015d7so50811581fa.1 for ; Mon, 08 May 2023 06:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683552864; x=1686144864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eW/Xoqha7GvBVNQCr94/Unb8pBuTnqvx5e8HgXob2Oo=; b=wJd4cqFfFV75jLA/Bhv7JNVO5fuEgKDqWirW5VEJrET7t3hR0MbMzgzUeXWsOpEPLd R0L/Kpn+iuBMNVoHV8HKH38IR9+2ldkfPK0UFfPM4HhUno/X5wnULovpv4cfagdBdKFa B/7k4KFEnzam5zJB3doByobCwiddoPKC+p2ZqiEniwbEoVP28Kl6WearB8I7rRxa2S21 mFpL0M+NNDa+v+b+wuaYvkSlZpQiUuZ2EizFhacA5PHBXe7Z9MN7595FF5XVlOJAwK5r 76UfEJ2b5R4wz9ewWlrMDXD+52ViORbjsewrS4iD4Ww7phVO2zogWYkVOYN1xLc+xJsz NIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683552864; x=1686144864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eW/Xoqha7GvBVNQCr94/Unb8pBuTnqvx5e8HgXob2Oo=; b=H4uO3IJYMIjpDnUZIiR8iYcSVoh/HpsgO0NKZkmDrFjxCq5Ek3y0VU1icWxq1y98gw b/r9tX2faMvvI9AqV7p14ro3azOAJTbm2wut3vOlc9sAt1K5kmNsUN7GwRiRwD81TIlA 3rzsHkpeh96NTeL4hItT8pxdmDot6wKM0tRl8H+JYpT1TzSKUl0l2S/j9VuY2o7iXs8B sR6MB33Gf5KZuiAC64cKoqFEG/YfxuKc96t3xTZsC06hd8l//jdi8udTDkwuaAjedq02 +Jlthh5xw9FtVBrhdVi0pGXsv5l4MARR+HYydXi+z5TnxAxQNj1NBK8SMT/gCI2Pp4le mJGw== X-Gm-Message-State: AC+VfDzUGbACNHhdObNQCvGqs8wJTCOabNw0NkPNSXg9nItj8GWVAn9v tvO8flLTnGkVCuuODwjE6QDwpw== X-Google-Smtp-Source: ACHHUZ4J+LcBj3M5C1NolVZpuen3mKtDTUse1h5L6FRgxhDI2fJm3BTsEpnVqe/qeQ5wDsKuyT+13g== X-Received: by 2002:a2e:8619:0:b0:2a8:bc05:ab4 with SMTP id a25-20020a2e8619000000b002a8bc050ab4mr3182611lji.34.1683552864352; Mon, 08 May 2023 06:34:24 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id d7-20020a2e3607000000b002a9ef98116asm1192691lja.49.2023.05.08.06.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 06:34:23 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 16:34:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 6/6] thermal: qcom: tsens-v0_1: Add MSM8909 data Content-Language: en-GB To: Stephan Gerhold , Daniel Lezcano Cc: Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230508-msm8909-tsens-v4-0-d9119622cb19@kernkonzept.com> <20230508-msm8909-tsens-v4-6-d9119622cb19@kernkonzept.com> From: Dmitry Baryshkov In-Reply-To: <20230508-msm8909-tsens-v4-6-d9119622cb19@kernkonzept.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2023 16:13, Stephan Gerhold wrote: > The MSM8909 SoC has 5 thermal sensors in a TSENS v0.1 block. Like > MDM9607 it uses a non-standard default slope value of 3000 [1] and needs > per-sensor "correction factors" to workaround issues with the factory > calibration [2]. > > [1]: https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/blob/LA.UM.7.7.c26-09100-8x09.0/arch/arm/boot/dts/qcom/msm8909.dtsi#L476 > [2]: https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/commit/6df022c6d0c2c1b4a5a6c2124dba4d57910c0911 > > Reviewed-by: Konrad Dybcio > Signed-off-by: Stephan Gerhold Reviewed-by: Dmitry Baryshkov > --- > drivers/thermal/qcom/tsens-v0_1.c | 36 +++++++++++++++++++++++++++++++++++- > drivers/thermal/qcom/tsens.c | 3 +++ > drivers/thermal/qcom/tsens.h | 2 +- > 3 files changed, 39 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c > index e69889dd524a..f97d313f0536 100644 > --- a/drivers/thermal/qcom/tsens-v0_1.c > +++ b/drivers/thermal/qcom/tsens-v0_1.c > @@ -207,6 +207,27 @@ static int calibrate_8974(struct tsens_priv *priv) > return 0; > } > > +static int __init init_8909(struct tsens_priv *priv) > +{ > + int i; > + > + for (i = 0; i < priv->num_sensors; ++i) > + priv->sensor[i].slope = 3000; > + > + priv->sensor[0].p1_calib_offset = 0; > + priv->sensor[0].p2_calib_offset = 0; > + priv->sensor[1].p1_calib_offset = -10; > + priv->sensor[1].p2_calib_offset = -6; > + priv->sensor[2].p1_calib_offset = 0; > + priv->sensor[2].p2_calib_offset = 0; > + priv->sensor[3].p1_calib_offset = -9; > + priv->sensor[3].p2_calib_offset = -9; > + priv->sensor[4].p1_calib_offset = -8; > + priv->sensor[4].p2_calib_offset = -10; > + > + return init_common(priv); > +} > + > static int __init init_8939(struct tsens_priv *priv) { > priv->sensor[0].slope = 2911; > priv->sensor[1].slope = 2789; > @@ -243,7 +264,7 @@ static int __init init_9607(struct tsens_priv *priv) > return init_common(priv); > } > > -/* v0.1: 8916, 8939, 8974, 9607 */ > +/* v0.1: 8909, 8916, 8939, 8974, 9607 */ > > static struct tsens_features tsens_v0_1_feat = { > .ver_major = VER_0_1, > @@ -292,6 +313,19 @@ static const struct reg_field tsens_v0_1_regfields[MAX_REGFIELDS] = { > [TRDY] = REG_FIELD(TM_TRDY_OFF, 0, 0), > }; > > +static const struct tsens_ops ops_8909 = { > + .init = init_8909, > + .calibrate = tsens_calibrate_common, > + .get_temp = get_temp_common, > +}; > + > +struct tsens_plat_data data_8909 = { > + .num_sensors = 5, > + .ops = &ops_8909, > + .feat = &tsens_v0_1_feat, > + .fields = tsens_v0_1_regfields, > +}; > + > static const struct tsens_ops ops_8916 = { > .init = init_common, > .calibrate = calibrate_8916, > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 065d0f9728a5..1d7c149038e0 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -1109,6 +1109,9 @@ static const struct of_device_id tsens_table[] = { > }, { > .compatible = "qcom,mdm9607-tsens", > .data = &data_9607, > + }, { > + .compatible = "qcom,msm8909-tsens", > + .data = &data_8909, > }, { > .compatible = "qcom,msm8916-tsens", > .data = &data_8916, > diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h > index 880be6be5c3f..c88287dede96 100644 > --- a/drivers/thermal/qcom/tsens.h > +++ b/drivers/thermal/qcom/tsens.h > @@ -639,7 +639,7 @@ int get_temp_common(const struct tsens_sensor *s, int *temp); > extern struct tsens_plat_data data_8960; > > /* TSENS v0.1 targets */ > -extern struct tsens_plat_data data_8916, data_8939, data_8974, data_9607; > +extern struct tsens_plat_data data_8909, data_8916, data_8939, data_8974, data_9607; > > /* TSENS v1 targets */ > extern struct tsens_plat_data data_tsens_v1, data_8976, data_8956; > -- With best wishes Dmitry