From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9143AB496 for ; Thu, 30 Jul 2026 18:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785434554; cv=none; b=Y7cFOW3RUyzSjovJQZLc2KOqGJRSf1wlclzXePlrRzIgDEbYCKAVgCVq4VI2u0FCPj+1U9HjcHrxcfemb8ubnd9FtzfVpcAc7wARQpgY/3kmajp9+ljvur7OxBTDt1IDG+wLL7tqrbyOv1Kd4fr6+2bFqMPLnt4oUu1KrMQvMgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785434554; c=relaxed/simple; bh=BJ/4rtxLJ3OUT8j1IeHIi1+42TYtIAWMAyf8v5atvH4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qAh1tTjOUkPTCMF2IWvXr/yAKRaVw/4Qi9M5QhFNX/g7LWwpivtcWs/ZPu6xX5fg4XgNQabnVjKE/5DWBH3FC3aNbqH5P1GodJLZVPSuuD5TRwbV9ufoKy6GOQ7ABaiCMILDu5qeYNAhRyzJ3SqoZY02LQblz/RSXIsoLHaQPr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hPW+HIhA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dKLmiJiw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hPW+HIhA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dKLmiJiw" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UGXDWs1629564 for ; Thu, 30 Jul 2026 18:02:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FmpZDlvYo4bIIHmIKcULNpFvjwTYQhKuozzyEdxOXis=; b=hPW+HIhAFVnfK6kc CvMOuB14DfgJNPj2spVU74+ZUZuo0QrBSTskJUVN1KMHMamhP/Pyq1fyCkdlh35/ g0cGMZzvMDTShb1KlpVPnW9Ys5PMgUWHoOY/R0Lv7XZtomPjwgcMJah6/k8gb8/a KV+FOb4iJLb/bde7RIXB96PbIS2nCM4EmRzaAhJ779hpnFc3UzfPcZHigXmNmhE2 PV1J7JS9JPZUuf1OgU06wk788toSZToaVlcy3BMSjZCo9ZRITbktterZpBSOLdfj RxRvNelnH7zkTXTU/+7sZpZ67xd/IOlWsjI2p8I0Dl0beOv/ZygRxPfLs9g1ZxTq dWKNAQ== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr7q3hc0u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 18:02:31 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9778b29c71fso15317241.3 for ; Thu, 30 Jul 2026 11:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785434551; x=1786039351; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FmpZDlvYo4bIIHmIKcULNpFvjwTYQhKuozzyEdxOXis=; b=dKLmiJiwnJab6MkllE/qLIe7ZCabO2XJllk2fFhL2WASHuH0eP0Yvt6zUPai+/C+Yu gMBx6WaXDGEMYVgD7Mow65Ix8nNtSfZQ7v0/U1oqni7mVZPIE9GQybLj/O2QxJ5gvfNy t+ZOjvN3aIHFaRMuOlGbUVSFiE5TarA0cBmwSRKPMqpomym2OnEWx1SHtgvmCoATAFT0 QEuXdDblsPmgTcgou2b0Skbc6f1jAWyv17Pk3AQqcl7TajNhSN1p3dX3DtYotrWOFuHZ jHgVbZwXgwKuVLR3FDKG6jrcZWGvMuQjmMMANUxhaw1Ts5YoldF8UNGSpjFmF/U6W/yd QiiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785434551; x=1786039351; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FmpZDlvYo4bIIHmIKcULNpFvjwTYQhKuozzyEdxOXis=; b=YeJTMz5ldB69xbiuiO0jdIY2cnuGg2BjFguOAqD/csFfUU2yb3MsZooceLB0Q/T+mq TtPnZkvxXe5OZJpYC2rGFS4zzwTcv90yXDdSKEuO2pUjFvYMyOxs+0cNoRZ2TkyT3ZPE 8rJoLFT5vvNH3ZQG2MTw+mhB1t4xJSwbRjJEpeOz7ydZEENsAtOAcxmauGNtmT7P/3kf ZuFTzVv3BcAsM0XKKRb+kXWzg2GZ+Wfedg5P8oYubOxDFiUcyyLEDGfoEOqeyfJU0e1W jJ/mGWs2q3hCVNm+KAd+dDnfeSTYH4H6jfKX9rGXOe4mzLs6rzvWkJEfd/uOIRph1dMC h1eA== X-Forwarded-Encrypted: i=1; AHgh+RrfJJy02xX4VRuAsN5Xt+Hy3Zct+gXz0PVMPsPJrmtvf3vmsHUXwPzoD2TgnoOcGeF1S0ZkArO102WGCJM=@vger.kernel.org X-Gm-Message-State: AOJu0YxC8TJPQBOiI9wAcDabBkFZvR9fOl8wJj5V9jYDb02wE7koa88i duxmo7GHD3kBjPZF2z81vI+3qHF6smA53uOoxBZbRSG7PQEaUAmTsLEPXFMxdreVgZNICcYD66y Qj+bE9cesP5FuG2MtHalqOGZEikDWxsStCdi20ni8LvBc3x7Ia1yBLSW82c8Kq0sqpxM= X-Gm-Gg: AR+sD10Fw5yJraBWSByKmJQeAHcpvheXtnHxQboPUYldyFWLkMf2uSwzLlBkiIn6qJZ aA1Yed9NZZPAA5HyMBY67hSt8R6GdMBSURn5+ux23R/k0iUDK8rw6nTMO/ykO7VsmkPM4lgF1FE Kbc0ahJd8nzSD79CzIwIwp1kXWaV2uyYaRRIlFPW/p/bR9SnarLznXAuetGcrZo+u7Jn6ocj18n aeJDo4xgiY605U5Ar4+IVBpgM2aFbuDBJ02ocXfyUaX2cr+XkwbssqTKEm3TLFYRQB3eiXDbq6r 6ZAXtWoCFVoNzAUP7yC037gQEORMlEn/gqHhVI+MlI/I/JSUZzxal4MkdCzS/JFC2A9odK1JUO1 oBdBKna9mbElvckqsxQUMchu/jIL4ddEa X-Received: by 2002:a05:6102:4415:b0:740:2d40:a234 with SMTP id ada2fe7eead31-7574e4dcc08mr1462804137.9.1785434550546; Thu, 30 Jul 2026 11:02:30 -0700 (PDT) X-Received: by 2002:a05:6102:4415:b0:740:2d40:a234 with SMTP id ada2fe7eead31-7574e4dcc08mr1462740137.9.1785434550047; Thu, 30 Jul 2026 11:02:30 -0700 (PDT) Received: from [192.168.1.73] ([92.247.57.178]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fa8577e83sm98649166b.17.2026.07.30.11.02.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 11:02:29 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 21:02:26 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: sm8250: Add JPEG encoder node To: Dmitry Baryshkov Cc: linux-media@vger.kernel.org, bod@kernel.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260730150524.2659577-1-atanas.filipov@oss.qualcomm.com> <20260730150524.2659577-4-atanas.filipov@oss.qualcomm.com> Content-Language: en-US From: Atanas Filipov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDEzNCBTYWx0ZWRfXxH/GxYrVYe6J M3OA8KajRI948GMNdI5j+W/a8YlT2aCdCU4NeCe/+VTJD6g9zEwVumPg44PfCAHBLVcY8CoPkFr FIYfHh8tgE7J1V8PB6h95OSzMKCZhn8uak8NQENmGBrpeofYxKLNq8jW4KjUm370XkT+rVI2bOR hYBPPOc3lQcGbIa0A3pEEYX9tu+ZHfOKCSt2X064m2JwsoImdaVtv4m8/O2itMklIpYRo9wJKcr zbZCeSk3q0cOsS9psaaHlhMSgqb9KyfpWrxbPn0hj/pmfb1NsqR7QS7jEZazximbaq3j6EAZ78b OMQ+xmmSpn7ToNZ5YfWXkXh4O3BybNwK3WWz0aHK2l5HPW7XqKEjznD1QBDyHNZ5YNHR2Xf3qv2 IgsJPMmfo23aOlCdamv7rxS39b/3UJuZlLtoq7UuBaK+p5b+Zfw1Z3HD14F81wbay3/qXQkoljv RSTEZ3TG7jf9CcOWIWA== X-Proofpoint-GUID: o1H3bMPfNSn685QkIf_QvH5_pg5odSnu X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDEzNCBTYWx0ZWRfXxpehCSKWfzjV drvmN2JrYnTB5mOu4+6YrOiao1Q5J2V5nLKIWiAK5PlROOO3TUBxJRSPivis9fz0y7PQFbrK3qN wIgYo3/Yw44QMvWGwpKeURYtezxWpS8= X-Proofpoint-ORIG-GUID: o1H3bMPfNSn685QkIf_QvH5_pg5odSnu X-Authority-Analysis: v=2.4 cv=WuQb99fv c=1 sm=1 tr=0 ts=6a6b91b7 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=ybD9qRDIDfZaXNPQ7Ca20A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=O0DfClCy2XHIW_CjMjMA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_05,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300134 On 7/30/2026 7:01 PM, Dmitry Baryshkov wrote: > On Thu, Jul 30, 2026 at 06:05:24PM +0300, Atanas Filipov wrote: >> Add the JPEG encoder hardware node to the SM8250 device tree so the >> qcom-jpeg V4L2 encoder driver can bind and operate on this platform. >> >> Signed-off-by: Atanas Filipov >> --- >> arch/arm64/boot/dts/qcom/sm8250.dtsi | 72 ++++++++++++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi >> index f11da2ca4181..d42b29419320 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -4486,6 +4487,77 @@ cci1_i2c1: i2c-bus@1 { >> }; >> }; >> >> + jpeg-encoder@ac53000 { >> + compatible = "qcom,sm8250-jpeg-enc"; >> + status = "disabled"; >> + >> + reg = <0x0 0x0ac53000 0x0 0x1000>; >> + >> + interrupts = ; >> + >> + power-domains = <&camcc TITAN_TOP_GDSC>, >> + <&rpmhpd RPMHPD_MMCX>, > > Is TITAN_TOP a part of the MMCX or CX domain? In the former case, > please drop separate mmcx vote here and let it come through the > titan_top (it might require camcc driver and node modifications). > The change was requested by Brian, most likely in connection with upcoming migrations. I think he would be able to explain the exact reasons. As far as the facts are concerned, this is not currently necessary for the driver to be functional. Regards, Atanas >> + <&rpmhpd RPMHPD_MX>; >> + power-domain-names = "titan_top", "mmcx", "mx"; >> + >> + clocks = <&gcc GCC_CAMERA_SF_AXI_CLK>, >> + <&camcc CAM_CC_CORE_AHB_CLK>, >> + <&camcc CAM_CC_CPAS_AHB_CLK>, >> + <&camcc CAM_CC_CAMNOC_AXI_CLK>, >> + <&camcc CAM_CC_JPEG_CLK>; >> + >> + clock-names = "sf_axi", >> + "core_ahb", >> + "cpas_ahb", >> + "cnoc_axi", >> + "jpeg"; >> + >> + interconnects = <&gem_noc MASTER_AMPSS_M0 QCOM_ICC_TAG_ACTIVE_ONLY >> + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, >> + <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI_CH0 QCOM_ICC_TAG_ALWAYS>; >> + interconnect-names = "cpu-cfg", >> + "sf-mnoc"; >> + >> + iommus = <&apps_smmu 0x2040 0x400>; >> + >> + operating-points-v2 = <&jpeg_opp_table>; >> + >> + jpeg_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + opp-100000000 { >> + opp-hz = /bits/ 64 <400000000>, >> + /bits/ 64 <100000000>; >> + required-opps = <&rpmhpd_opp_min_svs>; > > This looks a bit strange. Are you sure that PLL levels match the MMCX / > internal clock levels? I think you need to vote on both domains. > >> + }; >> + >> + opp-200000000 { >> + opp-hz = /bits/ 64 <400000000>, >> + /bits/ 64 <200000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-400000000 { >> + opp-hz = /bits/ 64 <400000000>, >> + /bits/ 64 <400000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-480000000 { >> + opp-hz = /bits/ 64 <400000000>, >> + /bits/ 64 <480000000>; >> + required-opps = <&rpmhpd_opp_svs_l1>; >> + }; >> + >> + opp-600000000 { >> + opp-hz = /bits/ 64 <400000000>, >> + /bits/ 64 <600000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + }; >> + }; >> + }; >> + >> camss: camss@ac6a000 { >> compatible = "qcom,sm8250-camss"; >> status = "disabled"; >> -- >> 2.34.1 >> >