Re: [PATCH v6] staging: wlan-ng: replace strncpy() with strscpy()

[Dan Carpenter <dan.carpenter@linaro.org>]

On Fri, Oct 13, 2023 at 02:15:43PM +0300, Calvince Otieno wrote:
> Checkpatch suggests the use of strscpy() instead of strncpy().
> The advantages are that it always adds a NUL terminator and it prevents
> a read overflow if the src string is not properly terminated. One
> potential disadvantage is that it doesn't zero pad the string like
> strncpy() does.
> In this code, strscpy() and strncpy() are equivalent and it does not
> affect runtime behavior. The string is zeroed on the line before
> using memset(). The resulting string was always NUL terminated and
> PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
> terminated.
> However, even though using strscpy() does not fix any bugs, it's
> still nicer and makes checkpatch happy.
> 
> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
> ---

It's still white space damaged and can't apply.  :/  Try save the email
and do `cat raw_email.txt | patch -p1`.

regards,
dan carpenter