From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1AF5334C31 for ; Fri, 14 Nov 2025 16:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763138044; cv=none; b=ixO6lqrDdejzSuuamJRNRJzzagb7A22lVTI5KKm8YmGdJ7jOUvMzdZNvl0PB2mYL8oPPkpRPfXHv309+jgvcwC3A1Cqszhxicq+LQVw/4kVXIS377+fFCT8SE02FxVa676Rjl/QkNbUi/LiP13p3qN014wBS+JwQC1UAaQzXNsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763138044; c=relaxed/simple; bh=oxh3YhoYIEaRIxjaDBRpdM9oBRVhQNhueXgTg63TZzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KuvvwZGWC1QQS3niSJbW9tNqJ7TzwDtv0xtwUUUnTLLEMWK+yhbiP3z8X2cZwdbz/VJpqyV+PVqJo3mhXNgFv1MRNKMMvXDEH0E6jESbzg+mGbcLHXBQWwF/rkdNmy6Fclmh4Md5AHhmlWJ7g6680A8Agi5i2olEjzqyzmAWKxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=bvUthont; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="bvUthont" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-4503ee5c160so991910b6e.1 for ; Fri, 14 Nov 2025 08:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1763138041; x=1763742841; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y0zENIizSbsPE8jKfF4DXIWFz//T1Rw3ce5Z4/4op8w=; b=bvUthontk/JYSiBLXXA1j7sRVpmrEHfrAzKzpN6lOsUoSUCxLZXH1z94YpnuNiw4Vv WYflolEfpgp2cSTBWSs7Lszcd5HKtYowglJEFOlobzeGa6yc7aMuMjuw1M6N2wb/+Ebv 9IFh+Gj37jpdYIdeJNV1HL/4kIAAztICTwvpdE8LNTwUl22UlIsrYURVDtkjcsH8nmJ/ NH4wTaKliD92wZe+2p8mHWMcD3mfAd/Rve9DDPLBq1DxEyXI9n0pn+1GbjLIxBc+09sS VO4kt/5cAKjTkX9xyOAg+FWImBBQvyP47CJLGIzdP0Us5U4lBKAi8OU+9dQIvxiXIv+g 703A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763138041; x=1763742841; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y0zENIizSbsPE8jKfF4DXIWFz//T1Rw3ce5Z4/4op8w=; b=jEJtcsSfsnELjov/GPyL8fF2s3A38+lBTXBt0L61IA8ZgUJboypxJa7tr1SEZjtkiF R++l355CO8MQfRvzrIoZsvDyc7KUuse3htUIQQofsdwKcVoZTKnw8XwexqeYOaic2on1 UAANYXC0PJ01KeGUfZKZ+VcCXr3SoNkx/zdtF4W6Z7UslGaS76AXQEO/v9qfk142rzWY e6xCVtUOoBl5nnIghQ7jl683FKmmRaT2S1GMG0VQAXLz+WVIqx5JnzwQCrmOK99UvsNy SEhLieMx00irqLORy2ogLzKaYMa5Qvuf41F/k/KepVOIKgN8ze0bW7FOGEKtUz9yEGxX 4Ggg== X-Forwarded-Encrypted: i=1; AJvYcCVQudaQ9pEgdMqUGjp5dEWFbvomGll/8aRJIT5ijm3pYcemCISCnvjNRAeFDp/Qhhx5DxFJ2VlGctZZQRg=@vger.kernel.org X-Gm-Message-State: AOJu0YwME1/yPGsddMwGx9Fp/ZLK3AaSYB422G0mpIBWnxi0honZ2DMZ W6WMRWpP5ykIHzMiMDIiZcMKymG9DW6bRmGbbR9uX77l3tp6VBMMnpaEEBqDCqUSzko= X-Gm-Gg: ASbGncu9SYYeJEnKKYXEud2TOMBj2zql9nP08JYYL/QyMqGEeLn1fRpVrZPwFAClHRw oB+BFXbX9BbDYdHt290GxDovffIAbjSbEML6HXqDl5TztMskDboeU43vAIDD+glNY2eqY1Sgw8G B38lNK9cW569lR4NiiYDjIF+9qT9erjfpPZopYp+Q4toDyBtbhJiqnP2D1lkqpPE9lcCvSY6F3x cKD4VcKwHPYurxotCW/dsL28Qp0f89Nk6BDcmILCBVgf96ziJcy8ULlOXM8W2fMnBb98osXasoh /tYogOt4YcfBtMklBBfMd1/sjAqgTtCUPxdaVWsfB9T8jsQDheSH7n7T9kswoj0K1c9VXgr2Myb 4xFuDXyRIWekGfFq/iOMaaAuPUSqCrutLO8rtlaNVmL8goyk49am3hvgekzKTaK7zN8UoD+lTaC Hf0Dj8Tl5hMq4Gdn0H9ut9bbDoehULVZKqfSe4WMZe4wgRUYk= X-Google-Smtp-Source: AGHT+IGmhIqEMavL0YX2nY1Vq2fABZht6YbPouUJM/5kcUFllpX0N/1OqFLI/iyV9QuRieoYVcXbrQ== X-Received: by 2002:a05:6808:d49:b0:44f:f612:43e9 with SMTP id 5614622812f47-450974b27c5mr1664553b6e.44.1763138040803; Fri, 14 Nov 2025 08:34:00 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:8a43:8337:f820:b43? ([2600:8803:e7e4:500:8a43:8337:f820:b43]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-65724cfa332sm2157866eaf.7.2025.11.14.08.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 08:34:00 -0800 (PST) Message-ID: Date: Fri, 14 Nov 2025 10:33:59 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] bindings: iio: adc: Add bindings for TI ADS131M0x ADCs To: Oleksij Rempel , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Conor Dooley , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Andy Shevchenko , =?UTF-8?Q?Nuno_S=C3=A1?= References: <20251114092000.4058978-1-o.rempel@pengutronix.de> <20251114092000.4058978-2-o.rempel@pengutronix.de> Content-Language: en-US From: David Lechner In-Reply-To: <20251114092000.4058978-2-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/14/25 3:19 AM, Oleksij Rempel wrote: > Add device tree bindings documentation for the Texas Instruments > ADS131M0x analog-to-digital converters. This family includes the ADS131M02, > ADS131M03, ADS131M04, ADS131M06, and ADS131M08 variants. > > These variants differ primarily in the number of supported channels > (2, 3, 4, 6, and 8, respectively), which requires separate compatible > strings to validate the channel nodes. > > Signed-off-by: Oleksij Rempel > Reviewed-by: Conor Dooley > --- > changes v3: > - Make channel@ regex patterns consistent > changes v2: > - Rename file to ti,ads131m02.yaml and update $id. > - Add supplies (avdd, dvdd, refin), interrupts, reset-gpios, and clock-names. > - Make avdd-supply, dvdd-supply, and clock-names required. > - Tighten channel validation logic for each device variant. > - Simplify channel description and reorder datasheet list. > - Update commit message to clarify device difference > --- ... > + - if: > + # 32-pin devices: M06, M08 > + # These support both XTAL/CLKIN and optional REFIN. > + properties: > + compatible: > + enum: > + - ti,ads131m06 > + - ti,ads131m08 > + then: > + properties: > + clock-names: > + description: > + Indicates if a crystal oscillator (XTAL) or CMOS signal is connected > + (CLKIN). > + enum: [xtal, clkin] Usually, we want all possible properties declared at the top level and then only limit them by the conditional statements. This makes it easier to see what all of the possibilities are. At first I thought clock-names had not been added. > + refin-supply: > + description: Optional external reference supply (REFIN). refin-supply should be at the top level as well. > + required: > + - clock-names > +