From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
alim.akhtar@samsung.com
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
andre.draszik@linaro.org, kernel-team@android.com,
willmcvicker@google.com, peter.griffin@linaro.org,
javierm@redhat.com, tzimmermann@suse.de,
vincent.guittot@linaro.org, ulf.hansson@linaro.org,
arnd@arndb.de
Subject: Re: [PATCH v3 2/3] firmware: add exynos ACPM protocol driver
Date: Fri, 6 Dec 2024 00:39:56 +0100 [thread overview]
Message-ID: <ce757b8e-4e6c-4ba9-9483-b57e6e230fdf@linaro.org> (raw)
In-Reply-To: <20241205175345.201595-3-tudor.ambarus@linaro.org>
On 12/5/24 18:53, Tudor Ambarus wrote:
> Alive Clock and Power Manager (ACPM) Message Protocol is defined for
> the purpose of communication between the ACPM firmware and masters
> (AP, AOC, ...). ACPM firmware operates on the Active Power Management
> (APM) module that handles overall power activities.
>
> ACPM and masters regard each other as independent hardware component and
> communicate with each other using mailbox messages and shared memory.
>
> This protocol library provides the interface for all the client drivers
> making use of the features offered by the APM. Add ACPM protocol support.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/firmware/Kconfig | 1 +
> drivers/firmware/Makefile | 1 +
> drivers/firmware/samsung/Kconfig | 14 +
> drivers/firmware/samsung/Makefile | 4 +
> drivers/firmware/samsung/exynos-acpm-pmic.c | 226 +++++
> drivers/firmware/samsung/exynos-acpm-pmic.h | 24 +
> drivers/firmware/samsung/exynos-acpm.c | 772 ++++++++++++++++++
> drivers/firmware/samsung/exynos-acpm.h | 15 +
> .../linux/soc/samsung/exynos-acpm-protocol.h | 57 ++
> 9 files changed, 1114 insertions(+)
> create mode 100644 drivers/firmware/samsung/Kconfig
> create mode 100644 drivers/firmware/samsung/Makefile
> create mode 100644 drivers/firmware/samsung/exynos-acpm-pmic.c
> create mode 100644 drivers/firmware/samsung/exynos-acpm-pmic.h
> create mode 100644 drivers/firmware/samsung/exynos-acpm.c
> create mode 100644 drivers/firmware/samsung/exynos-acpm.h
> create mode 100644 include/linux/soc/samsung/exynos-acpm-protocol.h
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 71d8b26c4103..24edb956831b 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -267,6 +267,7 @@ source "drivers/firmware/meson/Kconfig"
> source "drivers/firmware/microchip/Kconfig"
> source "drivers/firmware/psci/Kconfig"
> source "drivers/firmware/qcom/Kconfig"
> +source "drivers/firmware/samsung/Kconfig"
> source "drivers/firmware/smccc/Kconfig"
> source "drivers/firmware/tegra/Kconfig"
> source "drivers/firmware/xilinx/Kconfig"
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 7a8d486e718f..91efcc868a05 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -33,6 +33,7 @@ obj-y += efi/
> obj-y += imx/
> obj-y += psci/
> obj-y += qcom/
> +obj-y += samsung/
> obj-y += smccc/
> obj-y += tegra/
> obj-y += xilinx/
> diff --git a/drivers/firmware/samsung/Kconfig b/drivers/firmware/samsung/Kconfig
> new file mode 100644
> index 000000000000..eed8cd8a677b
> --- /dev/null
> +++ b/drivers/firmware/samsung/Kconfig
> @@ -0,0 +1,14 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config EXYNOS_ACPM_PROTOCOL
> + tristate "Exynos Alive Clock and Power Manager (ACPM) Message Protocol"
Given the importance of this driver where a lot of PM services rely on,
does it really make sense to allow it as a module ?
Some PM services may be needed very early in the boot process
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2024-12-05 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 17:53 [PATCH v3 0/3] " Tudor Ambarus
2024-12-05 17:53 ` [PATCH v3 1/3] dt-bindings: firmware: add samsung,exynos-acpm-ipc bindings Tudor Ambarus
2024-12-09 8:03 ` Krzysztof Kozlowski
2024-12-09 8:19 ` Tudor Ambarus
2024-12-05 17:53 ` [PATCH v3 2/3] firmware: add exynos ACPM protocol driver Tudor Ambarus
2024-12-05 23:39 ` Daniel Lezcano [this message]
2024-12-06 13:28 ` Krzysztof Kozlowski
2024-12-06 19:50 ` Daniel Lezcano
2024-12-08 16:38 ` Markuss Broks
2024-12-09 8:29 ` Krzysztof Kozlowski
2024-12-11 12:13 ` Peter Griffin
2024-12-06 6:47 ` Arnd Bergmann
2024-12-06 11:59 ` Tudor Ambarus
2024-12-06 13:02 ` Arnd Bergmann
2024-12-05 17:53 ` [PATCH v3 3/3] MAINTAINERS: add entry for the samsung exynos ACPM mailbox protocol Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce757b8e-4e6c-4ba9-9483-b57e6e230fdf@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javierm@redhat.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®