From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: <linux-snps-arc@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver
Date: Mon, 18 Sep 2017 09:14:38 -0700 [thread overview]
Message-ID: <ce7885ab-b87e-ca07-234f-b63811afd86c@synopsys.com> (raw)
In-Reply-To: <1505736441.9807.8.camel@pengutronix.de>
Hi Philipp,
On 09/18/2017 05:07 AM, Philipp Zabel wrote:
> On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote:
>> ARC AXS10x boards support custom IP-block which allows to control
>> reset signals of selected peripherals. For example DW GMAC, etc...
>> This block is controlled via memory-mapped register (AKA CREG) which
>> represents up-to 32 reset lines. This regiter is self-clearing so we
>> don't need to deassert line after reset.
>>
>> As of today only the following lines are used:
>> - DW GMAC - line 5
>>
>>> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
>> ---
>> Changes v1 -> v2:
>> * The creg reset register is self-clearing so we don't need to clear it
>> manually. Fixed it.
>> * Use reset callback instead of assert/deassert pair.
>> * Rename reset node in documentation to "reset-controller" for consistency
>> with the other bindings.
>> * Use devm_reset_controller_register instead of reset_controller_register
>>
>> NOTE:
>> This driver couldn't be replaced by reset-simple driver as we mustn't
>> read from reset register or clear it.
>
> Thanks, I've applied this patch to the reset/next branch.
Will it be OK for you to apply the corresponding DT update for platform - that way
I don't have to keep track of when ur branch hits mainline etc.
The chances of any ensuing conflicts are pretty rare - and easy to resolve if at all.
If so, Eugeniy can send the patch ur way !
Thx,
-Vineet
next prev parent reply other threads:[~2017-09-18 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 14:28 Eugeniy Paltsev
2017-09-18 12:07 ` Philipp Zabel
2017-09-18 16:14 ` Vineet Gupta [this message]
2017-09-18 16:51 ` Philipp Zabel
2017-10-04 10:09 ` Philipp Zabel
2017-10-04 18:38 ` Vineet Gupta
2017-10-09 18:25 ` Vineet Gupta
2017-10-27 20:57 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce7885ab-b87e-ca07-234f-b63811afd86c@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®