From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 845D27080E for ; Fri, 30 Jan 2026 12:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769774731; cv=none; b=jJd0NaoVSuYQw3ewnZ/AUUm3eQNygXEZlz2qj93oVkgLwmB2eHArQBsMgxR50WvoY4PeeSAnJS4CJo+wWG+ORevetPibh6C4GGppdnDKjSYx0rg+Nt2HkcqEnzODQDEasms37yXbo5aZj4Gk9qBEqbrVJh1lp3OlYsd9EnN5YSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769774731; c=relaxed/simple; bh=aFC0zeyoW5t5zvTuMz9rGwaCcw9cyjn7qR7jI7+2euc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ulDMiRKx6juFF9dArNpzshjFtf9FKBasNEnTf2XJ6nrjK5GOLx0VLmeA9/V/3Sa5BOlZB9wj0OlapY6jkCQb7YSmvUTIUc/fj2lYLTffcS8seZJ+KVlE38PsTllW6SWBKkxTkcdvc8WNa5HUqPxpACnoxh8P3IIpATP5XdxitJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Im70CB4y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QsKeXlXm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Im70CB4y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QsKeXlXm" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UBUmxE995889 for ; Fri, 30 Jan 2026 12:05:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZJZ5UjJQNNupcjkDwCIMciIXXm9F7RB7VuIIvWO2KnU=; b=Im70CB4yRaEL9v9N FGrL6W7SgVEDc4q52HBfrqTR75hqdrlKzXlFDjICf+Bk2quEvgABuiiSsG058Aam 1RubjQ8pK8Es+V2/SeQjH7W/lnHc6AzOJCSWJyt9B5hSSd5j8pYw1Oil9ErNshVJ XuLaFXcSnZx7exXoAtdE4VQyNUhFPdL7ZqdkO6J1K2DbxXEemWd0xA3xZe7N3Ai3 jgaEIf1PiKY5uJD+Sas82yIX42x6cfOVd82sDXbYJKoC5diMf/cqMNai3qzIYhm8 JKYSCUZgww6YUYyyMfqFi/lzRYn7UDvqggdtjnwNmtlD/GdzRKCwlJz1Ky7xCXjY KztCtg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0bvvk0f0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 12:05:29 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c52de12a65so41327285a.2 for ; Fri, 30 Jan 2026 04:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769774729; x=1770379529; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZJZ5UjJQNNupcjkDwCIMciIXXm9F7RB7VuIIvWO2KnU=; b=QsKeXlXmS1R7+3ZdU9GpumAAdWSLH0n496f0a9V8AiN5f08FMYpl8AKUMft25hf5aQ 4QVZvVdTG3jClqn0LP4G5RSCc4Ef3DeM76tX6zCHz323+EybCRSK3X90T50wFqC/QvBa beFaKHH9jg9z7uxSy8IrVJDOhIIb5GC9MNPfy83BWN/Z7x75c5pOmb3bjiQ/HPOAT8IC OyCysDFj8XSrekaQiHyfxjIg1NStvAhsCkXWLCDcnY55HE/oN9yW9kHAeODpCMUGR5dy 6CBYaREQ+eGRbZIUfIUrktFtlxPtGScY4ZyxoheFBFW5h7isAxkhUVRemRkLlMOG1C9F RGLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769774729; x=1770379529; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZJZ5UjJQNNupcjkDwCIMciIXXm9F7RB7VuIIvWO2KnU=; b=cVNwAoXqmqSJ7a3MPEgir9pjSOvE0wugGCeqdl1mmLab3E2RniVDn/oaKrRHL8erM3 r9AeCM8C9yhXYonMj5eT2MKWSJizW/SNq2nxVEJHPTsTVtSAtEMMIgUNgB9YEiLBx73Y 0Ddvndoq1uKBs2dk90KW5igEvQrYLp7J60xFT2Wzqw0UAFrt29zOljn5XIzN7fwscFCl ysddZuDDK20VsWF4bCmg1CHkxXf1BOk5g4FoiWytAyC0eiMszzAu+/ZhBba9fYz1Rr5h SkzoMOvDB0D0iQD+MtAVk0f1lvcGQBhofrz+Nst9U0En7ba7Dnw7I7BufnrVIEMjngCQ qQyg== X-Forwarded-Encrypted: i=1; AJvYcCVJrW7FbSJfZSKso9L2Eg2stLWp1tAxt5UkQWEgA8sIzebqD8fBjzfSGdAMetIaPwDCMHeB8O/9W8sA1Lg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+WayXdMSCEA+xwBolJpRXLVLnf360e/IdTYSK+b3UCYspMA8p e1dIG4f025lh0epyTEbpUnS89FYojea7YUKIyhm1GJoXOhQsKCRj83vNrebea2y9p7q4ZR6gx1p ZnI8MnombZ4lHdBycpjzOh9gJ8NkTjuoTYQnWKXPMZeLus3LoeeITfCx9IHpKgFhCnco= X-Gm-Gg: AZuq6aKMjzOdR0d3eL9gDzbzGRoOSzKYoebnSkhyfbaSIzrqtlrdrsRrSWFV0jmo3gp kBKnmxX+55gz9bWOu46sFbe5/rw6blWuObuBsDjSgocd6rYJZDpoOmZJNHFfnBdpFQOrYisPWZU 3dWqTGsbV+lC8YrW0GL2EkaClv4uytPip9lS5f99t+1Xl2vPMuN6Y6NWnN7pwc2VClmC9NmVHxE orqs64l37P+mZ1kny+EoL5kvl6Bo7XhMERC6cqPlsNczjEZPrAQrEZlWnV4eLFg/lu9ih5VabPi a4f4t8gfkKpb+vYXnrMW5vxT00mHxH7j5Pi0xRGl4uE8kmg3fpFqTKBJ5hUjvrSIYw+SrEWWbdL 9jYRzOf9Y2riSqvV48Oo8sgGRWkNYQT15eW43ZlWcC193gceocZvXDnsiSbGDw8kHIIc= X-Received: by 2002:a05:620a:1a18:b0:8c6:f7ad:49b with SMTP id af79cd13be357-8c9eb29d0b9mr291470985a.5.1769774728830; Fri, 30 Jan 2026 04:05:28 -0800 (PST) X-Received: by 2002:a05:620a:1a18:b0:8c6:f7ad:49b with SMTP id af79cd13be357-8c9eb29d0b9mr291467585a.5.1769774728347; Fri, 30 Jan 2026 04:05:28 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38625fbff42sm15630051fa.45.2026.01.30.04.05.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 04:05:27 -0800 (PST) Message-ID: Date: Fri, 30 Jan 2026 13:05:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/12] i2c: qcom-geni: Use resources helper APIs in runtime PM functions To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com References: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> <20260112104722.591521-11-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260112104722.591521-11-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ZdEQ98VA c=1 sm=1 tr=0 ts=697c9e89 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=gzD-2WDeCj_JQFVUwcoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: FPZd54HJotODEVfZxt5ZrbMvCYMqHodw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA5OCBTYWx0ZWRfX1Ke6Ogna0zTz CRoAA1xzc9gyqNZEyB+hzW9T3+Ww6qaTCHY5Mq30g0eVbFM5wMNaJjzEvSQTwuxVXjytdVXWIlB Sa9vGYdT/fCsXb47PH5Agtr8TFBAbRsmvpgbDCKa9FTNzCTDw5bDwOXQKd2dpz1OJuEUul/3IoG zjYDN3i5D7MmnqsS6fk15/oKM5RW4c0WBIPyEjTTXrOZVZ4NOcdb2jW5En0uyjtObtNEeKRs2Gi GXxqXoBif7Ynb0Y4lCeV7LfbD/Q0Ya3ISXeHAy7dcPSwkZmmw8zsQMeujhJEwMlqDGOORbOEIFy woEtyGvNcpeRBs05Y9gvXpPZngSm/iVos0cTT8c8rK/IjroHrP6HdWjdpbTlXDOdDBDuTz+NyDV dy1QTp7RTcyNy0nG/+/qjtwS19+PbawFnwi8aCrPtrYkxOQGSbos5tOsI0wtFv/ufAPtio7UYCx erm7OVQAE5g4NMxf0Nw== X-Proofpoint-ORIG-GUID: FPZd54HJotODEVfZxt5ZrbMvCYMqHodw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_01,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300098 On 1/12/26 11:47 AM, Praveen Talari wrote: > To manage GENI serial engine resources during runtime power management, > drivers currently need to call functions for ICC, clock, and > SE resource operations in both suspend and resume paths, resulting in > code duplication across drivers. > > The new geni_se_resources_activate() and geni_se_resources_deactivate() > helper APIs addresses this issue by providing a streamlined method to > enable or disable all resources based, thereby eliminating redundancy > across drivers. > > Signed-off-by: Praveen Talari > --- > v1->v2: > Bjorn: > - Remove geni_se_resources_state() API. > - Used geni_se_resources_activate() and geni_se_resources_deactivate() > to enable/disable resources. > --- > drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- > 1 file changed, 5 insertions(+), 23 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index a4b13022e508..b0a18e3d57d9 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > > disable_irq(gi2c->irq); > - ret = geni_se_resources_off(&gi2c->se); > + > + ret = geni_se_resources_deactivate(&gi2c->se); This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state vote, but the other function doesn't have a counterpart to bring it back Konrad