From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B9063AB266 for ; Tue, 10 Mar 2026 13:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148251; cv=none; b=aR0weRF0vlbWNmCM+I7YXLR0EDaaw3erDgKnruRRCl8L1gzbCb77WOt0hNXRyYkTfYpeQw6jKqRX5NTayrCgyop7CyEn9cvNRbVHXq2LQV5S2HkB/a0LkgSvfLwdg6d1o9nJfxa/Y2bPV8tmGgfAwzWGKA0mss2bKnPE09ctbDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148251; c=relaxed/simple; bh=kzYj1smeRMItgaxayq5+Qo4qBPCOccMkqmYUY8Pe74k=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=AQhZv9gLhJKAhmIpD8T5DBKc790OdZBQWRe2o18NMW6p8qUcaO1iiKmpkvDAI/RiOTD8nrqhJZ0qF3+1NKybl5c7uaauNUIcaZPpVSSJLg6G568FTQoJxzKyUtZzqadj+q7XGUATajrgKf/ZM/J7Ah4hQDDs8Rb7X7MmOrOM9r0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WYQEtWG1; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WYQEtWG1" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439b2965d4bso7577001f8f.2 for ; Tue, 10 Mar 2026 06:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773148247; x=1773753047; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=l1o+IQic08swNsyDecJjP9NKjUSHetXVHGL8XW5lwnM=; b=WYQEtWG1BLAOe2bwghlbKMC54FhaYiizb/8A0KJhLeEgWy7vVBibh1ge70oZDpYSbb qSTRCee2sHbGlwab8e3rt3wrRnUaLW1QD3fQJ2cDebImeJeGP3OCEXLkcjHhM4fkuCma jT1x/7UMoWvx3/JAB3iy5D6Jxz/lhGokSYROxGNvU1LbqX1oxn4S8qPsz+rsCvhnTUIL ajdJpEfqqSYroXSWieHg5BHjTmc8a2jgOiG3ErRo5a6Zxjn/1Jh7iDlvDwH9Ehmo/OgA OHEyzatasPVG2Ju0zKSCzu2C6Ejb2lNjSZufcfz/hcS0+kGOFXu9UvV7rOuIF3H5C+To xPcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773148247; x=1773753047; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1o+IQic08swNsyDecJjP9NKjUSHetXVHGL8XW5lwnM=; b=mcJVolnKK+zHt1f2pqz8VFCPnLzUo2eKWk4gESCJdguhi/rkLcBSOi0XxewrxCdlzs O757g27VFRb7e79abD377X4UFChkwvj0PVGjM3DR6x8CRlLC+MppeHR5f1XTfXOMx3xV qsCd+6RK9P0AxFw7AITxW5HMLTA7ayr0ngUJobhurrUTugQDfF38KyOKRcvAaS0fmJNv PGgj7tioulSuaRkeZCG8bg4KZCDauxjvnyFH2sQGoaF5QtV4N10gZNUS12zPpngRWQX5 5ZQgfA0gX5zc+a/uxwcbW6qRh13yp1vuQ8nJQzAb3LVsH2zZN8vg0Irip1XXPY0PP08q mWug== X-Forwarded-Encrypted: i=1; AJvYcCX+LiDTi9KHD1YNh/r8XmN/2vD8uQ7EL+9MU6q3f+ag4z1nZC/IRR+sslv9n9/qQBDVlQXrAFAKRifBzG0=@vger.kernel.org X-Gm-Message-State: AOJu0YwSt2YPVWDCK2LoUgg3RvoXXGPW6fZi6+5fdnA7iRKbLlzLaaim pE9YcE9ehyTf/koR/uN7umVAPJFS8o0VYAUCpa1q2MuE+1ILz+NsIMcNcirttyvlJgs= X-Gm-Gg: ATEYQzzMLuYbB54iJcD/jZsTVWxPXez4BJtGgVKVynk2j4iIFbI/5MKDI8EYOTAvii8 ByennpujM6rVCOqHKREWPMT7gU3bbe9AohHmHgLBMdXBC86Vgui4jbElqySsZQX6qMvmOCbDLso BGy7RTjw2iAA9jIpYub8nMMUbJcShI+b5yrMzbB9BQQimi3pisfdHnIY+sYXjUGpozTjqnKm+7J OJayhBotjAPvPeDlE8LOTadBzWPVANM7zNyw9vCSZsRnXmAvL/FmDjq7qwdth2FXn5o7JCcpG+t ILAW2Hj9eTGYaq9pi1dWPp08nkO67NtRhslUKgPbRUk81XoFU7tGGu64UIaZLmISWwbt7Q+XYaE UllYeixyX2vi9IuEgVabZrrHF7uWRhMyf2opg/mupwvB73axvgXsHwmQBIfifzY7LbUjgdCkvQh OWFL6nv40NGIgSAD5KformzKmLOFODcBeNfeJGe+OnksxIRWFcc9Ps29nOb96aROEmkZvZF/6yP ACg X-Received: by 2002:a05:6000:2285:b0:432:5c34:fb32 with SMTP id ffacd0b85a97d-439da35c729mr25625557f8f.23.1773148247153; Tue, 10 Mar 2026 06:10:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:4d81:e92:c4c0:3c45? ([2a01:e0a:106d:1080:4d81:e92:c4c0:3c45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dadb85b8sm36640819f8f.17.2026.03.10.06.10.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 06:10:46 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 14:10:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/4] drm/panel: ilitek-ili9806e: split core and DSI logic To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Michael Walle , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20260114161636.1076706-1-dario.binacchi@amarulasolutions.com> <20260114161636.1076706-3-dario.binacchi@amarulasolutions.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260114161636.1076706-3-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/26 17:16, Dario Binacchi wrote: > Split the driver to support multiple transport buses. The core logic > (power, GPIO, backlight) is moved to a dedicated core module, while > DSI-specific code is restricted to the DSI module. > > Introduce DRM_PANEL_ILITEK_ILI9806E_CORE as a hidden Kconfig symbol > selected by the bus-specific configuration. > > Signed-off-by: Dario Binacchi > --- > > (no changes since v1) > > MAINTAINERS | 2 +- > drivers/gpu/drm/panel/Kconfig | 8 +- > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-ilitek-ili9806e-core.c | 129 +++++++++++++++ > .../drm/panel/panel-ilitek-ili9806e-core.h | 15 ++ > .../gpu/drm/panel/panel-ilitek-ili9806e-dsi.c | 151 +++++------------- > 6 files changed, 195 insertions(+), 111 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 317e76cc99e5..67117d8cf483 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7913,7 +7913,7 @@ F: drivers/gpu/drm/panel/panel-ilitek-ili9805.c > DRM DRIVER FOR ILITEK ILI9806E PANELS > M: Michael Walle > S: Maintained > -F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c > +F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-* > > DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS > M: Jagan Teki > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 692cd474910d..333e981eda96 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -257,11 +257,15 @@ config DRM_PANEL_ILITEK_ILI9805 > Say Y if you want to enable support for panels based on the > Ilitek ILI9805 controller. > > +config DRM_PANEL_ILITEK_ILI9806E_CORE > + tristate > + depends on OF > + depends on BACKLIGHT_CLASS_DEVICE > + > config DRM_PANEL_ILITEK_ILI9806E_DSI > tristate "Ilitek ILI9806E-based DSI panels" > - depends on OF > depends on DRM_MIPI_DSI > - depends on BACKLIGHT_CLASS_DEVICE > + select DRM_PANEL_ILITEK_ILI9806E_CORE > help > Say Y if you want to enable support for panels based on the > Ilitek ILI9806E controller using DSI. > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index 00071a983242..13034cadb8d8 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o > obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o > +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_CORE) += panel-ilitek-ili9806e-core.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_DSI) += panel-ilitek-ili9806e-dsi.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9882T) += panel-ilitek-ili9882t.o > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > new file mode 100644 > index 000000000000..c088685d9d85 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > @@ -0,0 +1,129 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Ilitek ILI9806E core driver. > + * > + * Copyright (c) 2026 Amarula Solutions, Dario Binacchi > + */ > + > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "panel-ilitek-ili9806e-core.h" > + > +struct ili9806e { > + void *transport; > + struct drm_panel panel; > + > + struct regulator_bulk_data supplies[2]; > + struct gpio_desc *reset_gpio; > +}; > + > +static const char * const regulator_names[] = { > + "vdd", > + "vccio", > +}; > + > +void *ili9806e_get_transport(struct drm_panel *panel) > +{ > + struct ili9806e *ctx = container_of(panel, struct ili9806e, panel); > + > + return ctx->transport; > +} > +EXPORT_SYMBOL_GPL(ili9806e_get_transport); > + > +int ili9806e_power_on(struct device *dev) > +{ > + struct ili9806e *ctx = dev_get_drvdata(dev); > + int ret; > + > + gpiod_set_value(ctx->reset_gpio, 1); > + > + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + if (ret) { > + dev_err(dev, "regulator bulk enable failed: %d\n", ret); > + return ret; > + } > + > + usleep_range(10000, 20000); > + gpiod_set_value(ctx->reset_gpio, 0); > + usleep_range(10000, 20000); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(ili9806e_power_on); > + > +int ili9806e_power_off(struct device *dev) > +{ > + struct ili9806e *ctx = dev_get_drvdata(dev); > + int ret; > + > + gpiod_set_value(ctx->reset_gpio, 1); > + > + ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + if (ret) > + dev_err(dev, "regulator bulk disable failed: %d\n", ret); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(ili9806e_power_off); > + > +int ili9806e_probe(struct device *dev, void *transport, > + const struct drm_panel_funcs *funcs, > + int connector_type) > +{ > + struct ili9806e *ctx; > + int i, ret; > + > + ctx = devm_kzalloc(dev, sizeof(struct ili9806e), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + dev_set_drvdata(dev, ctx); > + ctx->transport = transport; > + > + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) > + ctx->supplies[i].supply = regulator_names[i]; > + > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), > + ctx->supplies); > + if (ret) > + return dev_err_probe(dev, ret, "failed to get regulators\n"); > + > + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), > + "Failed to get reset-gpios\n"); > + > + drm_panel_init(&ctx->panel, dev, funcs, connector_type); > + > + ret = drm_panel_of_backlight(&ctx->panel); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to get backlight\n"); > + > + ctx->panel.prepare_prev_first = true; > + drm_panel_add(&ctx->panel); > + > + return 0; > + > +} > +EXPORT_SYMBOL_GPL(ili9806e_probe); > + > +void ili9806e_remove(struct device *dev) > +{ > + struct ili9806e *ctx = dev_get_drvdata(dev); > + > + drm_panel_remove(&ctx->panel); > +} > +EXPORT_SYMBOL_GPL(ili9806e_remove); > + > +MODULE_AUTHOR("Dario Binacchi "); > +MODULE_AUTHOR("Gunnar Dibbern "); > +MODULE_AUTHOR("Michael Walle "); > +MODULE_DESCRIPTION("Ilitek ILI9806E Controller Driver"); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h > new file mode 100644 > index 000000000000..dddece62cf42 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _PANEL_ILITEK_ILI9806E_CORE_H > +#define _PANEL_ILITEK_ILI9806E_CORE_H > + > +void *ili9806e_get_transport(struct drm_panel *panel); > +int ili9806e_power_off(struct device *dev); > +int ili9806e_power_on(struct device *dev); > + > +int ili9806e_probe(struct device *dev, void *transport, > + const struct drm_panel_funcs *funcs, > + int connector_type); > +void ili9806e_remove(struct device *dev); > + > +#endif /* _PANEL_ILITEK_ILI9806E_CORE_H */ > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c > index c337c4f1a1c7..ecdbed8d4a3a 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c > @@ -1,15 +1,12 @@ > // SPDX-License-Identifier: GPL-2.0 > > -#include > #include > #include > #include > -#include > #include > #include > #include > #include > -#include > > #include > #include > @@ -18,7 +15,9 @@ > > #include