Re: [PATCH v4 4/7] net: stmmac: dwmac-meson8b: follow the generic RGMII delay rules on the T7

[Andrew Lunn <andrew@lunn.ch>]

> +/*
> + * Delay handling of the SoCs up to the G12A. It reads phy-mode as the
> + * list of delays this glue has to add, falls back to a 2ns TX delay and
> + * takes the vendor delay properties, all of which ethernet-controller.yaml
> + * rules out. The boards in the tree depend on it, so it stays, but a new
> + * SoC must not use it.
> + */
>  static int meson8b_init_rgmii_delays(struct meson8b_dwmac *dwmac)
>  {
>  	u32 tx_dly_config, rx_adj_config, cfg_rxclk_dly, delay_config;
> +	struct device_node *np = dwmac->dev->of_node;
> +	u32 tx_delay_ns, rx_delay_ps = 0;
>  	int ret;

Does this code need to change?

It would be better if you did not need to change the old code, so you
don't need to worry about breaking other SoCs. Just don't call it for
the T7, use you new function in its place.

	Andrew