mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Juergen Gross <jgross@suse.com>
Subject: [PATCH v4 3/4] objtool: Stop UNRET validation on UD2
Date: Tue,  8 Apr 2025 00:02:15 -0700	[thread overview]
Message-ID: <ce841269e7e28c8b7f32064464a9821034d724ff.1744095216.git.jpoimboe@kernel.org> (raw)
In-Reply-To: <cover.1744095216.git.jpoimboe@kernel.org>

In preparation for simplifying INSN_SYSCALL, make validate_unret()
terminate control flow on UD2 just like validate_branch() already does.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
 tools/objtool/check.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 2c703b960420..2dd89b0f4d5e 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -3902,6 +3902,9 @@ static int validate_unret(struct objtool_file *file, struct instruction *insn)
 			break;
 		}
 
+		if (insn->dead_end)
+			return 0;
+
 		if (!next) {
 			WARN_INSN(insn, "teh end!");
 			return 1;
-- 
2.49.0


  parent reply	other threads:[~2025-04-08  7:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08  7:02 [PATCH v4 0/4] objtool: Fix INSN_CONTEXT_SWITCH Josh Poimboeuf
2025-04-08  7:02 ` [PATCH v4 1/4] objtool: Fix INSN_CONTEXT_SWITCH handling in validate_unret() Josh Poimboeuf
2025-04-08  8:12   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-08  7:02 ` [PATCH v4 2/4] objtool: Split INSN_CONTEXT_SWITCH into INSN_SYSCALL and INSN_SYSRET Josh Poimboeuf
2025-04-08  8:12   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-08  7:02 ` Josh Poimboeuf [this message]
2025-04-08  8:12   ` [tip: objtool/urgent] objtool: Stop UNRET validation on UD2 tip-bot2 for Josh Poimboeuf
2025-04-08  7:02 ` [PATCH v4 4/4] objtool, xen: Fix INSN_SYSCALL / INSN_SYSRET semantics Josh Poimboeuf
2025-04-08  8:12   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-08  7:11 ` [PATCH v4 0/4] objtool: Fix INSN_CONTEXT_SWITCH Ingo Molnar
2025-04-08  7:15   ` Ingo Molnar
2025-04-09 14:43 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce841269e7e28c8b7f32064464a9821034d724ff.1744095216.git.jpoimboe@kernel.org \
    --to=jpoimboe@kernel.org \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®