mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Daehyeon Ko <4ncienth@gmail.com>
Cc: muchun.song@linux.dev, osalvador@suse.de, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlb: retry private VMA locking when unmapping folios
Date: Tue, 20 Oct 2026 12:57:46 +0200	[thread overview]
Message-ID: <ce848b62-02f0-4b34-95e6-d30416e20336@kernel.org> (raw)
In-Reply-To: <20261020102012.1775940-1-4ncienth@gmail.com>

On 10/20/26 12:20, Daehyeon Ko wrote:
> Hi David,
> 
> Yes, that makes sense.
> 
> The per-index fault mutex excludes concurrent faults for the folio being
> removed, while i_mmap_rwsem keeps the VMA in the mapping tree and excludes
> concurrent page-table teardown.  So the private resv_map lock is not needed
> in this path.
> 
> I tested the exact diff from your message on v7.3-rc5 with KASAN+LOCKDEP.
> My unprivileged mprotect()/hole-punch reproducer completed 1,000 rounds
> (64,000 hole punches) with no KASAN, lockdep, unexpected warning, oops, or
> panic.
> 
> Please consider my patch superseded by Josef's fix.
> 
> One small typo in the quoted comment: "i_mmap_rwsem everybody" appears to
> be missing "excludes".
> 
> The quoted commit also predates the current linux-next policy change:
> `Assisted-by` is no longer a recognized trailer.  `generated-content.rst`
> asks that tool-assisted discovery be stated in the changelog prose instead.
> 
> Tested-by: Daehyeon Ko <4ncienth@gmail.com>

Can you overhaul (shorten etc) the patch description and send it out for proper
review?

-- 
Cheers,

David

      reply	other threads:[~2026-10-20 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 17:05 Daehyeon Ko
2026-10-20  8:47 ` David Hildenbrand (Arm)
2026-10-20 10:20   ` Daehyeon Ko
2026-10-20 10:57     ` David Hildenbrand (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce848b62-02f0-4b34-95e6-d30416e20336@kernel.org \
    --to=david@kernel.org \
    --cc=4ncienth@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®