mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Simon Richter" <Simon.Richter@hogyros.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Venkat Rao Bagalkote" <venkat88@linux.ibm.com>
Subject: Re: [PATCH v2] misc/nvram: only declare mutex where it's used
Date: Sun, 03 May 2026 10:19:36 +0200	[thread overview]
Message-ID: <ce87315e-c4f3-4780-945a-b8e13b327509@app.fastmail.com> (raw)
In-Reply-To: <20260503074840.609833-1-Simon.Richter@hogyros.de>

On Sun, May 3, 2026, at 09:47, Simon Richter wrote:
> The ioctls using this are platform specific compatibility code. On other
> platforms, this generates a warning for an unused static variable.
>
> Fixes: 20e07af71f34d ("powerpc: Adopt nvram module for PPC64")
> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> ---
>  drivers/char/nvram.c | 3 +++
>  1 file changed, 3 insertions(+)

I think the better fix is "[PATCH v5] char/nvram: Remove redundant
nvram_mutex", see

https://lore.kernel.org/all/20260428061540.73668-1-venkat88@linux.ibm.com/

      Arnd

      parent reply	other threads:[~2026-05-03  8:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03  6:46 [PATCH] " Simon Richter
2026-05-03  6:53 ` Greg Kroah-Hartman
2026-05-03  7:45   ` Simon Richter
2026-05-03  7:47     ` [PATCH v2] " Simon Richter
2026-05-03  8:19       ` Greg Kroah-Hartman
2026-05-03  9:15         ` Simon Richter
2026-05-03  8:19       ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce87315e-c4f3-4780-945a-b8e13b327509@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Simon.Richter@hogyros.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®