mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: Re: [PATCH net v2] net: dsa: b53: bcm531x5: fix cpu rgmii mode interpretation
Date: Fri, 7 Nov 2025 14:20:24 +0100	[thread overview]
Message-ID: <ce95eb8c-0d40-464d-b729-80e1ea71051c@lunn.ch> (raw)
In-Reply-To: <20251107083006.44604-1-jonas.gorski@gmail.com>

> +	/* Older driver versions incorrectly applied delays in
> +	 * PHY_INTERFACE_MODE_RGMII mode. In order to not break old users, keep
> +	 * interpreting RGMII as RGMII-ID.
> +	 */
> +	if (interface == PHY_INTERFACE_MODE_RGMII)
> +		interface = PHY_INTERFACE_MODE_RGMII_ID;

Did you look through the in kernel .dts files? How many systems does
this effect?

I would maybe add a dev_warn() here, saying the DT blob is out of date
and needs fixing. And fix all the in kernel .dts files.

	Andrew

  reply	other threads:[~2025-11-07 13:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  8:30 Jonas Gorski
2025-11-07 13:20 ` Andrew Lunn [this message]
2025-11-07 13:52   ` Jonas Gorski
2025-11-07 14:07     ` Andrew Lunn
2025-11-07 14:45       ` Vladimir Oltean
2025-11-07 15:33         ` Russell King (Oracle)
2025-11-08 11:31           ` Jonas Gorski
2025-11-08  0:38 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce95eb8c-0d40-464d-b729-80e1ea71051c@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=jonas.gorski@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®