From: Roger Quadros <rogerq@ti.com>
To: William Wu <william.wu@rock-chips.com>, <gregkh@linuxfoundation.org>
Cc: <heiko@sntech.de>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-rockchip@lists.infradead.org>,
<frank.wang@rock-chips.com>, <huangtao@rock-chips.com>,
<dianders@google.com>, <groeck@google.com>,
<stern@rowland.harvard.edu>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] usb: host: xhci: plat: check hcc_params after add hcd
Date: Tue, 17 Jan 2017 11:05:33 +0200 [thread overview]
Message-ID: <ce986277-7585-2fb4-4b3d-4fa3833b152f@ti.com> (raw)
In-Reply-To: <1484638327-9686-1-git-send-email-william.wu@rock-chips.com>
On 17/01/17 09:32, William Wu wrote:
> From: William wu <william.wu@rock-chips.com>
>
> The commit 4ac53087d6d4 ("usb: xhci: plat: Create both
> HCDs before adding them") move add hcd to the end of
> probe, this cause hcc_params uninitiated, because xHCI
> driver sets hcc_params in xhci_gen_setup() called from
> usb_add_hcd().
>
> This patch checks the Maximum Primary Stream Array Size
> in the hcc_params register after add primary hcd.
>
> Signed-off-by: William wu <william.wu@rock-chips.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/usb/host/xhci-plat.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index ddfab30..f96caeb 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -232,9 +232,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (device_property_read_bool(&pdev->dev, "usb3-lpm-capable"))
> xhci->quirks |= XHCI_LPM_SUPPORT;
>
> - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> - xhci->shared_hcd->can_do_streams = 1;
> -
> hcd->usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0);
> if (IS_ERR(hcd->usb_phy)) {
> ret = PTR_ERR(hcd->usb_phy);
> @@ -251,6 +248,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (ret)
> goto disable_usb_phy;
>
> + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> + xhci->shared_hcd->can_do_streams = 1;
> +
> ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> if (ret)
> goto dealloc_usb2_hcd;
>
--
cheers,
-roger
prev parent reply other threads:[~2017-01-17 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 7:32 William Wu
2017-01-17 9:05 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce986277-7585-2fb4-4b3d-4fa3833b152f@ti.com \
--to=rogerq@ti.com \
--cc=dianders@google.com \
--cc=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®