From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FBEFC433E6 for ; Thu, 11 Feb 2021 09:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ADDE61493 for ; Thu, 11 Feb 2021 09:03:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbhBKJCh (ORCPT ); Thu, 11 Feb 2021 04:02:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49072 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbhBKI6M (ORCPT ); Thu, 11 Feb 2021 03:58:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613033892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GUxj7277CqOjx0CBHzOaHRlV6qbv/MC2NWGltcghRDE=; b=VDv/y+gN0F7Yx6NWSKtWQ4r8Go+osq7G0qsd9RkZIEslBHiuQlAwmq4+fO4tGPmRQ4ZpzK z+6tt6eYrQzYpxAoaNlONWTWMK7nDysnFlXb9QarVJ3s+v2pfqTuaTUbJJDSnwJ7sgO3XI o/Zn0GGUo3zAuasFttLXPqQ5HHsBAV0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-XABQDFcBP7iP53Rcjhw06g-1; Thu, 11 Feb 2021 03:58:10 -0500 X-MC-Unique: XABQDFcBP7iP53Rcjhw06g-1 Received: by mail-wm1-f71.google.com with SMTP id t128so2211957wmg.4 for ; Thu, 11 Feb 2021 00:58:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GUxj7277CqOjx0CBHzOaHRlV6qbv/MC2NWGltcghRDE=; b=sW71bpy7p9+mr3ZWuNCFPjFPjhaxaHNnYZNL1ql+Wr4kO4AJGn0z7pSon7TQ4CGR44 6hc2TMM0k/xSlLg/l/MIX/5jTJ3j4B7hUHJJHY868ceszUkHCgoUSGiMpIGaP+JM6Yxw YTYvcjy/5pldUJD+bwImDjisu2p9L9i3U8HjuTVaCDnXtPtxfVEboZsLSTSfpnxOgW5x qDd6+vyRR83RBgZorK4C+yTVIz6GFVtrOwqUo7n2ATDNKCLrlKuzvgOnftLD7nOwYAiA IbJcEmS4aCM0WuZyVN/d9BA/PgnR5/nLb77dIjh26zjXisxLcy+JzxllNx/3+hjAPaDL x4Hg== X-Gm-Message-State: AOAM53283qpA3+O5modh7L3uRL+WvuhIFa4E4SfVdG49ztFIy+I+R2GA t3ljEbshNSNt9mnC7plv+O466qESaJEVs+qyWCEh2d0cDdINKBypnmsQLXMr/t24U8U+UIbVJb3 1QbwZdoRsCYuqv87eG2t+7/Sz X-Received: by 2002:a05:600c:4ec6:: with SMTP id g6mr4100355wmq.2.1613033888840; Thu, 11 Feb 2021 00:58:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJyK1/8aVu2WYOl7zLZ5yMObIdtUFQQl74YoKXEmxfZLkmUMMpqDzTqh0qEx/atPIppVPOvBZA== X-Received: by 2002:a05:600c:4ec6:: with SMTP id g6mr4100340wmq.2.1613033888693; Thu, 11 Feb 2021 00:58:08 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id o124sm8905080wmo.41.2021.02.11.00.58.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Feb 2021 00:58:07 -0800 (PST) Subject: Re: [RESEND PATCH ] KVM: VMX: Enable/disable PML when dirty logging gets enabled/disabled To: Sean Christopherson , Makarand Sonare Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pshier@google.com, jmattson@google.com, Ben Gardon References: <20210210212308.2219465-1-makarandsonare@google.com> From: Paolo Bonzini Message-ID: Date: Thu, 11 Feb 2021 09:58:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/21 03:07, Sean Christopherson wrote: >> Tested: >> kvm-unit-tests >> dirty_log_test >> dirty_log_perf_test > Eh, I get that we like these for internal tracking, but for upstream there's an > assumption that you did your due diligence. If there's something noteworthy > about your testing (or lack thereof), throw it in the cover letter or in the > part that's not recorded in the final commit. > I actually don't mind it and I should do it myself as well. Sure for large series it's better to put it just once in the cover letter, but for small submissions such as this one it's not a problem. Paolo