From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] f2fs: assign REQ_RAHEAD to bio for ->readpages
Date: Fri, 22 Jun 2018 15:38:41 +0800 [thread overview]
Message-ID: <ce9fb180-2458-4c50-9cee-cfe1bfc3a201@huawei.com> (raw)
In-Reply-To: <20180621193213.86850-1-jaegeuk@kernel.org>
On 2018/6/22 3:32, Jaegeuk Kim wrote:
> As Jens reported, we'd better assign REQ_RAHEAD to bio by the fact that
> ->readpages is called only from read-ahead.
>
> In Documentation/filesystems/vfs.txt,
>
> readpages: called by the VM to read pages associated with the address_space
> object. This is essentially just a vector version of
> readpage. Instead of just one page, several pages are
> requested.
> readpages is only used for read-ahead, so read errors are
> ignored. If anything goes wrong, feel free to give up.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
prev parent reply other threads:[~2018-06-22 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 19:32 Jaegeuk Kim
2018-06-22 7:38 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce9fb180-2458-4c50-9cee-cfe1bfc3a201@huawei.com \
--to=yuchao0@huawei.com \
--cc=axboe@kernel.dk \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®