From: Valentin Schneider <valentin.schneider@arm.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Do not re-read h_load_next during hierarchical load calculation
Date: Tue, 19 Mar 2019 12:36:04 +0000 [thread overview]
Message-ID: <cea29ed4-5ad0-7799-f421-9bd2a4a3fba3@arm.com> (raw)
In-Reply-To: <20190319123047.3qlpejilrms5ckad@techsingularity.net>
On 19/03/2019 12:30, Mel Gorman wrote:
[...]
>>
>> Does that also want a
>>
>> Fixes: 685207963be9 ("sched: Move h_load calculation to task_h_load()")
>> Cc: stable@vger.kernel.org
>>
>> ?
>>
>> Other than that, the change looks sane to me.
>>
>> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
>>
>
> Thanks. I'll add the Fixes because it does look like the old code would
> have been ok. Thanks for the review!
>
Well it's not worth much because I completely skipped that we *didn't*
already have a WRITE_ONCE(), which you do need as Peter mentioned. But I
do think stable will be happy to get this one :)
next prev parent reply other threads:[~2019-03-19 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 9:35 Mel Gorman
2019-03-19 11:38 ` Valentin Schneider
2019-03-19 12:30 ` Mel Gorman
2019-03-19 12:36 ` Valentin Schneider [this message]
2019-03-19 12:06 ` Peter Zijlstra
2019-03-19 12:33 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cea29ed4-5ad0-7799-f421-9bd2a4a3fba3@arm.com \
--to=valentin.schneider@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®