From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Jon Cargille <jcargill@google.com>,
David Matlack <dmatlack@google.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
kvm list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kvm: add capability for halt polling
Date: Thu, 23 Apr 2020 15:09:50 +0200 [thread overview]
Message-ID: <cea84a43-e400-54b9-a6bc-3ad834c17880@redhat.com> (raw)
In-Reply-To: <CALMp9eREdS=nfdtvfNhW87G20Tfdwy69Phdbdmo=NzAw_tavzw@mail.gmail.com>
On 22/04/20 23:36, Jim Mattson wrote:
>>> + case KVM_CAP_HALT_POLL: {
>>> + if (cap->flags || cap->args[0] != (unsigned int)cap->args[0])
>>> + return -EINVAL;
>>> +
>>> + kvm->max_halt_poll_ns = cap->args[0];
>> Is it safe to allow any value from userspace here or would it maybe make
>> sense to only allow [0, global halt_poll_ns]?
> Would that restriction help to get this change accepted?
>
No, in the sense that I'm applying it already.
Paolo
prev parent reply other threads:[~2020-04-23 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 22:14 Jon Cargille
2020-04-19 20:46 ` Vitaly Kuznetsov
2020-04-20 18:47 ` Jon Cargille
2020-04-20 21:07 ` Paolo Bonzini
2020-04-20 21:09 ` Paolo Bonzini
2020-04-20 21:20 ` Jon Cargille
2020-04-22 21:36 ` Jim Mattson
2020-04-23 13:09 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cea84a43-e400-54b9-a6bc-3ad834c17880@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dmatlack@google.com \
--cc=hpa@zytor.com \
--cc=jcargill@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®