From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764AbdFWWeX (ORCPT ); Fri, 23 Jun 2017 18:34:23 -0400 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:35362 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbdFWWeW (ORCPT ); Fri, 23 Jun 2017 18:34:22 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug To: Alexandre Belloni Cc: Benjamin Gaignard , john.stultz@linaro.org, tglx@linutronix.de, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, patrice.chotard@st.com, a.zummo@towertech.it, linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com, linaro-kernel@lists.linaro.org, Shuah Khan References: <1497864982-29284-1-git-send-email-benjamin.gaignard@linaro.org> <47b45b70-91da-ce41-535d-89d92f380274@kernel.org> <20170623220907.kxhkwkl6gt7bho5r@piout.net> From: Shuah Khan Message-ID: Date: Fri, 23 Jun 2017 16:34:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170623220907.kxhkwkl6gt7bho5r@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFwJzw2c8Tpf3euS6nsVLag8VyvoWab+K14UANRcGhoVtEgjrs+QFf4SPnC6PDElFzUX21TwLwDXlklNi3mMpAA2WNuuqmEkvJgAUOVDB6SNnuDtcxO2 ug+DYa3noFI+22rIDN0CpvmXvd5Va9CdjLOh4v6Du577ZVwNigXvgW78LIxwQ7OzGD/dliFSq/aonhT5AtUa2T+or6gjUBryUh0bMQ15Yef4EaHAtXQmLloQ yUMhxvIjcDEGxZ2DuGju+F59jxAFtr5LXAe5T2gcoMwDFWEpSmd2gEeq3y5lrYmeE8lT1rOgsnpd7Yh6/UHXrRKuubsZZ2HtP/58LnGnuJS3Ytn0EMQS/msV oqiMvcLGdWoGIriszfz/UIbCyBa2eP5oh4vlZ/940ksoDzoS8kFiRrzun6l/QeOXyKKQrQtjgewYVkO6E15z3ZIAd4jljgWkJhX0XpruPrkwgplU+QE9jsK0 taOMicACLLDzZwe2QkKNZnTXdMjGK+kE6AZCWKMKECpEhMkzFoNkMJGzuY0fkKS0MEyCC+NVtfRoOSXsSVeSjJ3TMkqEMNyBBHbk3jZaggyrMtcnU6JMcGIi r9a7dYOhvPH2mjsCdVO2bAvwVfQnx8hdn8PxqcHr9FqwynmyMT+7j/nUU1vVr7DjiX8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On 06/23/2017 04:09 PM, Alexandre Belloni wrote: > On 23/06/2017 at 13:40:41 -0600, Shuah Khan wrote: >> On 06/19/2017 03:36 AM, Benjamin Gaignard wrote: >>> On 32bits platforms "struct timeval" or "time_t" are using u32 to code the >>> date, this cause tools like "date" or "hwclock" failed even before setting >>> the RTC device if the date is superior to year 2038 (or 2106). >>> >>> To avoid this problem I add one RTC test file which directly use RTC ioctl >>> to set and read RTC time and alarm values. >>> rtctest_setdate allow to set any date/time given in the command line. >>> >>> On this version 2 I add check of problematics years in rtctest like suggest >>> by Alexandre. >>> >>> Finally that had allowed me to test and fix rtc-st-lpc driver. >>> >>> Benjamin Gaignard (3): >>> tools: timer: add rtctest_setdate >>> tool: timer: rtctest add check for problematic dates >>> rtc: st-lpc: make it robust against y2038/2106 bug >>> >>> drivers/rtc/rtc-st-lpc.c | 19 ++-- >>> tools/testing/selftests/timers/Makefile | 2 +- >>> tools/testing/selftests/timers/rtctest.c | 121 ++++++++++++++++++++++- >>> tools/testing/selftests/timers/rtctest_setdate.c | 86 ++++++++++++++++ >>> 4 files changed, 212 insertions(+), 16 deletions(-) >>> create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c >>> >> >> Hi Thomas/John, >> >> I can take the first two patches in this series through linux-kselftest >> with your or John's Ack. Please review and let me know one way or the >> other. >>> > Well, I'm the maintainer for rtctest.c and I'll make sure to also be the > one for rtctest_setdate.c> >> The third one is a rtc driver patch. Please let me know how do you want >> to handle this series soon we can get this into 4.13-rc1. >> > > I'll take the three patches but I still have comment I didn't have time > to give yet. > > Okay. I will drop this off my radar then :) thanks, -- Shuah