From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4AFE31062D for ; Mon, 12 Jan 2026 15:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768232521; cv=none; b=ceK3z1wTU+aX1e59ZOsTz9TKjuB5sAPEd51UvJSdTgm4VynkWkM74tT/biiZ+ABolKTyUsiDb3rNblLrl1xIpfJ7cXqvSNYboQGoM1/XUiC1g4zLcVUDJwlaBPaMSFf5wKQpNfXW3FRADoMX/vsVZdNmWfCN0hHGrJ0GDNp2/+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768232521; c=relaxed/simple; bh=0ixE+47sZp1DnXkk6AGHLM9Dm9yYyGa9dqQnhmIhPVg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uyN3oKvLLxZpYhW6znnat/hMscVvzOa4whbA/qtYG9MoKO32VO4/40QLBDVnSSE/0givAKatjv8pbskmKURPNaoTWnT96jGL9kRobcTqq6q7Jmu4KPWnqAOSHJlObBn51qVCNqbMxpYZHdTYO6rVojOyHsKzBGsAdcpFK/R8TVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org; spf=fail smtp.mailfrom=beagleboard.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b=jjBNwUEt; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b="jjBNwUEt" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7b22ffa2a88so3190309b3a.1 for ; Mon, 12 Jan 2026 07:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1768232519; x=1768837319; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bqhlDu/L75Ix3r8QYS6oa0up7nb4YKhVtDS4khl9pXc=; b=jjBNwUEtRDVApahO6r5CjtaIF+SXfqv0SEksH3Px3eBXrkmHg91iP4lkJ9RQ+iLnOx 6MYTTBJ9DrDrX1e3jzrObCgr/2Aa+rDCLGSoXAt/A8G+sTIjicVzAd07FcX6pJSpBul9 ZRZ0POVpyIXFB0d72kmrhX7LzCFsVDys/6tcOMocczuhU0qOY2oWY89fGGI953P/XByt 38ppsG4noFf1wjBJwITuPRcPSNgbBoUi/8aNIPVzmyLiD9S3JlmdKaZERNh/2fOdv13Z +60yWOPKW4aTFojPtWQl1YeYkq5WNzeG6mycI24TTKkQMk7xHzSX9OnDBIKL+df5Adwk OcJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768232519; x=1768837319; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bqhlDu/L75Ix3r8QYS6oa0up7nb4YKhVtDS4khl9pXc=; b=i8OnvsGoqBzMiANIwvl2SvZQgaBA7k0xyXqpBDQDHaKxlAMfKSPpaHRgvx7PAljMxG kFKTc3xb8Uoy5FdqpBXTjgXKLj/u1hBaDPF+vdMwAADWGfbZsOkr2FR6Ifq3BtEjowil EQ+FxrU0XtiLTTRRdOs3vqr38eCtxVH8d97W2cOljoMPFu3YvZpt3PyBi1QaCHavCLiY 0a+baBqChgYexS+6xPt5fn2bVUyxiOPGfmt1pVbKrrYHcsueqbYPDZ2ylOHwRiQp1BnD zOCTmnVxcyIKOq3vo0r5UZAVVAzEB6X8hEkiWMoTxZEyh3EC6pqc7gCAgdzrjzJ+LqsA YkKg== X-Forwarded-Encrypted: i=1; AJvYcCX48EYmvklSaP10CeuarCQAkontWx/j4UcjJ7txKV/X/jzE7zkoBGCy1g8TeiPst4N9l5loup2GkOxa2d4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0SDOoWtYbQOW3HCw+Xs+KoRAmL7/3+CcRQ0NapABV3N4kqHy5 j5T9m6oqNhRhrQaws8a0Y6FrqE6liQ1TshaIYuF8by5VSUvy5mlcNdFWMce9wePuqQ== X-Gm-Gg: AY/fxX5CpkEtrK75XzD4KYAqPmrcRVZHWUjKr4pQeiHHjAcq0ccTkpylnE5sYw3CuBB vzngzKoYw0L+eoSOEs9mCUGq1/2upSFrfNpcrSpUSN2MJBFBvroNgXYp2GNLlBhJqfj4Kzvvfq1 gaXIX2Wqd1shY5EN3nQkey5arpXrmH4Rajdpz4xIXf+Ml1iKawKFes7P49H7+zh/3+rT0woqPeb 3W7pYkrxUhntYX11+VqZzHwaYlgR0SCap6lS/nhbFAMAoso4JQYKxG2W2Fk5lXLMZnfq17yiLAv oNEc1ZmfZrTqJTAlDRSEEbXbTsdJo1yv9HxcAW+QsGWnQ44WRWWAyzR8DJm+i9kDSX6jYqGqQ82 /iGp4bZFxWDWap0MIQ6/holHQyIkBEQct6SeA4b0jR/2g/JwidScvThUYGei0f5+jNAruD5G4RD VJtZbbYsZRJtRxJ1Uf0niQ2JRxzWEScl8KMIs3AKWD6cqgIfe4clW9un8w0qc72usWjGZDnGmY X-Google-Smtp-Source: AGHT+IHOB4LYJU5QTAG2Ul6rg9vyz3AWxpUuvs8avyxsKiTX32XGDXkc1itlFYqjbE+2xfhlFG+XTw== X-Received: by 2002:a05:6a00:450a:b0:81f:44f9:7c1a with SMTP id d2e1a72fcca58-81f44f98a4fmr5072782b3a.3.1768232519053; Mon, 12 Jan 2026 07:41:59 -0800 (PST) Received: from ?IPV6:2401:4900:1f3f:e311:7179:901d:930c:942? ([2401:4900:1f3f:e311:7179:901d:930c:942]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f43dfd462sm5574405b3a.27.2026.01.12.07.41.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 07:41:58 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2026 21:11:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/77] fdtdump: Change FDT_PROP prob handling to ease future addition To: Herve Codina , David Gibson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Geert Uytterhoeven , devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-spec@vger.kernel.org, Hui Pu , Ian Ray , Luca Ceresoli , Thomas Petazzoni References: <20260112142009.1006236-1-herve.codina@bootlin.com> <20260112142009.1006236-6-herve.codina@bootlin.com> Content-Language: en-US From: Ayush Singh In-Reply-To: <20260112142009.1006236-6-herve.codina@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/12/26 7:48 PM, Herve Codina wrote: > In order to ease future tags addition, perform operation related to > FDT_PROP when the tag is explicitly FDT_PROP instead of relying to a > kind of default value case. > > Handle the FDT_PROP tag exactly in the same way as it is done for > other tags. > > No functional modification. > > Signed-off-by: Herve Codina > --- > fdtdump.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) > > diff --git a/fdtdump.c b/fdtdump.c > index ec25edf..95a2274 100644 > --- a/fdtdump.c > +++ b/fdtdump.c > @@ -129,23 +129,25 @@ static void dump_blob(void *blob, bool debug) > continue; > } > > - if (tag != FDT_PROP) { > - fprintf(stderr, "%*s ** Unknown tag 0x%08"PRIx32"\n", depth * shift, "", tag); > - break; > + if (tag == FDT_PROP) { > + sz = fdt32_to_cpu(GET_CELL(p)); > + s = p_strings + fdt32_to_cpu(GET_CELL(p)); > + if (version < 16 && sz >= 8) > + p = PALIGN(p, 8); > + t = p; > + > + p = PALIGN(p + sz, 4); > + > + dumpf("%04"PRIxPTR": string: %s\n", (uintptr_t)s - blob_off, s); > + dumpf("%04"PRIxPTR": value\n", (uintptr_t)t - blob_off); > + printf("%*s%s", depth * shift, "", s); > + utilfdt_print_data(t, sz); > + printf(";\n"); > + continue; > } > - sz = fdt32_to_cpu(GET_CELL(p)); > - s = p_strings + fdt32_to_cpu(GET_CELL(p)); > - if (version < 16 && sz >= 8) > - p = PALIGN(p, 8); > - t = p; > - > - p = PALIGN(p + sz, 4); > - > - dumpf("%04"PRIxPTR": string: %s\n", (uintptr_t)s - blob_off, s); > - dumpf("%04"PRIxPTR": value\n", (uintptr_t)t - blob_off); > - printf("%*s%s", depth * shift, "", s); > - utilfdt_print_data(t, sz); > - printf(";\n"); > + > + fprintf(stderr, "%*s ** Unknown tag 0x%08"PRIx32"\n", depth * shift, "", tag); > + break; > } > } > This seems reasonable refactor independently from the rest of the patch series. Reviewed-by: Ayush Singh