From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D1628489E for ; Sun, 8 Mar 2026 16:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772988174; cv=none; b=L8E2/xoMG7ZEil7XFyTy5bNdeXQKsMNubYiFJYJ9S1hpwQulWxPqSHEWAO7HBuaI2thpEXaVrCYDDKS502LbsW22ZXbwYWeL/5YSVzEwCos7fKHeJY3+KtRi7JQtZj/uNuHl4hkPXjrA9l4LztHlrmEbJzZdycwBTCtY5obT2lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772988174; c=relaxed/simple; bh=OeH0I8DlVaArA4exlIvdQ30+K74/rg+TRPmWoK5JWtA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=G+aSXAnErD2/PNQFX4Gxf8LLA71JRZYYsC903D+9xuWxPK4FTHwJoDzaC81hMl+nJuNHWAsQEDUDPz98TKzPT1u+kVFQYQA4ouFkXR57qYzv8yJ/UctyM+lqNEx8TiRLIW/BcdipE8sgiTjSQDyhKKC18XjdN/goc7GIq68Ntl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=mDvkB83m; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="mDvkB83m" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so6507181f8f.0 for ; Sun, 08 Mar 2026 09:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1772988172; x=1773592972; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=A2k+tUSmAU+cizjj171ExMhB4UUnW5oz5jUnwF8rErI=; b=mDvkB83mUBgNloaTdKGjkcgYcD/GayY6OlIB8d+xtiAaGONSF9DTjFjZKT8uakAr3F X5Ro03Fh7sR6gdag0ihpyXd0Ogn0uJ38xxTtjOhmVcPlPBlvfqn2ziubQrKSHp1e5syf y23lHN5yEtUoiJyFxy8K1GNxFzCnGtjbov67weXqQUEcdPUTspSDXKM8dbhK8aN+Di1J DCBG491yycGE6ZeCs6FQ7IbVZAeJyQbpxWjywz39x1/bRwrO7dIXkpDWiUBp2hrb+oJo WgaYPkJYqGOVjsW/os40d5ORoAHEerKCxhpywYhphqi+uts7mwFC+IlAy6dGb9ZVEL3S Kg+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772988172; x=1773592972; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A2k+tUSmAU+cizjj171ExMhB4UUnW5oz5jUnwF8rErI=; b=O63U9IesH5stw+r79CUgmFVsrmXXV1UDDy18A8OOPFbU9EMlXPCGbJmOaV1T4FX9f5 Pn1/HuR+4hzkQ/hvWDJQyh8a3FzaKU/qWTI4Wzt2brlaD30pnjHGP8y2tbA2vCJ7y1SB qk1LskKSgeIDIWlPi0zSW8dNo/F8aHQJs09E1aKyZZBPrCppS0eYU1G+dCDPjJ4nb7D3 9Un+FVVHD+awEde27BJxUWXZi8GHQrmAUeWUjWgWiFljXbR8MH3Q4sXIusXrf2a5HVZX oYj2OorObuMiKNs3wT7rczm1bBzSVuHt38UGW0wstx8UeQkr/vFAjhmxbL/MI9ibeqg+ hkFA== X-Forwarded-Encrypted: i=1; AJvYcCVaDokyxmFca3ThfEd3vXRu3Kp/bOtz5ZuO1i+1B6kZMGv2VPsswtmxhqgv3U6ZzXu6GyEwfugp4R3rZA4=@vger.kernel.org X-Gm-Message-State: AOJu0YxTlUFKbPX4mqNOB3VXWdV2opYg6sKn7C+W1hjEXc0yHv4zqxRW dNsxB4KoY/aBB09CAQh9jwfQVbdPGOJZ0Zumd3izTq8bpOaYkaC6xuBuXIE4A64bJKg= X-Gm-Gg: ATEYQzz7hvjC58elfokoGQPLYahv63jbIOxp2E1o1qCXx50xckqDjrd4qaO0mEblwox 0XDD9hbdKnfrpUwsviizfNful1+CzRgCBoZp6vacesnE4F0uhNipU97RKVmiGXDmdee8/fjmtcK UQInJz9txQbKO2YtIHJs/nJTiS2VgW0kYAFjV7rl9liX9UnHkM/0dnHw+EEbLtKA3r9v9flrVOc mP1tnSvceJ1r5htpyrCyr7/fVqPewhvMP1Ct0Ec+B5vZl5az4/zyf8/QJqFqPXihTVHGjMJqnG/ /thuARmu/Gh4Wo/G/wBH9TL29xTZO7586JOAb6FB5tfgjd5Q8VWMFKhjWT2H6EyOnl47BmRtXDw VX7TtlKwlOwozAXNWezApPl1Hvi5sZqOfjkiFKu/QgK9ddV19WrdN8u+QouL5N7/kMmROgI2PJ1 mjYf6rTZaYKAqZ6r444j38M1a/bOKY9A== X-Received: by 2002:a5d:5f93:0:b0:439:b791:f920 with SMTP id ffacd0b85a97d-439da656af4mr15645490f8f.17.1772988171670; Sun, 08 Mar 2026 09:42:51 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dadb85b8sm19331707f8f.17.2026.03.08.09.42.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Mar 2026 09:42:51 -0700 (PDT) Message-ID: Date: Sun, 8 Mar 2026 18:42:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/19] dt-bindings: nvmem: microchip-otpc: Add required clocks To: Nicolas Ferre , Alexandre Belloni , Ryan Wanner , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20260120143759.904013-1-ada@thorsis.com> <20260120154502.1280938-1-ada@thorsis.com> <20260120154502.1280938-3-ada@thorsis.com> <20260220-bloomers-runny-e69ab1966b9c@thorsis.com> Content-Language: en-US From: Claudiu Beznea In-Reply-To: <20260220-bloomers-runny-e69ab1966b9c@thorsis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Alexander, On 2/20/26 11:58, Alexander Dahl wrote: > Hello Claudiu, > > Am Sat, Jan 31, 2026 at 05:47:05PM +0200 schrieb Claudiu Beznea: >> >> >> On 1/20/26 17:44, Alexander Dahl wrote: >>> The OTPC requires both the peripheral clock through PMC and the main RC >>> oscillator. Seemed to work without explicitly enabling those clocks on >>> sama7g5 before, but did not on sam9x60. >>> >>> Older datasheets were not clear and explicit about this, but recent are, >>> e.g. SAMA7G5 series datasheet (DS60001765B), >>> section 30.4.1 Power Management: >>> >>>> The OTPC is clocked through the Power Management Controller (PMC). >>>> The user must power on the main RC oscillator and enable the >>>> peripheral clock of the OTPC prior to reading or writing the OTP >>>> memory. >> >> As this was not mentioned in the previous datasheet versions, the current >> driver don't handle those clocks, and it probably worked as the clocks were >> enabled by bootloaders, I think the clocks should be marked as required and >> this patch to be propagated as a fix along with fixes on driver and device >> trees. > > What do you mean by "clocks should be marked as required"? Where? In the bindings as you found that the IP don't work if the clocks are not enabled? > How? Is something more necessary, than already done here? Update the required section in the yaml file with clocks, at least for the sam9x60, as you found it is not working w/o it. I presume it has to be done for SAMA7G5 as well (as this is what the newer datasheets states) but that would involve adding required clocks now which were not needed later. I'm not sure what is the procedure here. I'll let DT maintainers comment on this. Thank you, Claudiu