From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Zain Aboobacker" <zainaboobacker33@gmail.com>,
"Derek J . Clark" <derekjohn.clark@gmail.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: ibm-acpi-devel@lists.sourceforge.net,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: fix typos in comments
Date: Mon, 28 Sep 2026 11:50:17 -0400 [thread overview]
Message-ID: <cec269cc-cce9-4c3c-aaff-2a3035f2e634@app.fastmail.com> (raw)
In-Reply-To: <20260926162528.25365-1-zainaboobacker33@gmail.com>
On Sat, Sep 26, 2026, at 12:25 PM, Zain Aboobacker wrote:
> Fix various spelling mistakes in comments found by codespell.
>
> Assisted-by: Claude:claude-opus-5-5 codespell
> Signed-off-by: Zain Aboobacker <zainaboobacker33@gmail.com>
> ---
> drivers/platform/x86/lenovo/thinkpad_acpi.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 1225b01ed14d..ee831e6b8fbe 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -2108,7 +2108,7 @@ static int hotkey_mask_set(u32 mask)
> }
>
> /*
> - * We *must* make an inconditional call to hotkey_mask_get to
> + * We *must* make an unconditional call to hotkey_mask_get to
> * refresh hotkey_acpi_mask and update hotkey_user_mask
> *
> * Take the opportunity to also log when we cannot _enable_
> @@ -3770,7 +3770,7 @@ static bool hotkey_notify_dockevent(const u32
> hkey, bool *send_acpi_ev)
> return true;
>
> /*
> - * Deliberately ignore attaching and detaching the keybord cover to avoid
> + * Deliberately ignore attaching and detaching the keyboard cover to avoid
> * duplicates from intel-vbtn, which already emits SW_TABLET_MODE events
> * to userspace.
> *
> @@ -4047,7 +4047,7 @@ static void hotkey_resume(void)
> hotkey_wakeup_hotunplug_complete_notify_change();
> hotkey_poll_setup_safe(false);
>
> - /* restore previous mode of adapive keyboard of X1 Carbon */
> + /* restore previous mode of adaptive keyboard of X1 Carbon */
> if (tp_features.has_adaptive_kbd) {
> if (!acpi_evalf(hkey_handle, NULL, "STRW", "vd",
> adaptive_keyboard_prev_mode)) {
> @@ -7131,7 +7131,7 @@ static bool software_mute_active;
> static int software_mute_orig_mode;
>
> /*
> - * Used to syncronize writers to TP_EC_AUDIO and
> + * Used to synchronize writers to TP_EC_AUDIO and
> * TP_NVRAM_ADDR_MIXER, as we need to do read-modify-write
> */
> static struct mutex volume_mutex;
> @@ -7324,7 +7324,7 @@ static int volume_set_software_mute(bool startup)
>
> /*
> * In software mute mode, the standard codec controls take
> - * precendence, so we unmute the ThinkPad HW switch at
> + * precedence, so we unmute the ThinkPad HW switch at
> * startup. Just on case there are SAUM-capable ThinkPads
> * with level controls, set max HW volume as well.
> */
> @@ -8043,7 +8043,7 @@ TPACPI_HANDLE(fanw, ec, "FANW", /* E531 */
> ); /* all others */
>
> /*
> - * Unitialized HFSP quirk: ACPI DSDT and EC fail to initialize the
> + * Uninitialized HFSP quirk: ACPI DSDT and EC fail to initialize the
> * HFSP register at boot, so it contains 0x07 but the Thinkpad could
> * be in auto mode (0x80).
> *
> @@ -10623,7 +10623,7 @@ static int dytc_profile_set(struct device *dev,
> * To get back to balanced mode we need to issue a reset command.
> * Note we still need to disable CQL mode before hand and re-enable
> * it afterwards, otherwise dytc_lapmode gets reset to 0 and stays
> - * stuck at 0 for aprox. 30 minutes.
> + * stuck at 0 for approx. 30 minutes.
> */
> err = dytc_cql_command(DYTC_CMD_RESET, &output);
> if (err)
> @@ -11685,7 +11685,7 @@ static bool tpacpi_driver_event(const unsigned
> int hkey_event)
> static struct proc_dir_entry *proc_dir;
>
> /*
> - * Module and infrastructure proble, init and exit handling
> + * Module and infrastructure probe, init and exit handling
> */
>
> static bool force_load;
> --
> 2.53.0
All looks good.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Mark
prev parent reply other threads:[~2026-09-28 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 16:25 Zain Aboobacker
2026-09-28 15:50 ` Mark Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec269cc-cce9-4c3c-aaff-2a3035f2e634@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=zainaboobacker33@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®