From: James Clark <james.clark@arm.com>
To: Mike Leach <mike.leach@linaro.org>,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org
Cc: mathieu.poirier@linaro.org, yabinc@google.com
Subject: Re: [PATCH 0/3] Extend logging on TMC start / stop errors
Date: Mon, 13 Feb 2023 10:07:04 +0000 [thread overview]
Message-ID: <cec2d271-2ccc-9d6c-04c7-ea1e8f3e1ee4@arm.com> (raw)
In-Reply-To: <20230210151008.4587-1-mike.leach@linaro.org>
On 10/02/2023 15:10, Mike Leach wrote:
> Recent issues with trying to debug TMC timeouts and flush issues shows
> a general lack of logging and context around the possible errors
>
> Patchset addresses that.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
>
> Mike Leach (3):
> coresight: Update timeout functions to allow return of test register
> value
> coresight: tmc: Update error logging in tmc common functions
> coresight: etf: etr: Update logging around flush_and_stop() errors
>
> drivers/hwtracing/coresight/coresight-core.c | 50 +++++++++++++++----
> .../hwtracing/coresight/coresight-tmc-core.c | 37 +++++++++++---
> .../hwtracing/coresight/coresight-tmc-etf.c | 12 +++--
> .../hwtracing/coresight/coresight-tmc-etr.c | 8 ++-
> drivers/hwtracing/coresight/coresight-tmc.h | 2 +-
> include/linux/coresight.h | 10 +++-
> 6 files changed, 93 insertions(+), 26 deletions(-)
>
Looks good to me.
Reviewed-by: James Clark <james.clark@arm.com>
At some point I might go and add some TRACE_EVENT(coresight_...)s around
things like enabling and disabling devices. It might help to see what
led up to an error rather than just the error itself.
prev parent reply other threads:[~2023-02-13 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:10 Mike Leach
2023-02-10 15:10 ` [PATCH 1/3] coresight: Update timeout functions to allow return of test register value Mike Leach
2023-02-10 15:10 ` [PATCH 2/3] coresight: tmc: Update error logging in tmc common functions Mike Leach
2023-02-10 15:10 ` [PATCH 3/3] coresight: etf: etr: Update logging around flush_and_stop() errors Mike Leach
2023-02-13 10:07 ` James Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec2d271-2ccc-9d6c-04c7-ea1e8f3e1ee4@arm.com \
--to=james.clark@arm.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=yabinc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®