From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andy Lutomirski" <luto@kernel.org>
Subject: Re: [PATCH 1/3] x86/kvm/vmx: read MSR_FS_BASE from current->thread
Date: Tue, 13 Mar 2018 14:24:58 +0100 [thread overview]
Message-ID: <cec32ec2-6f71-0f51-8411-8d6a94881f55@redhat.com> (raw)
In-Reply-To: <87ina0cdto.fsf@vitty.brq.redhat.com>
On 13/03/2018 14:20, Vitaly Kuznetsov wrote:
> vmcs_writel() I guess ... and, just to make sure I follow your
> suggestion, this is for x86_64 only, right? x86_32 does
>
> vmcs_writel(HOST_FS_BASE, segment_base(vmx->host_state.fs_sel));
>
> and I think it needs to stay.
Yes.
> (personally, I'm rather for exporting save_fsgs(), dropping
> savesegment() and getting all we need from current to avoid propagating
> assumptions but I'm flexible)
Yes, that's fine too, as long as it's not mix and match. :)
Paolo
next prev parent reply other threads:[~2018-03-13 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 14:02 [PATCH 0/3] x86/kvm: avoid expensive rdmsrs for FS/GS base MSRs Vitaly Kuznetsov
2018-03-12 14:02 ` [PATCH 1/3] x86/kvm/vmx: read MSR_FS_BASE from current->thread Vitaly Kuznetsov
2018-03-12 15:34 ` Andy Lutomirski
2018-03-12 15:55 ` Vitaly Kuznetsov
2018-03-12 16:03 ` Paolo Bonzini
2018-03-12 16:13 ` Andy Lutomirski
2018-03-12 16:18 ` Paolo Bonzini
2018-03-12 17:00 ` Andy Lutomirski
2018-03-12 17:11 ` Paolo Bonzini
2018-03-13 13:20 ` Vitaly Kuznetsov
2018-03-13 13:24 ` Paolo Bonzini [this message]
2018-03-12 14:02 ` [PATCH 2/3] x86/kvm/vmx: read MSR_KERNEL_GS_BASE " Vitaly Kuznetsov
2018-03-12 14:03 ` [PATCH 3/3] x86/kvm/vmx: avoid expensive rdmsr for MSR_GS_BASE Vitaly Kuznetsov
2018-03-12 15:42 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec32ec2-6f71-0f51-8411-8d6a94881f55@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®