From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Leon Romanovsky <leon@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4 0/2] block: Enable proper MMIO memory handling for P2P DMA
Date: Thu, 13 Nov 2025 10:12:41 -0700 [thread overview]
Message-ID: <cec91b1e-a545-4799-97c3-676e3b566721@kernel.dk> (raw)
In-Reply-To: <176305197986.133468.1935881415989157155.b4-ty@kernel.dk>
On 11/13/25 9:39 AM, Jens Axboe wrote:
>
> On Wed, 12 Nov 2025 21:48:03 +0200, Leon Romanovsky wrote:
>> Changelog:
>> v4:
>> * Changed double "if" to be "else if".
>> * Added missed PCI_P2PDMA_MAP_NONE case.
>> v3: https://patch.msgid.link/20251027-block-with-mmio-v3-0-ac3370e1f7b7@nvidia.com
>> * Encoded p2p map type in IOD flags instead of DMA attributes.
>> * Removed REQ_P2PDMA flag from block layer.
>> * Simplified map_phys conversion patch.
>> v2: https://lore.kernel.org/all/20251020-block-with-mmio-v2-0-147e9f93d8d4@nvidia.com/
>> * Added Chirstoph's Reviewed-by tag for first patch.
>> * Squashed patches
>> * Stored DMA MMIO attribute in NVMe IOD flags variable instead of block layer.
>> v1: https://patch.msgid.link/20251017-block-with-mmio-v1-0-3f486904db5e@nvidia.com
>> * Reordered patches.
>> * Dropped patch which tried to unify unmap flow.
>> * Set MMIO flag separately for data and integrity payloads.
>> v0: https://lore.kernel.org/all/cover.1760369219.git.leon@kernel.org/
>>
>> [...]
>
> Applied, thanks!
>
> [1/2] nvme-pci: migrate to dma_map_phys instead of map_page
> commit: f10000db2f7cf29d8c2ade69266bed7b51c772cb
> [2/2] block-dma: properly take MMIO path
> commit: 8df2745e8b23fdbe34c5b0a24607f5aaf10ed7eb
And now dropped again - this doesn't boot on neither my big test box
with 33 nvme drives, nor even on my local test vm. Two different archs,
and very different setups. Which begs the question, how on earth was
this tested, if it doesn't boot on anything I have here?!
--
Jens Axboe
next prev parent reply other threads:[~2025-11-13 17:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 19:48 Leon Romanovsky
2025-11-12 19:48 ` [PATCH v4 1/2] nvme-pci: migrate to dma_map_phys instead of map_page Leon Romanovsky
2025-11-12 23:57 ` Chaitanya Kulkarni
2025-11-12 19:48 ` [PATCH v4 2/2] block-dma: properly take MMIO path Leon Romanovsky
2025-11-12 20:00 ` Keith Busch
2025-11-12 23:57 ` Chaitanya Kulkarni
2025-11-13 16:39 ` [PATCH v4 0/2] block: Enable proper MMIO memory handling for P2P DMA Jens Axboe
2025-11-13 17:12 ` Jens Axboe [this message]
2025-11-13 17:45 ` Jens Axboe
2025-11-13 19:50 ` Leon Romanovsky
2025-11-13 20:03 ` Keith Busch
2025-11-13 20:13 ` Leon Romanovsky
2025-11-13 20:40 ` Leon Romanovsky
2025-11-13 20:43 ` Jens Axboe
2025-11-14 8:13 ` Leon Romanovsky
2025-11-13 19:52 ` Keith Busch
2025-11-13 20:40 ` Jens Axboe
2025-11-14 8:16 ` Leon Romanovsky
2025-11-14 12:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec91b1e-a545-4799-97c3-676e3b566721@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®