From: Marcelo Jimenez <mroberto@cpti.cetuc.puc-rio.br>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
Wolfram Sang <w.sang@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
Date: Wed, 24 Mar 2010 20:20:19 -0300 [thread overview]
Message-ID: <cecb6d8f1003241620v55fb960ds14818bf3a03fa334@mail.gmail.com> (raw)
In-Reply-To: <20100324230729.GA21359@n2100.arm.linux.org.uk>
On Wed, Mar 24, 2010 at 20:07, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Wed, Mar 24, 2010 at 08:04:58PM -0300, Marcelo Roberto Jimenez wrote:
>> - debug(skt, 2, "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n",
>> - (state->csc_mask==0)?"<NONE> ":"",
>> - (state->csc_mask&SS_DETECT)?"DETECT ":"",
>> - (state->csc_mask&SS_READY)?"READY ":"",
>> - (state->csc_mask&SS_BATDEAD)?"BATDEAD ":"",
>> - (state->csc_mask&SS_BATWARN)?"BATWARN ":"",
>> - (state->csc_mask&SS_STSCHG)?"STSCHG ":"",
>> - (state->flags==0)?"<NONE> ":"",
>> - (state->flags&SS_PWR_AUTO)?"PWR_AUTO ":"",
>> - (state->flags&SS_IOCARD)?"IOCARD ":"",
>> - (state->flags&SS_RESET)?"RESET ":"",
>> - (state->flags&SS_SPKR_ENA)?"SPKR_ENA ":"",
>> - (state->flags&SS_OUTPUT_ENA)?"OUTPUT_ENA ":"",
>> + debug(skt, 2, "mask: %s%s%s%s%s%s "
>> + "flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n",
>
> NAK. Breaking kernel messages across multiple lines makes them impossible
> to grep for. checkpatch.pl is wrong on this one.
I will redo it, no problem. But just for my information, in that
particular case, is it usefull to grep using format specifiers?
next prev parent reply other threads:[~2010-03-24 23:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 23:04 [PATCH 1/2] ARM: pcmcia: Fix for building DEBUG with sa11xx_base.c as a module Marcelo Roberto Jimenez
2010-03-24 23:04 ` [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c Marcelo Roberto Jimenez
2010-03-24 23:07 ` Russell King - ARM Linux
2010-03-24 23:20 ` Marcelo Jimenez [this message]
2010-03-26 15:56 ` Valdis.Kletnieks
2010-03-25 10:19 ` Sergei Shtylyov
2010-03-25 18:26 ` Valdis.Kletnieks
2010-03-26 18:18 ` Russell King - ARM Linux
2010-03-26 21:57 ` Marcelo Jimenez
2010-03-26 23:06 ` Russell King - ARM Linux
2010-03-24 23:45 ` Marcelo Roberto Jimenez
2010-03-25 17:04 ` Dominik Brodowski
2010-03-25 17:47 ` Marcelo Jimenez
2010-03-28 9:44 ` Russell King - ARM Linux
2010-03-28 9:46 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cecb6d8f1003241620v55fb960ds14818bf3a03fa334@mail.gmail.com \
--to=mroberto@cpti.cetuc.puc-rio.br \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®