From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F8D8CA9ECF for ; Fri, 1 Nov 2019 17:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 172B5205C9 for ; Fri, 1 Nov 2019 17:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729384AbfKARBo (ORCPT ); Fri, 1 Nov 2019 13:01:44 -0400 Received: from baldur.buserror.net ([165.227.176.147]:53108 "EHLO baldur.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729245AbfKARBn (ORCPT ); Fri, 1 Nov 2019 13:01:43 -0400 Received: from [2601:449:8480:af0:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQaGe-0005Iv-Bg; Fri, 01 Nov 2019 11:59:20 -0500 Message-ID: From: Scott Wood To: Christophe Leroy , Rasmus Villemoes , Qiang Zhao , Li Yang Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 01 Nov 2019 11:59:19 -0500 In-Reply-To: <5071118d-2008-7725-a6cd-ce14b49dfa20@c-s.fr> References: <20191018125234.21825-1-linux@rasmusvillemoes.dk> <20191101124210.14510-1-linux@rasmusvillemoes.dk> <20191101124210.14510-27-linux@rasmusvillemoes.dk> <5071118d-2008-7725-a6cd-ce14b49dfa20@c-s.fr> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2601:449:8480:af0:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: christophe.leroy@c-s.fr, linux@rasmusvillemoes.dk, qiang.zhao@nxp.com, leoyang.li@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH v3 26/36] soc: fsl: move cpm.h from powerpc/include/asm to include/soc/fsl X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-11-01 at 17:18 +0100, Christophe Leroy wrote: > > Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit : > > Some drivers, e.g. ucc_uart, need definitions from cpm.h. In order to > > allow building those drivers for non-ppc based SOCs, move the header > > to include/soc/fsl. For now, leave a trivial wrapper at the old > > location so drivers can be updated one by one. > > I'm not sure that's the correct way to go. > > As far as I know, CPM is specific to powerpc (or maybe common to some > motorola 68000). So only powerpc specific drivers should need it. > > If cpm.h includes items that are needed for QE, those items should go in > another .h > > Of course, it doesn't mean we can't move cpm.h in include/soc/fsl, but > anyway only platforms having CPM1 or CPM2 should include it. QE is basically CPM3 so it's not surprising that cpm.h would be needed. I wonder how much less unnecessary code duplication there would have been if marketing hadn't decided to change the name. -Scott