From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D10C433FE for ; Mon, 3 Oct 2022 11:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbiJCLiy (ORCPT ); Mon, 3 Oct 2022 07:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbiJCLiu (ORCPT ); Mon, 3 Oct 2022 07:38:50 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9A0D248C5 for ; Mon, 3 Oct 2022 04:38:49 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E26276602045; Mon, 3 Oct 2022 12:38:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664797128; bh=VaX129b4BNwVQU4FPh9jbsOSti9h5ZFnOnyy64nSsnM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YXMd6j0kIOIjv7crq7kTWn8nHhYIHjMOXxJGSeOHA9HD0/0Pd7wKgnyVCFjutzDBm w+zdjMDKDLQV9c6ZyBwNLePYI6zLn1eeQbS9/zxqvQExEaA+KVqoGBCHJX2msaXKu6 7BtVIqn4KA4eAhGApyavHGLg1igD6lMgkZLNflEw/vXZQH5sFXK5/YJqMWJhXyk9LF JzPuFiPeyvYr9xH/GtVzuwusTrREvmqH5P1kndVc4JEQwDHv+brd3ujqe/oB2/jXy1 aeyTh466cxuRfTauV9tyXTG/VZxhW63yptaFDBzXSCMkg96HGLySO1v4z82lwYopUN ekRoIKkCYbDpw== Message-ID: Date: Mon, 3 Oct 2022 13:38:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 1/2] drm/bridge: it6505: Adapt runtime power management framework Content-Language: en-US To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, Hermes Wu , Allen Chen , Hsin-Yi Wang , dri-devel@lists.freedesktop.org References: <20221003050335.1007931-1-treapking@chromium.org> <20221003050335.1007931-2-treapking@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20221003050335.1007931-2-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 03/10/22 07:03, Pin-yen Lin ha scritto: > Use pm_runtime_(get|put)_sync to control the bridge power, and add > SET_SYSTEM_SLEEP_PM_OPS with pm_runtime_force_(suspend|resume) to it6505 > driver. Without SET_SYSTEM_SLEEP_PM_OPS, the bridge will be powered on > unnecessarily when no external display is connected. > > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") > Signed-off-by: Pin-yen Lin > > --- > > Changes in v2: > - Handle the error from pm_runtime_get_sync in it6505_extcon_work > > drivers/gpu/drm/bridge/ite-it6505.c | 33 +++++++++++++++++++++-------- > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c > index 2bb957cffd94..685d8e750b12 100644 > --- a/drivers/gpu/drm/bridge/ite-it6505.c > +++ b/drivers/gpu/drm/bridge/ite-it6505.c > @@ -421,6 +421,7 @@ struct it6505 { > struct notifier_block event_nb; > struct extcon_dev *extcon; > struct work_struct extcon_wq; > + int extcon_state; > enum drm_connector_status connector_status; > enum link_train_status link_state; > struct work_struct link_works; > @@ -2685,31 +2686,42 @@ static void it6505_extcon_work(struct work_struct *work) > { > struct it6505 *it6505 = container_of(work, struct it6505, extcon_wq); > struct device *dev = &it6505->client->dev; > - int state = extcon_get_state(it6505->extcon, EXTCON_DISP_DP); > - unsigned int pwroffretry = 0; > + int state, ret; > > if (it6505->enable_drv_hold) > return; > > mutex_lock(&it6505->extcon_lock); > > + state = extcon_get_state(it6505->extcon, EXTCON_DISP_DP); > DRM_DEV_DEBUG_DRIVER(dev, "EXTCON_DISP_DP = 0x%02x", state); > + > + if (state == it6505->extcon_state) > + goto unlock; Even if it's unlikely for anything bad to happen, please add error handling, or we might end up with unbalanced pm_runtime calls. if (state == it6505->extcon_state || unlikely(state < 0)) goto unlock; it6505->extcon_state = state; if (state) { .... } else { .... } Regards, Angelo