From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 892C72D3228 for ; Tue, 18 Nov 2025 09:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458889; cv=none; b=a+7UgR8Lfr6tkJJDzAR8MmOdwCQlpogcFz4SiWXx3H9SfursaIKqsWQFUA9SxsWbGOf2jUyAQbf6PXzDFVZR8PmSHITKE+4ot8N7OYzxHDAjhMEyuxE4RDHIObhah3t0DiL4zYe/6v+U7pF8MGIPWtSTLAD/cBqjeoYPAG9bewM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458889; c=relaxed/simple; bh=nakmxTpXhROsCut7CjTH+rY0k2mx1pEXcnbMBfwjAkE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rSK1K0KiBYezsYSNqo6tvgM+MYbrHtPQRnhA5SEaRkflXQg1fACFbNW8C9epn4cZi0/+285YEPS09jaCG483wIqX1T0Fk9ilD6mhqgghVB2FoNXvI1coLd1esmyznXAYPqGmsGuE7Zlzj1Gh04MXR/o7ucU1nRyb6DNxUd1XNJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H2Yv1UIN; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H2Yv1UIN" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42b38de7940so2965909f8f.3 for ; Tue, 18 Nov 2025 01:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763458886; x=1764063686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gtnKVLFkBU3sduSzw1o97JWvysAHMmEiAWVYPf3fezk=; b=H2Yv1UIN/3LbC+ivIuOuVE1yuZqsGok5HfcKzVIe7jl+KsKZBr4Q+bClm2lO7DUspJ 9RRjPpX+e4JnZpVu+R4uTfc/QleT3MUkkx1Vyp/R56zbOjoaOPBRlhWVI64hgoukfuHn gPR8oMcOwCbEX/61C6uaItwv5h8L8TMCwLyYiVyF3JrFF4iANir94MULcBMAmoB+EyyL Q9ui7X60EPXAYbyQ6GVHTUUMnj+4pQ9VOI/G97U9BsoV77ql8t/40jjjKenhFvF2Z9FX 6EYcNlIi6vAztRFdrQ5MwDs1mwbxt7uvhbfp++ZxPOzMQXN5tkRtjQVq2uZO9y/bsnqv qxdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763458886; x=1764063686; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gtnKVLFkBU3sduSzw1o97JWvysAHMmEiAWVYPf3fezk=; b=Rn0wX6YivkmkoKuEMx519Nhvecg8W9Ldiehg7eGkIIpKGQ+qn2fPr76OeXt4dknW1X rZfQ3Sg5/aSofHuYxabD7BDd+IxfH7tDGxXVtawnJZHliUEq68YX/K7nmpZgTMc0jHN8 xSB/1pRPx43ouxE18hgSRIYtBY5jRYCHtQEwltkl3EIw179UJdBMK8viX91h52R60Qj8 WBQSJAm6sE2qah2nghu+o+uQ9XeOav0AxquIGx05da72I3bow4ATKrKTxS61G50jYLcw b+R7kgMYAaJRQSgKr6UrJafDbBxS6rvbBvkkO293fZXZJ/Ufn15DDPyFY9amp7geNVw0 vmSA== X-Forwarded-Encrypted: i=1; AJvYcCUJtzhXOSUBFq6OiiHn5/CzmEScHgJ/aJ7Q0ahtDcrX6VLzNXQNJWfAZzdoRUmnssvI9Rjpt9BKxlTcJug=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5s40qx0rZOZxC4tu+snMqF5Dss3e3tQ4nOUXILZmeDyLF60zN uA0Q5nFFknY/y9V5hhEUsWQreBeHOeZJMEiSd5umgD27xZhW6XwwT+UT7zMkcD3uir4= X-Gm-Gg: ASbGnct6f8iMM8bGY0hr9fx99oO2XtNZlU0ylrkGEqPmN5BRKrlEjqWj0PNFVh2oNaJ MJqygth4x32NXirsLqutkl/oNDgRT8K04bWjK79nQtPxGWBoZov6Xwu/URl4wU44vHBsg7uwGoh ktOdA1aizUE7PcbPwMyrK7GfNcqMXD9GdVAcPsFxgHSYf2+owHIdsdpo1aw9ERr7E8g95B4IBIf aJcgRJnZTBdjotZYntzoCKmnEV5fP2cJFiw59IQ9bh3lxHeuscCjYiCKFzVUZ2CWZxCRJJDTCzX 7eR52QcLQZ1y0KCXYG6eRshyKruBLO8zKM5uDOpo6jFQLvF9RI0u/9ev6R3nyuA/Xk6gWFr7aPy +OvLvdSPOuVyFta0Wk8bSkZIAiizJApXtkzjFOB/QFkeF20aAD/7ARd4iD+GEFsjw1pxsdSI3Q+ NE1R+LbH9CCxwmGbN9smjNSdykmoSiEZ4CRX9rCrj0MTZaPVkPEmEMlXkwJQJ38OM= X-Google-Smtp-Source: AGHT+IEx0A12Mrv+XQJGWIZngs9UaDoduZw2cyhd7A56k2LZLTca+iipujhKE4+927JtK5S04+21rQ== X-Received: by 2002:a5d:5850:0:b0:42b:2a09:2e59 with SMTP id ffacd0b85a97d-42b592c6797mr14785840f8f.0.1763458885861; Tue, 18 Nov 2025 01:41:25 -0800 (PST) Received: from [192.168.0.27] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b62dsm31225819f8f.24.2025.11.18.01.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 01:41:25 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 09:41:22 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] media: qcom: camss: csid: Add support for CSID 1080 To: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251113-add-support-for-camss-on-kaanapali-v6-0-1e6038785a8e@oss.qualcomm.com> <20251113-add-support-for-camss-on-kaanapali-v6-4-1e6038785a8e@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251113-add-support-for-camss-on-kaanapali-v6-4-1e6038785a8e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/11/2025 03:29, Hangxiang Ma wrote: > + /* note: for non-RDI path, this should be format->decode_format */ > + val |= DECODE_FORMAT_PAYLOAD_ONLY << RDI_CFG0_DECODE_FORMAT; > + val |= vc << RDI_CFG0_VC; > + val |= format->data_type << RDI_CFG0_DT; > + writel(val, csid->base + CSID_RDI_CFG0(vc)); Why not just add that code now ? --- bod