From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54ABF84E1C for ; Wed, 23 Oct 2024 03:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729654178; cv=none; b=cMGy9Z/KTEGsavVVPVblBPAUETse6XHpWqA2fkp0NeBpNIn04pTWwM03YG6kjowtIZhwk+TrOn3V8RshTIwv+ClDDIb7X6VskyJcGBsye2FQ7UajGQfl0k7S2OEsruFIVvhwRK5xLP/tomIPikvVbdMbEjAhkrdyYCEIehF+WUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729654178; c=relaxed/simple; bh=+6Fpco6V5O5W5cKFQk4z7cMXSUa3B3pMKCtFO1yDXmo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JqntK7iLmkp6NJq/UALoUh8km/NMJjsmElykeY3xmCl5PrIb7VevlvAvBQxWRjF14GJjV2qjedUe0Li/5OQgdQEQJ731MgQGQajIP7/ToyXByADkeaYS2p5V/aWUAFI4cCoxLv3XCuFdFIJdHjwYBjhcfNpxCM289W2FEst2MBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QqF39cjY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QqF39cjY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729654175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BxnxAqHSQi/PSdbsWFTBVvnXn1V933dFV5xw+gHP+cE=; b=QqF39cjYDzuPfMCsHWiowAs2fW1B3sI6OT/MWbONUNInFzhZIPlwytNpAGEhYnwJQ21Lp5 W5kGc1+CET6NG5C+2n8/TLYhc5qcFaasRFyKJHhKd9mUqEvF2d05L26Batmpc6aQIdvmK2 BEDk4EK6lOUodqrOm4iXH72ZvX1RSkY= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-J8O8V80_PsmF8U3Gimn6Og-1; Tue, 22 Oct 2024 23:29:33 -0400 X-MC-Unique: J8O8V80_PsmF8U3Gimn6Og-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-20e56815e1cso63810875ad.3 for ; Tue, 22 Oct 2024 20:29:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729654172; x=1730258972; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BxnxAqHSQi/PSdbsWFTBVvnXn1V933dFV5xw+gHP+cE=; b=AjbUAU5sxgD9PEfXjYHYGjjwCgV8H4XVZ04p6l0bPwNOEPyXWab3f0OCkLbA8moSeQ 0nGpKvd3tahpaP83qYpFWMkQyQ1nwdyGtRpSjqnW42rkqk/FMe/xOVpfNfdnz+g69hm+ JwDjEiJw5+2mMZa67CROhxAKFb/IonhlNr+OkxvStpvLXaYS9/fBB9HeYKQ9QroHXVnk MhaGCYvpV/1DG+HbCpYlWyRgkpjzlERpaOOpPh5xFvs9eG5EnQVsg2gArjvGVgArkFGc a9vSfi/r6dCmVfWJasj2CmIGACKSURWc+2eK2kXd5c9YLepVIVPjjBB2NcGOWtiNCKUy w1vw== X-Forwarded-Encrypted: i=1; AJvYcCXtPW69iFHOXAID8GbCWwVy17GzOjyR2CjSdKt7o44Gco3TpfGZWJF6GIgtXO3Bxl6KFhAXTQ/aLbNJwKw=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ1QTYBmrwsvebH6OMWRsl3DbrsmuYC8lef1tgUvgu6rnWmYd8 Ak2kAk79G3EEsksF9GnCYSduDVk7n5lzOAOmfKRfOpr4LFBTbmUXGJ5sqSlmcxWHTiuAtDU5uPn RTdqy4is067Rh4qmLdxbdwA+oQcmQ9hhesvwTNwrIGCWbYzsPq/MzRQIEfl5ZrQ== X-Received: by 2002:a17:903:2341:b0:20b:c17f:9dad with SMTP id d9443c01a7336-20fa9ec370amr16333775ad.53.1729654172462; Tue, 22 Oct 2024 20:29:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/KUd89Pt2YvF/xk5+quJmm3qmrZIAqXkpVnz5dgxwgUq57HEfxmUaUue1V2fl4MBr5OEe5A== X-Received: by 2002:a17:903:2341:b0:20b:c17f:9dad with SMTP id d9443c01a7336-20fa9ec370amr16333565ad.53.1729654172128; Tue, 22 Oct 2024 20:29:32 -0700 (PDT) Received: from [192.168.68.54] ([180.233.125.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7ef0cf95sm49357305ad.70.2024.10.22.20.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 20:29:31 -0700 (PDT) Message-ID: Date: Wed, 23 Oct 2024 13:29:21 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 10/11] virt: arm-cca-guest: TSM_REPORT support for realms To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Sami Mujawar , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , Dan Williams , "Aneesh Kumar K . V" References: <20241017131434.40935-1-steven.price@arm.com> <20241017131434.40935-11-steven.price@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20241017131434.40935-11-steven.price@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/17/24 11:14 PM, Steven Price wrote: > From: Sami Mujawar > > Introduce an arm-cca-guest driver that registers with > the configfs-tsm module to provide user interfaces for > retrieving an attestation token. > > When a new report is requested the arm-cca-guest driver > invokes the appropriate RSI interfaces to query an > attestation token. > > The steps to retrieve an attestation token are as follows: > 1. Mount the configfs filesystem if not already mounted > mount -t configfs none /sys/kernel/config > 2. Generate an attestation token > report=/sys/kernel/config/tsm/report/report0 > mkdir $report > dd if=/dev/urandom bs=64 count=1 > $report/inblob > hexdump -C $report/outblob > rmdir $report > > Signed-off-by: Sami Mujawar > Signed-off-by: Suzuki K Poulose > Signed-off-by: Steven Price > --- > Changes since v6: > * Avoid get_cpu() and instead make the init attestation call using > smp_call_function_single(). Improve comments to explain the logic. > * Minor code reorgnisation and comment cleanup following Gavin's review > (thanks!) > --- > drivers/virt/coco/Kconfig | 2 + > drivers/virt/coco/Makefile | 1 + > drivers/virt/coco/arm-cca-guest/Kconfig | 11 + > drivers/virt/coco/arm-cca-guest/Makefile | 2 + > .../virt/coco/arm-cca-guest/arm-cca-guest.c | 224 ++++++++++++++++++ > 5 files changed, 240 insertions(+) > create mode 100644 drivers/virt/coco/arm-cca-guest/Kconfig > create mode 100644 drivers/virt/coco/arm-cca-guest/Makefile > create mode 100644 drivers/virt/coco/arm-cca-guest/arm-cca-guest.c > Reviewed-by: Gavin Shan