From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23F223B47FD for ; Mon, 17 Aug 2026 11:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786965886; cv=none; b=n6kU2frsmFaSXp2IxLywzNTmdMWiHuVMX0n2W8yRYI0IG/6ckAPXBO2/nTJghLNQmI34tsSJqg7OvN/yzbZpzBch1us2oOpxDlYrL4kTVco9PxFYzdFa1OT0d/DKR1BBiD03n5+YqaFQliD+WK1rDErhs+XSyqlIjRNZsJY/82Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786965886; c=relaxed/simple; bh=M1QVpyQl+tfoWBjiEFQ4lxipLnUlVCZK93NhJ2zuUVc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q1aq5fmstJ0eWY6UVytumUEAQIqwGpFpu7+qlB34hOemT8Moh9HX10pTQ2Qk8g2z82nYFGwp1qNbW4I6m3jvbjyW6iz9SJbZc6SHmBdVfemyx9rfOA3PW0Ec7MC+6AWRJ9jiBWcTrnzBk+LzAEpHLmKxx2YmGbJ+o/sNJtqWVb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HWEMgDI4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DzRvDfAw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HWEMgDI4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DzRvDfAw" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67H9ddIi1962465 for ; Mon, 17 Aug 2026 11:24:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qcs1zBqNu56tW75IOxQG//EA+2Y3fUZLHsadckfVa2M=; b=HWEMgDI4T4XA/OQa W39aEezwHqNCSHjTBhPeW7KbSS55m9qsAPm7j0HeE/zvoTSypT1LipWPoIXLJ8yr yoWUJYHqOesGVYgLnS2csP9IXtlWb5E5RRMU5Jq0XEohhfOZ+vPC9qyfvcDEWpR1 K+zwP6NtQJgBkjMxKtc4KjfnlIFLOD0UBU8e8fSThvpoFJeVhjNQZmpmDJk2c9S8 +thd4uPVhH3ZfI9tHN8ZhhCT0TwnXgDpC1XU6z19TA7xc1mAvMhZ9hj82zVmmUvN MRVu8E545TvuZNKwZilpXqMvHD/b2hr2tzMpOQ9hiq4JCQ9fBEbHLeVyclCnUPQn E0//Xw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3wregxta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 11:24:44 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51ca37ce4c3so3672141cf.3 for ; Mon, 17 Aug 2026 04:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786965883; x=1787570683; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qcs1zBqNu56tW75IOxQG//EA+2Y3fUZLHsadckfVa2M=; b=DzRvDfAw6IlFYZPtLuXQKp4DseW1zysNrBPcLvMdNPReeDovk2MgJG8ydl86We3Db9 U8th3PyGenMjGE0Bh2enZit4sMgJswZnAK54t6F6MRs76P/rMvq7oqn+c8JpjO6BIZkd BfQS56aAvnhqqwLb0Hu9GJ1vMW8zYRE518OT+lvGug12EMeH2hX6YI7Qotu9yRauHchy GV3NW9ByXrCqcLSCXiWT6eY8Fif4fuqdEZZ/lcJ+5wzXnqWszog4+d9x6hFLSDUzbNev 1t558A3rt6S3WxVB7Ul17ruIaJa5+srKtGeYBeNZjXv8yj7wZvSSB7PxHXlwd194I9wE EmuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786965883; x=1787570683; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qcs1zBqNu56tW75IOxQG//EA+2Y3fUZLHsadckfVa2M=; b=CbmIO1XwMUGlOk6G2YcfkQobTli8USrZySX+OFfh/LJHNO8JQsRnoNnsQg3qqvIwvS FtlgVKAqWQ87FdPGYDF4wpmlnhelBCs4fLtab7C+UYrUQzNJC31Itg16ph95f5r5Dgrh NMyJQfe8kfOd6CfytJhUovNPsMV0hgOLJQFzT/5S2Iyh4xV2C5HmOruMijcZ/W2E1Do/ 0g9tqEQXaoxQ5uDJH8uo5UJWuMc3I91uPiNCI/eeP4hiQHuyAdUYba9F8kdRc0jXae0N lw+O93EsDGsPM7inlwBasZM6LNRYdqzOU2/VYtfRkXhadS/Rk7QAw7pMSC2A0SBSdG06 GrLA== X-Forwarded-Encrypted: i=1; AHgh+RrnVUjH5IncMEh7sG1g1H91/w2lwBEJncg0NYm3usZwXz345c9eBXoOeyBDOOrLkTQLfWz93Ulo/LEtxdk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx516FqcnbRfhBN3THSOvbkGAx6UTfPVVgeQpqw+BvVtMmParw5 Zg4A7HR/MfeI5/WzWvMOIIEZoMqteZGWU4by2JBCAQeke4JkokQM1L1Ju0OXNTjBSkzpRB4bRpj cE3pbZrELuysAVcuaSKrxScDX5Zk8UdfbNWYvbIzfhrsbsCvI+smSyWrFvCB8HM+r3nY= X-Gm-Gg: AR+sD126svFsHY7OTxXds0tBkGVCYDXbVfyZsqIc3rALqQ8R5R6Q0VNi0MnjxoaiwMk rz4OJCSddg5Kj/mxhLcieK6NQ5vY1wIZeDArBQs/FRZ1oLFjFE4gas0ID1zSuZWMpfDimNrXT/c 14NAMY6pzooX7NJiKAYCwmVWOUeD9m/A5OL388cUJ1Ygu6h6OeAZFyxG1RT2eTqYOh6xHmcbR52 xiMeB3Ck1PBB8PgdN5Fo8mR0t88tjgJBIDm6bNjmoR7WV6OTJmGX5sXZlF3IaWR72FKlg2fWJip 02i8BJSs18MOyvbCsCSk1ADXjQVGNZIHYN0vS3yYIIks0AVevDy6ZJruLX3ORF0eZjegFcYydol mitriPa47LPiDxC1ug6QzmaWY X-Received: by 2002:a05:622a:1787:b0:51b:f40b:2faf with SMTP id d75a77b69052e-52d854b8b9dmr194454441cf.4.1786965883391; Mon, 17 Aug 2026 04:24:43 -0700 (PDT) X-Received: by 2002:a05:622a:1787:b0:51b:f40b:2faf with SMTP id d75a77b69052e-52d854b8b9dmr194453971cf.4.1786965882931; Mon, 17 Aug 2026 04:24:42 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d85883cbsm495142a12.15.2026.08.17.04.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 04:24:41 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 13:24:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] media: venus: report the frame size of the codec being enumerated To: Dmitry Baryshkov , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Stanimir Varbanov , Hans Verkuil , Tomasz Figa Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab References: <20260812-venus-8996-v1-0-6615f82a63b8@oss.qualcomm.com> <20260812-venus-8996-v1-3-6615f82a63b8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260812-venus-8996-v1-3-6615f82a63b8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=FqI1OWrq c=1 sm=1 tr=0 ts=6a82ef7c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=FViGdUMYcZh3DYrJdpUA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: MN5wjmkx_lhcVIho3V01soobrEtPRCrK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDA4NSBTYWx0ZWRfX2V6nUrtfSfmY WdffNLIsSAKGxsFd8CkpAJeDE2yAb57H5V5zxNr8+g9L9Bnn61hVxFLrdl2QKqurBaL/H42p38z uKnxYUBEz4tNasbY6FnlRLG+f0eG8TfpACtnCpXEfc4aoITszi+nEyn6YHjk19Cwfyu0MBz9O+/ QoFUbtvudp8Nveex9taLXsCk3ryG6xT8D4RoJuYgTwSqszn3A4lF46fueA/fwbJQrz8UgJctCCm bF3HrZtZ10xszdIBw5VdC0A+qn868lT61l6r7S9oUUVQOnY/n6CLMUP0fbTxH2nf4dWo7Eb7jug uADnBxaq1Rr6BZ6vMb1H5rquCG11FkHuTU+Vy2Kjkxr+gLvtbdjdm7m+M3oQjoVA+BTR0neqY48 mTOV1hFFLXVxy2Scy5DPRuMT9btufEmomDWg8KmIsIptzf/+GFqe8Tyj9U2xSioY7UIJ/o2qPZS TMClW04QeP1sYukcBPQ== X-Proofpoint-GUID: MN5wjmkx_lhcVIho3V01soobrEtPRCrK X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDA4NSBTYWx0ZWRfX1yUFv6TNvdHH aqVM7lsQ/ipjQqbIQ+nxNT5wgtQciJYReQxcSLGHLBD3Nv4/TDb6T/lT9QhyH2EIkVm8aOWcnXq HbRyakQxJBQYQ4lQv4ScCxQcGJ9dnWo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_06,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170085 On 8/12/26 10:01 PM, Dmitry Baryshkov wrote: > VIDIOC_ENUM_FRAMESIZES takes the pixel format to describe from > userspace, but both vdec and venc answer it out of frame_width_min() and > friends, which resolve the capabilities through inst->hfi_codec, the > codec the instance is currently set to. Enumerating any format other > than that one therefore returns the limits of an unrelated codec: on a > freshly opened decoder, which starts out as H.264, asking about MPEG-2 > on MSM8996 reports the H.264 limits where the firmware describes MPEG-2 > as 16x16 to 1920x1920. You gave some numbers for MPEG-2, saying H.264 has some different numbers. I think it would be slightly easier to parse if you either skipped them or gave numbers for both codecs > Resolve the capabilities through the format being enumerated instead, > falling back to the codec in use for the raw formats, which have no > codec of their own. Both drivers now share one helper, alongside the > pixel format to codec mapping that venus_helper_check_codec() already > carried. > > Assisted-by: Claude:claude-opus-5 > Signed-off-by: Dmitry Baryshkov > --- [...] > -bool venus_helper_check_codec(struct venus_inst *inst, u32 v4l2_pixfmt) > +static u32 venus_pixfmt_to_hfi_codec(u32 v4l2_pixfmt) > { > - struct venus_core *core = inst->core; > - u32 session_type = inst->session_type; > - u32 codec; > - > switch (v4l2_pixfmt) { > case V4L2_PIX_FMT_H264: > - codec = HFI_VIDEO_CODEC_H264; > - break; > + return HFI_VIDEO_CODEC_H264; We already have this - to_codec_type() in hfi.c Konrad