From: Oliver Neukum <oneukum@suse.com>
To: Jeongjun Park <aha310510@gmail.com>, gregkh@linuxfoundation.org
Cc: colin.i.king@gmail.com, kees@kernel.org, gustavo@embeddedor.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+b8080cbc8d286a5fa23a@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: iowarrior: fix infoleak in iowarrior_read()
Date: Thu, 12 Sep 2024 19:07:47 +0200 [thread overview]
Message-ID: <cedf861a-bc1c-4677-983f-321407503f9e@suse.com> (raw)
In-Reply-To: <20240912163413.10019-1-aha310510@gmail.com>
On 12.09.24 18:34, Jeongjun Park wrote:
> The dev->read_queue buffer memory allocated from iowarrior_probe is
> allocated in an uninitialized state, and it is possible to copy the
> uninitialized memory area to the user buffer through iowarrior_read.
Hi,
I am very sorry, but this is not a proper fix. That this happens
shows that the driver has a bug in iowarrior_read(). Zeroing out
the buffer just papers over it.
Regards
Oliver
prev parent reply other threads:[~2024-09-12 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 16:34 Jeongjun Park
2024-09-12 17:07 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cedf861a-bc1c-4677-983f-321407503f9e@suse.com \
--to=oneukum@suse.com \
--cc=aha310510@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+b8080cbc8d286a5fa23a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®